[PATCH v7 0/6] sh73a0 common clock framework implementation

[PATCH v7 0/6] sh73a0 common clock framework implementation

[Ulrich Hecht]

Hi!

Here's the sh73a0 CCF driver with two fixes for issues in the frequency
calculation for the z and dsi?phy clocks found by Geert and Laurent.

CU
Uli


Changes since v6:
- removed unused divider masks and flags
- consider FRQCRB:ZSEL when calculating z clock
- fixed dsi?phy PLL frequency calculation
- added Acked-by

Changes since v5:
- use clock-indices instead of renesas,clock-indices
- added Tested-by

Changes since v4:
- reordered MSTP clock assignments to directly follow interrupts property

Changes since v3:
- fixed bindings to match the implementation
- handle extal division in CPG driver, dump extal?_div2_clk
- added acks
- dropped eth clock hack

Changes since v2:
- split CCF DT description
- tabbed constants in CPG bits header file
- reordered patches to avoid need for shmobile_clk_workaround()
- removed said workaround
- squashed unmerged remains of CMT1 DT description into MSTP clocks patch
- renamed clock zb1 to zb
- removed DIV6 stuff, will be a separate series

Changes since v1:
- div6 patch replaced with v4
- split off div6 extended clocks
- added cmt1 DT description
- added MSTP clock assignments
- reordered according to dependencies
- removed dummy frequencies in extal2, extcki
- removed enable_on_init on zb1 and flctlck
- added missing tpu4 in mstp3_clks
- use c->parent in cpg driver
- fix some style issues


Ulrich Hecht (6):
  clk: shmobile: sh73a0 common clock framework implementation
  ARM: shmobile: sh73a0: Add CPG register bits header
  ARM: shmobile: sh73a0: Common clock framework DT description
  ARM: shmobile: kzm9g-reference: Common clock framework DT description
  ARM: shmobile: sh73a0: add MSTP clock assignments to DT
  ARM: shmobile: sh73a0: disable legacy clock initialization

 .../bindings/clock/renesas,sh73a0-cpg-clocks.txt   |  35 ++
 arch/arm/boot/dts/sh73a0-kzm9g-reference.dts       |   4 +
 arch/arm/boot/dts/sh73a0.dtsi                      | 358 +++++++++++++++++++++
 arch/arm/mach-shmobile/setup-sh73a0.c              |   5 +-
 drivers/clk/shmobile/Makefile                      |   1 +
 drivers/clk/shmobile/clk-sh73a0.c                  | 218 +++++++++++++
 include/dt-bindings/clock/sh73a0-clock.h           |  79 +++++
 7 files changed, 699 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/clock/renesas,sh73a0-cpg-clocks.txt
 create mode 100644 drivers/clk/shmobile/clk-sh73a0.c
 create mode 100644 include/dt-bindings/clock/sh73a0-clock.h

-- 
1.8.4.5

Re: [PATCH v7 0/6] sh73a0 common clock framework implementation

[Magnus Damm]

Hi Ulrich, Simon, everyone,

This series looks like it has been receiving both plenty of review and
testing. What's your plan regarding merge?

Thanks,

/ magnus

On Wed, Dec 10, 2014 at 11:45 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> Hi!
>
> Here's the sh73a0 CCF driver with two fixes for issues in the frequency
> calculation for the z and dsi?phy clocks found by Geert and Laurent.
>
> CU
> Uli
>
>
> Changes since v6:
> - removed unused divider masks and flags
> - consider FRQCRB:ZSEL when calculating z clock
> - fixed dsi?phy PLL frequency calculation
> - added Acked-by
>
> Changes since v5:
> - use clock-indices instead of renesas,clock-indices
> - added Tested-by
>
> Changes since v4:
> - reordered MSTP clock assignments to directly follow interrupts property
>
> Changes since v3:
> - fixed bindings to match the implementation
> - handle extal division in CPG driver, dump extal?_div2_clk
> - added acks
> - dropped eth clock hack
>
> Changes since v2:
> - split CCF DT description
> - tabbed constants in CPG bits header file
> - reordered patches to avoid need for shmobile_clk_workaround()
> - removed said workaround
> - squashed unmerged remains of CMT1 DT description into MSTP clocks patch
> - renamed clock zb1 to zb
> - removed DIV6 stuff, will be a separate series
>
> Changes since v1:
> - div6 patch replaced with v4
> - split off div6 extended clocks
> - added cmt1 DT description
> - added MSTP clock assignments
> - reordered according to dependencies
> - removed dummy frequencies in extal2, extcki
> - removed enable_on_init on zb1 and flctlck
> - added missing tpu4 in mstp3_clks
> - use c->parent in cpg driver
> - fix some style issues
>
>
> Ulrich Hecht (6):
>   clk: shmobile: sh73a0 common clock framework implementation
>   ARM: shmobile: sh73a0: Add CPG register bits header
>   ARM: shmobile: sh73a0: Common clock framework DT description
>   ARM: shmobile: kzm9g-reference: Common clock framework DT description
>   ARM: shmobile: sh73a0: add MSTP clock assignments to DT
>   ARM: shmobile: sh73a0: disable legacy clock initialization
>
>  .../bindings/clock/renesas,sh73a0-cpg-clocks.txt   |  35 ++
>  arch/arm/boot/dts/sh73a0-kzm9g-reference.dts       |   4 +
>  arch/arm/boot/dts/sh73a0.dtsi                      | 358 +++++++++++++++++++++
>  arch/arm/mach-shmobile/setup-sh73a0.c              |   5 +-
>  drivers/clk/shmobile/Makefile                      |   1 +
>  drivers/clk/shmobile/clk-sh73a0.c                  | 218 +++++++++++++
>  include/dt-bindings/clock/sh73a0-clock.h           |  79 +++++
>  7 files changed, 699 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/devicetree/bindings/clock/renesas,sh73a0-cpg-clocks.txt
>  create mode 100644 drivers/clk/shmobile/clk-sh73a0.c
>  create mode 100644 include/dt-bindings/clock/sh73a0-clock.h
>
> --
> 1.8.4.5
>

Re: [PATCH v7 0/6] sh73a0 common clock framework implementation

[Geert Uytterhoeven]

Hi Magnus,

On Wed, Dec 17, 2014 at 8:54 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> This series looks like it has been receiving both plenty of review and
> testing. What's your plan regarding merge?

I plan to collect all clk-related patches in a branch, and ask Mike to pull it
(after New year).

Is that OK?

Note that there were still some comments on [PATCH 1/6].

And I have to repost a new version of the renesas,bsc series first, as we
need to for working Ethernet with CCF on kzm9g.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v7 0/6] sh73a0 common clock framework implementation

[Magnus Damm]

Hi Geert,

On Wed, Dec 17, 2014 at 5:01 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Hi Magnus,
>
> On Wed, Dec 17, 2014 at 8:54 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> This series looks like it has been receiving both plenty of review and
>> testing. What's your plan regarding merge?
>
> I plan to collect all clk-related patches in a branch, and ask Mike to pull it
> (after New year).
>
> Is that OK?

That's fine with me - I guess that includes the DIV6 bits too. I saw
some pull request related to clocks from you earlier, but that got
dropped I suppose?

How do we handle integration patches in the mean time? I saw that you
had hundreds of patches in your queue, but for me it is enough with
just a couple of series to stack up to go nuts when I'm attempting to
add sh73a0 multiplatform. =)

> Note that there were still some comments on [PATCH 1/6].

Sure, but perhaps those can be handled incrementally?

> And I have to repost a new version of the renesas,bsc series first, as we
> need to for working Ethernet with CCF on kzm9g.

That's a good idea.

Thanks,

/ magnus

Re: [PATCH v7 0/6] sh73a0 common clock framework implementation

[Geert Uytterhoeven]

Hi Magnus,

On Wed, Dec 17, 2014 at 9:40 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> On Wed, Dec 17, 2014 at 5:01 PM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> On Wed, Dec 17, 2014 at 8:54 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>>> This series looks like it has been receiving both plenty of review and
>>> testing. What's your plan regarding merge?
>>
>> I plan to collect all clk-related patches in a branch, and ask Mike to pull it
>> (after New year).
>>
>> Is that OK?
>
> That's fine with me - I guess that includes the DIV6 bits too. I saw
> some pull request related to clocks from you earlier, but that got
> dropped I suppose?

The DIV6 bits have been pulled by Mike, and are in clk/clk-next, but I have
the impression Mike hasn't sent a pull request for 3.19 to Linus yet?

New stuff will be in 3.20.

> How do we handle integration patches in the mean time? I saw that you
> had hundreds of patches in your queue, but for me it is enough with
> just a couple of series to stack up to go nuts when I'm attempting to
> add sh73a0 multiplatform. =)

I am going nuts with all those patches ;-)

Now, we cannot integrate multiplatform support for sh73a0/r8a73a4 without
a (stable) branch with CCF first.

>> Note that there were still some comments on [PATCH 1/6].
>
> Sure, but perhaps those can be handled incrementally?

OK.

>> And I have to repost a new version of the renesas,bsc series first, as we
>> need to for working Ethernet with CCF on kzm9g.
>
> That's a good idea.

And also on ape6evm, if I'm not mistaken.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v7 0/6] sh73a0 common clock framework implementation

[Laurent Pinchart]

Hi Geert,

On Wednesday 17 December 2014 09:01:10 Geert Uytterhoeven wrote:
> Hi Magnus,
> 
> On Wed, Dec 17, 2014 at 8:54 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> > This series looks like it has been receiving both plenty of review and
> > testing. What's your plan regarding merge?
> 
> I plan to collect all clk-related patches in a branch, and ask Mike to pull
> it (after New year).
> 
> Is that OK?
> 
> Note that there were still some comments on [PATCH 1/6].

I think they should be easy to address. Please let me know if you need my 
help.

> And I have to repost a new version of the renesas,bsc series first, as we
> need to for working Ethernet with CCF on kzm9g.

-- 
Regards,

Laurent Pinchart

Re: [PATCH v7 0/6] sh73a0 common clock framework implementation

[Simon Horman]

On Wed, Dec 17, 2014 at 01:39:09PM +0200, Laurent Pinchart wrote:
> Hi Geert,
> 
> On Wednesday 17 December 2014 09:01:10 Geert Uytterhoeven wrote:
> > Hi Magnus,
> > 
> > On Wed, Dec 17, 2014 at 8:54 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> > > This series looks like it has been receiving both plenty of review and
> > > testing. What's your plan regarding merge?
> > 
> > I plan to collect all clk-related patches in a branch, and ask Mike to pull
> > it (after New year).
> > 
> > Is that OK?

As Mike has acked the first patch I would like to take the entire series
through my tree.

> > Note that there were still some comments on [PATCH 1/6].
> 
> I think they should be easy to address. Please let me know if you need my 
> help.

That seems to have been resolved.

Re: [PATCH v7 0/6] sh73a0 common clock framework implementation

[Geert Uytterhoeven]

Hi Simon,

On Thu, Dec 18, 2014 at 4:01 AM, Simon Horman <horms@verge.net.au> wrote:
> On Wed, Dec 17, 2014 at 01:39:09PM +0200, Laurent Pinchart wrote:
>> On Wednesday 17 December 2014 09:01:10 Geert Uytterhoeven wrote:
>> > On Wed, Dec 17, 2014 at 8:54 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> > > This series looks like it has been receiving both plenty of review and
>> > > testing. What's your plan regarding merge?
>> >
>> > I plan to collect all clk-related patches in a branch, and ask Mike to pull
>> > it (after New year).
>> >
>> > Is that OK?
>
> As Mike has acked the first patch I would like to take the entire series
> through my tree.

OK... Less work for me ;-)

Will you also take the other clock related patches floating around?
E.g. "[PATCH v2] clk: shmobile: div6: Avoid changing divisor in .disable()",
and a few other adding support for more R-Car Gen2 SoCs?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v7 0/6] sh73a0 common clock framework implementation

[Geert Uytterhoeven]

On Wed, Dec 10, 2014 at 3:45 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> Here's the sh73a0 CCF driver with two fixes for issues in the frequency
> calculation for the z and dsi?phy clocks found by Geert and Laurent.

Thanks!

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v7 0/6] sh73a0 common clock framework implementation

[Simon Horman]

On Thu, Dec 18, 2014 at 09:09:59AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Thu, Dec 18, 2014 at 4:01 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Wed, Dec 17, 2014 at 01:39:09PM +0200, Laurent Pinchart wrote:
> >> On Wednesday 17 December 2014 09:01:10 Geert Uytterhoeven wrote:
> >> > On Wed, Dec 17, 2014 at 8:54 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> >> > > This series looks like it has been receiving both plenty of review and
> >> > > testing. What's your plan regarding merge?
> >> >
> >> > I plan to collect all clk-related patches in a branch, and ask Mike to pull
> >> > it (after New year).
> >> >
> >> > Is that OK?
> >
> > As Mike has acked the first patch I would like to take the entire series
> > through my tree.
> 
> OK... Less work for me ;-)

:)

> Will you also take the other clock related patches floating around?
> E.g. "[PATCH v2] clk: shmobile: div6: Avoid changing divisor in .disable()",
> and a few other adding support for more R-Car Gen2 SoCs?

As Mike has indicated he will take them I do not plan to.

I do notice that although he indicated that he would take them they
do not seem to be in Linus's tree or next. I'm not sure if Mike is
following this thread any more. But it would be good to get those changes
in, one way or another.

Re: [PATCH v7 0/6] sh73a0 common clock framework implementation

[Simon Horman]

On Thu, Dec 18, 2014 at 09:16:20AM +0100, Geert Uytterhoeven wrote:
> On Wed, Dec 10, 2014 at 3:45 PM, Ulrich Hecht
> <ulrich.hecht+renesas@gmail.com> wrote:
> > Here's the sh73a0 CCF driver with two fixes for issues in the frequency
> > calculation for the z and dsi?phy clocks found by Geert and Laurent.
> 
> Thanks!
> 
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, I have queued these up.

Re: [PATCH v7 0/6] sh73a0 common clock framework implementation

[Geert Uytterhoeven]

On Fri, Dec 19, 2014 at 12:48 AM, Simon Horman <horms@verge.net.au> wrote:
>> > As Mike has acked the first patch I would like to take the entire series
>> > through my tree.
>>
>> OK... Less work for me ;-)
>
> :)
>
>> Will you also take the other clock related patches floating around?
>> E.g. "[PATCH v2] clk: shmobile: div6: Avoid changing divisor in .disable()",
>> and a few other adding support for more R-Car Gen2 SoCs?
>
> As Mike has indicated he will take them I do not plan to.

The above mentioned div6 patch is not the div6 patch in clk/for-next.
This is a new one.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v7 0/6] sh73a0 common clock framework implementation

[Simon Horman]

On Fri, Dec 19, 2014 at 09:04:44AM +0100, Geert Uytterhoeven wrote:
> On Fri, Dec 19, 2014 at 12:48 AM, Simon Horman <horms@verge.net.au> wrote:
> >> > As Mike has acked the first patch I would like to take the entire series
> >> > through my tree.
> >>
> >> OK... Less work for me ;-)
> >
> > :)
> >
> >> Will you also take the other clock related patches floating around?
> >> E.g. "[PATCH v2] clk: shmobile: div6: Avoid changing divisor in .disable()",
> >> and a few other adding support for more R-Car Gen2 SoCs?
> >
> > As Mike has indicated he will take them I do not plan to.
> 
> The above mentioned div6 patch is not the div6 patch in clk/for-next.
> This is a new one.

Thanks, I see that now.

I'm happy to take this if it is a dependency for other mach-shmobile
patches for v3.20. But it would need Mike's Ack.

Re: [PATCH v7 0/6] sh73a0 common clock framework implementation

[Geert Uytterhoeven]

On Wed, Dec 17, 2014 at 9:54 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Wed, Dec 17, 2014 at 9:40 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> On Wed, Dec 17, 2014 at 5:01 PM, Geert Uytterhoeven
>> <geert@linux-m68k.org> wrote:
>>> On Wed, Dec 17, 2014 at 8:54 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>>>> This series looks like it has been receiving both plenty of review and
>>>> testing. What's your plan regarding merge?
>>>
>>> I plan to collect all clk-related patches in a branch, and ask Mike to pull it
>>> (after New year).
>>>
>>> Is that OK?
>>
>> That's fine with me - I guess that includes the DIV6 bits too. I saw
>> some pull request related to clocks from you earlier, but that got
>> dropped I suppose?
>
> The DIV6 bits have been pulled by Mike, and are in clk/clk-next, but I have
> the impression Mike hasn't sent a pull request for 3.19 to Linus yet?

JFYI, it's now in v3.19-rc1.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds