Re: ARM: shmobile: r8a73a4: Instantiate GIC from C board code in legacy builds

[Simon Horman <horms@verge.net.au>]

On Wed, Jan 21, 2015 at 08:50:38AM +0900, Simon Horman wrote:
> On Tue, Jan 20, 2015 at 08:38:00PM +0900, Magnus Damm wrote:
> > From: Magnus Damm <damm+renesas@opensource.se>
> > 
> > As of commit 9a1091ef0017c40a ("irqchip: gic: Support hierarchy irq
> > domain."), the APE6EVM legacy board support is know to be broken.
> > 
> > The IRQ numbers of the GIC are now virtual, and no longer match the
> > hardcoded hardware IRQ numbers in the platform board code.
> > 
> > To fix this, instantiate the GIC from platform board code when compiling
> > a legacy kernel, like is done for the sh73a0, r8a7740, r8a7778 and r8a7779
> > legacy code.
> > 
> > Follows same style as the r8a7740 legacy GIC fix by Geert Uytterhoeven,
> > thanks to him for the initial work.
> > 
> > Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> > ---
> > 
> >  Written on top of renesas-devel-20150119-v3.19-rc5
> > 
> >  Untested due to lack of working hardware, testing needed.
> 
> Hi Magnus,
> 
> thanks for your help with this. I have tested this and have
> both good and bad news.
> 
> The bad news is that it does not appear to work :(
> The good news is that this means my setup is at least working (or not)
> consistently as I had brewed up the same change myself a few weeks ago
> and that also did not work :^)
> 
> My naïve guess is that the GIC setup for the r8a73a4 is somehow
> more complex or than calling gic_init() and that this is reflected
> in its DT - which seems more complex than for the r8a77{40,98,99} which
> we have been fixed in a manner very close to the patch you propose here.
> 
> Please find attached two boot logs which may or may not be of any help.
> 
> * renesas-devel-20150119-v3.19-rc5.txt: This is a boot of
>   renesas-devel-20150119-v3.19-rc5 using the ape6evm_defconfig.
>   It features the problem your patch tries to solve.
> 
> * renesas-devel-20150119-v3.19-rc5+patched+earlyprintk: This is
>   a boot of renesas-devel-20150119-v3.19-rc5 with your patch applied,
>   and earlyprintk specified on the command line and
>   CONFIG_DEBUG_RCAR_GEN2_SCIF0 enabled in its config. Without the latter
>   two enhancements there is no console output at all.
> 
> I'm not sure what the best way is to move forwards on this but
> I am quite happy to offer any assistance you need.

BTW, as I have just queued up the r8a73a0 multiplatform series,
which removes the code that your patch tries to fix, perhaps we
should consider letting this one go?