Re: ARM: shmobile: r8a73a4: Instantiate GIC from C board code in legacy builds

[Simon Horman <horms@verge.net.au>]

On Wed, Jan 21, 2015 at 09:57:43AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Wed, Jan 21, 2015 at 12:50 AM, Simon Horman <horms@verge.net.au> wrote:
> > My naïve guess is that the GIC setup for the r8a73a4 is somehow
> > more complex or than calling gic_init() and that this is reflected
> > in its DT - which seems more complex than for the r8a77{40,98,99} which
> > we have been fixed in a manner very close to the patch you propose here.
> 
> According to the bindings, the extra 2 reg property ranges are for the
> virtualization extensions, which we don't use.

Thanks, now there is one less mystery in my life.

Perhaps we could tidy up the dts file to remove bits that are unused?
Or are they used when booting using DT?

> > * renesas-devel-20150119-v3.19-rc5+patched+earlyprintk: This is
> >   a boot of renesas-devel-20150119-v3.19-rc5 with your patch applied,
> 
> | Unable to handle kernel paging request at virtual address f1001004
> 
> So the GIC's registers are not mapped.
> 
> Ape6evm doesn't provide machine_desc.map_io(), so you have to map the
> GIC yourself. Does the below work?
> 
> -       void __iomem *gic_dist_base = IOMEM(0xf1001000);
> -       void __iomem *gic_cpu_base = IOMEM(0xf1002000);
> +       void __iomem *gic_dist_base = ioremap_nocache(0xf1001000, 0x1000);
> +       void __iomem *gic_cpu_base = ioremap_nocache(0xf1002000, 0x1000);

I also added:

        printk("%s gic_dist_base:%p gic_cpu_base:%p\n", __func__,
	               gic_dist_base, gic_cpu_base);

It does seem promising solve the problem that was manifesting with Magnus's
patch. But it seems the interrupt controller isn't being initialised as
expected.


Starting kernel ...

Booting Linux on physical CPU 0x0
Initializing cgroup subsys cpu
Linux version 3.19.0-rc5-00001-gd6e5919-dirty (horms@ayumi.isobedori.kobe.vergenet.net) (gcc version 4.6.3 (GCC) ) #705 SMP Wed Jan 21 18:11:46 JST 2015
CPU: ARMv7 Processor [412fc0f3] revision 3 (ARMv7), cr\x10c5307d
CPU: PIPT / VIPT nonaliasing data cache, PIPT instruction cache
Machine model: APE6EVM
Ignoring memory block 0x200000000 - 0x240000000
bootconsole [earlycon0] enabled
debug: ignoring loglevel setting.
Memory policy: Data cache writealloc
On node 0 totalpages: 262144
free_area_init_node: node 0, pgdat c05238c0, node_mem_map eeff8000
  Normal zone: 1520 pages used for memmap
  Normal zone: 0 pages reserved
  Normal zone: 194560 pages, LIFO batch:31
  HighMem zone: 67584 pages, LIFO batch:15
PERCPU: Embedded 8 pages/cpu @eefe3000 s11520 r0 d21248 u32768
pcpu-alloc: s11520 r0 d21248 u32768 alloc=8*4096
pcpu-alloc: [0] 0 
Built 1 zonelists in Zone order, mobility grouping on.  Total pages: 260624
Kernel command line: earlyprintk console=ttySC0,115200 ignore_loglevel root=/dev/nfs ip=dhcp rw
PID hash table entries: 4096 (order: 2, 16384 bytes)
Dentry cache hash table entries: 131072 (order: 7, 524288 bytes)
Inode-cache hash table entries: 65536 (order: 6, 262144 bytes)
Memory: 1034032K/1048576K available (3777K kernel code, 221K rwdata, 984K rodata, 256K init, 188K bss, 14544K reserved, 0K cma-reserved, 270336K highmem)
Virtual kernel memory layout:
    vector  : 0xffff0000 - 0xffff1000   (   4 kB)
    fixmap  : 0xffc00000 - 0xfff00000   (3072 kB)
    vmalloc : 0xf0000000 - 0xff000000   ( 240 MB)
    lowmem  : 0xc0000000 - 0xef800000   ( 760 MB)
    pkmap   : 0xbfe00000 - 0xc0000000   (   2 MB)
      .text : 0xc0008000 - 0xc04af634   (4766 kB)
      .init : 0xc04b0000 - 0xc04f0000   ( 256 kB)
      .data : 0xc04f0000 - 0xc0527418   ( 222 kB)
       .bss : 0xc0527418 - 0xc055663c   ( 189 kB)
Hierarchical RCU implementation.
        RCU restricting CPUs from NR_CPUS=8 to nr_cpu_ids=1.
RCU: Adjusting geometry for rcu_fanout_leaf\x16, nr_cpu_ids=1
NR_IRQS:16 nr_irqs:16 16
r8a73a4_init_irq gic_dist_base:f0000000 gic_cpu_base:f0002000
irq: no irq domain found for /interrupt-controller@f1001000 !
irq: no irq domain found for /interrupt-controller@f1001000 !
irq: no irq domain found for /interrupt-controller@f1001000 !
irq: no irq domain found for /interrupt-controller@f1001000 !
arch_timer: No interrupt available, giving up
sched_clock: 32 bits at 128 Hz, resolution 7812500ns, wraps every 16777216000000000ns
Console: colour dummy device 80x30
Calibrating delay loop...

> On sh73a0 this is mapped in sh73a0_map_io().
> On r8a7740, r8a7778, and r8a7779 the GIC is mapped manually, too.
> 
> >   and earlyprintk specified on the command line and
> >   CONFIG_DEBUG_RCAR_GEN2_SCIF0 enabled in its config. Without the latter
> >   two enhancements there is no console output at all.
> 
> DEBUG_RMOBILE_SCIFA0, I assume?

Yes. I accidently copied my notes for Koelsch rather than
the .config I used for the ape6evm.

> If not, arch/arm/Kconfig.debug must be fixed.
> But the ape6evm Mother Board Hardware Specification says SCIFA0
> is used for the console...
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>