Re: [PATCH] ARM: shmobile: lager: Fix adv7511 IRQ sensing

[Simon Horman <horms@verge.net.au>]

Hi,

On Mon, May 25, 2015 at 10:08:24AM +0900, Simon Horman wrote:
> Hi Ben, Hi Laurent,
> 
> On Wed, May 06, 2015 at 04:12:39PM +0300, Laurent Pinchart wrote:
> > Hi Ben,
> > 
> > On Wednesday 06 May 2015 12:34:34 Ben Hutchings wrote:
> > > On Wed, 2015-05-06 at 07:05 +0300, Laurent Pinchart wrote:
> > > > The adv7511 IRQ is low level triggered, not falling edge triggered. The
> > > > wrong sense configuration results in no interrupt being triggered at
> > > > all, breaking hotplug detection. Fix it.
> > > > 
> > > > Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
> > > > Signed-off-by: Laurent Pinchart
> > > > <laurent.pinchart+renesas@ideasonboard.com>
> > > > ---
> > > > 
> > > >  arch/arm/boot/dts/r8a7790-lager.dts | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > Ben, would you be able to test this ? I won't have access to my Lager
> > > > board before Sunday.
> > > 
> > > I only have remote access to a Lager at present, so I would need to pass
> > > this on to a colleague.
> > 
> > No worries. Worst case I'll try it when I get back home.
> 
> Did anyone manage to test this?

This seems to have fallen through the cracks.
Laurent, is there any chance you could test this?

> > > > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts
> > > > b/arch/arm/boot/dts/r8a7790-lager.dts index 46f4c56c287c..21782e6b37f7
> > > > 100644
> > > > --- a/arch/arm/boot/dts/r8a7790-lager.dts
> > > > +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> > > > @@ -548,7 +548,7 @@
> > > >  		compatible = "adi,adv7511w";
> > > >  		reg = <0x39>;
> > > >  		interrupt-parent = <&gpio1>;
> > > > -		interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
> > > > +		interrupts = <15 IRQ_TYPE_LEVEL_LOW>;
> > > > 
> > > >  		adi,input-depth = <8>;
> > > >  		adi,input-colorspace = "rgb";
> > 
> > -- 
> > Regards,
> > 
> > Laurent Pinchart
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>