SUPERH platform development
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: lager: Fix adv7511 IRQ sensing
Date: Fri, 17 Jul 2015 06:47:28 +0000	[thread overview]
Message-ID: <20150717064727.GC7986@verge.net.au> (raw)
In-Reply-To: <1430885131-6098-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>

On Fri, Jul 17, 2015 at 09:31:24AM +0300, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Friday 17 July 2015 09:03:11 Simon Horman wrote:
> > On Thu, Jul 16, 2015 at 02:29:04PM +0300, Laurent Pinchart wrote:
> > > On Tuesday 07 July 2015 09:48:09 Simon Horman wrote:
> > >> On Mon, May 25, 2015 at 10:08:24AM +0900, Simon Horman wrote:
> > >>> On Wed, May 06, 2015 at 04:12:39PM +0300, Laurent Pinchart wrote:
> > >>>> On Wednesday 06 May 2015 12:34:34 Ben Hutchings wrote:
> > >>>>> On Wed, 2015-05-06 at 07:05 +0300, Laurent Pinchart wrote:
> > >>>>>> The adv7511 IRQ is low level triggered, not falling edge triggered.
> > >>>>>> The wrong sense configuration results in no interrupt being
> > >>>>>> triggered at all, breaking hotplug detection. Fix it.
> > >>>>>> 
> > >>>>>> Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
> > >>>>>> Signed-off-by: Laurent Pinchart
> > >>>>>> <laurent.pinchart+renesas@ideasonboard.com>
> > >>>>>> ---
> > >>>>>> 
> > >>>>>>  arch/arm/boot/dts/r8a7790-lager.dts | 2 +-
> > >>>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
> > >>>>>> 
> > >>>>>> Ben, would you be able to test this ? I won't have access to my
> > >>>>>> Lager board before Sunday.
> > >>>>> 
> > >>>>> I only have remote access to a Lager at present, so I would need to
> > >>>> 
> > >>>> pass this on to a colleague.
> > >>>> 
> > >>>> No worries. Worst case I'll try it when I get back home.
> > >>> 
> > >>> Did anyone manage to test this?
> > >> 
> > >> This seems to have fallen through the cracks.
> > > 
> > > It did indeed. There seems to be many cracks these days, must be the
> > > season.
> > >
> > >> Laurent, is there any chance you could test this?
> > > 
> > > Tested-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > 
> > Thanks.
> > 
> > Shall I queue it up as a fix with the following tag?
> > 
> > Fixes: fd25cdd15b7f ("ARM: shmobile: lager: Add DU HDMI output support")
> 
> It's a related fix, but I don't think a fixes tag is appropriate given that 
> the above commit doesn't introduce a regression.

Ok, I'll just queue it up as a regular-non-fix patch.
Most likely early next week.

      parent reply	other threads:[~2015-07-17  6:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06  4:05 [PATCH] ARM: shmobile: lager: Fix adv7511 IRQ sensing Laurent Pinchart
2015-05-06 11:34 ` Ben Hutchings
2015-05-06 13:12 ` Laurent Pinchart
2015-05-25  1:08 ` Simon Horman
2015-07-07  0:48 ` Simon Horman
2015-07-16 11:29 ` Laurent Pinchart
2015-07-17  0:03 ` Simon Horman
2015-07-17  6:31 ` Laurent Pinchart
2015-07-17  6:47 ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150717064727.GC7986@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox