SUPERH platform development
 help / color / mirror / Atom feed
* [PATCH] ARM: shmobile: lager: Fix adv7511 IRQ sensing
@ 2015-05-06  4:05 Laurent Pinchart
  2015-05-06 11:34 ` Ben Hutchings
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: Laurent Pinchart @ 2015-05-06  4:05 UTC (permalink / raw)
  To: linux-sh

The adv7511 IRQ is low level triggered, not falling edge triggered. The
wrong sense configuration results in no interrupt being triggered at
all, breaking hotplug detection. Fix it.

Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 arch/arm/boot/dts/r8a7790-lager.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Ben, would you be able to test this ? I won't have access to my Lager board
before Sunday.

diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
index 46f4c56c287c..21782e6b37f7 100644
--- a/arch/arm/boot/dts/r8a7790-lager.dts
+++ b/arch/arm/boot/dts/r8a7790-lager.dts
@@ -548,7 +548,7 @@
 		compatible = "adi,adv7511w";
 		reg = <0x39>;
 		interrupt-parent = <&gpio1>;
-		interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
+		interrupts = <15 IRQ_TYPE_LEVEL_LOW>;
 
 		adi,input-depth = <8>;
 		adi,input-colorspace = "rgb";
-- 
Regards,

Laurent Pinchart


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2015-07-17  6:47 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-06  4:05 [PATCH] ARM: shmobile: lager: Fix adv7511 IRQ sensing Laurent Pinchart
2015-05-06 11:34 ` Ben Hutchings
2015-05-06 13:12 ` Laurent Pinchart
2015-05-25  1:08 ` Simon Horman
2015-07-07  0:48 ` Simon Horman
2015-07-16 11:29 ` Laurent Pinchart
2015-07-17  0:03 ` Simon Horman
2015-07-17  6:31 ` Laurent Pinchart
2015-07-17  6:47 ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox