[PATCH v3 00/04] ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3

SUPERH platform development
 help / color / mirror / Atom feed

* [PATCH v3 00/04] ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3
@ 2015-07-13  6:14 Magnus Damm
  2015-07-15  0:25 ` Simon Horman
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Magnus Damm @ 2015-07-13  6:14 UTC (permalink / raw)
  To: linux-sh

ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3

[PATCH v3 01/04] ARM: shmobile: r8a7779: Generic SMP ops
[PATCH v3 02/04] ARM: shmobile: marzen-reference: Remove C board code
[PATCH v3 03/04] ARM: shmobile: Remove Marzen from shmobile_defconfig
[PATCH v3 04/04] ARM: shmobile: r8a7779: Cleanup header file

This series is simply resending the remaining r8a7779 multiplatform
cleanup patches. The code has not changed since V2:

[PATCH v2 00/06] ARM: shmobile: r8a7779 IRQ update and Marzen cleanup V2

With these patches applied the r8a7779 SoC gets DT-only multiplatform
support and old C board code for multiplatform gets removed.

The legacy r8a7779 Marzen code is not touched by this series, but
with these patches applied basic r8a7779 multiplatform SoC support
is done and only a few I/O devices are legacy-only.

Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
---

 Built on top of renesas-devel-20150706-v4.2-rc1
 No special dependencies

 arch/arm/configs/shmobile_defconfig             |    1 
 arch/arm/mach-shmobile/Kconfig                  |    7 --
 arch/arm/mach-shmobile/Makefile                 |    4 -
 arch/arm/mach-shmobile/board-marzen-reference.c |   56 -----------------------
 arch/arm/mach-shmobile/clock-r8a7779.c          |    2 
 arch/arm/mach-shmobile/r8a7779.h                |    2 
 arch/arm/mach-shmobile/setup-r8a7779.c          |    3 -
 7 files changed, 4 insertions(+), 71 deletions(-)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 00/04] ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3
  2015-07-13  6:14 [PATCH v3 00/04] ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3 Magnus Damm
@ 2015-07-15  0:25 ` Simon Horman
  2015-07-15  1:16 ` Simon Horman
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2015-07-15  0:25 UTC (permalink / raw)
  To: linux-sh

Hi Magnus,

On Mon, Jul 13, 2015 at 03:14:50PM +0900, Magnus Damm wrote:
> ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3
> 
> [PATCH v3 01/04] ARM: shmobile: r8a7779: Generic SMP ops
> [PATCH v3 02/04] ARM: shmobile: marzen-reference: Remove C board code
> [PATCH v3 03/04] ARM: shmobile: Remove Marzen from shmobile_defconfig
> [PATCH v3 04/04] ARM: shmobile: r8a7779: Cleanup header file
> 
> This series is simply resending the remaining r8a7779 multiplatform
> cleanup patches. The code has not changed since V2:
> 
> [PATCH v2 00/06] ARM: shmobile: r8a7779 IRQ update and Marzen cleanup V2
> 
> With these patches applied the r8a7779 SoC gets DT-only multiplatform
> support and old C board code for multiplatform gets removed.
> 
> The legacy r8a7779 Marzen code is not touched by this series, but
> with these patches applied basic r8a7779 multiplatform SoC support
> is done and only a few I/O devices are legacy-only.

Thanks, I have queued these up.

Please send a follow-up patch to address Geert's observation that
CONFIG_MACH_MARZEN should be removed from multi_v7_defconfig.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 00/04] ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3
  2015-07-13  6:14 [PATCH v3 00/04] ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3 Magnus Damm
  2015-07-15  0:25 ` Simon Horman
@ 2015-07-15  1:16 ` Simon Horman
  2015-07-15  5:56 ` Magnus Damm
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2015-07-15  1:16 UTC (permalink / raw)
  To: linux-sh

Hi Magnus,

On Wed, Jul 15, 2015 at 09:25:01AM +0900, Simon Horman wrote:
> Hi Magnus,
> 
> On Mon, Jul 13, 2015 at 03:14:50PM +0900, Magnus Damm wrote:
> > ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3
> > 
> > [PATCH v3 01/04] ARM: shmobile: r8a7779: Generic SMP ops
> > [PATCH v3 02/04] ARM: shmobile: marzen-reference: Remove C board code
> > [PATCH v3 03/04] ARM: shmobile: Remove Marzen from shmobile_defconfig
> > [PATCH v3 04/04] ARM: shmobile: r8a7779: Cleanup header file
> > 
> > This series is simply resending the remaining r8a7779 multiplatform
> > cleanup patches. The code has not changed since V2:
> > 
> > [PATCH v2 00/06] ARM: shmobile: r8a7779 IRQ update and Marzen cleanup V2
> > 
> > With these patches applied the r8a7779 SoC gets DT-only multiplatform
> > support and old C board code for multiplatform gets removed.
> > 
> > The legacy r8a7779 Marzen code is not touched by this series, but
> > with these patches applied basic r8a7779 multiplatform SoC support
> > is done and only a few I/O devices are legacy-only.
> 
> Thanks, I have queued these up.
> 
> Please send a follow-up patch to address Geert's observation that
> CONFIG_MACH_MARZEN should be removed from multi_v7_defconfig.

Unfortunately I have noticed a problem with patch 02/04,
and in particular the following portion of it:

--- a/arch/arm/mach-shmobile/Kconfig
+++ b/arch/arm/mach-shmobile/Kconfig
@@ -89,13 +89,6 @@ config ARCH_SH73A0
        select ARCH_RMOBILE
        select RENESAS_INTC_IRQPIN
 
-comment "Renesas ARM SoCs Board Type"
-
-config MACH_MARZEN
-       bool "MARZEN board"
-       depends on ARCH_R8A7779
-       select REGULATOR_FIXED_VOLTAGE if REGULATOR
-

It appears that with the above applied REGULATOR_FIXED_VOLTAGE is
no longer set after make shmobile_defconfig which causes all sorts of
trouble as the fixed regulator is used by many devices on many boards.

I wonder if the best way forwards would be to simply enable
REGULATOR_FIXED_VOLTAGE in shmobile_defconfig (and probably
multi_v7_defconfig too).

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 00/04] ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3
  2015-07-13  6:14 [PATCH v3 00/04] ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3 Magnus Damm
  2015-07-15  0:25 ` Simon Horman
  2015-07-15  1:16 ` Simon Horman
@ 2015-07-15  5:56 ` Magnus Damm
  2015-07-15  6:43 ` Simon Horman
  2015-07-15  7:41 ` Geert Uytterhoeven
  4 siblings, 0 replies; 6+ messages in thread
From: Magnus Damm @ 2015-07-15  5:56 UTC (permalink / raw)
  To: linux-sh

Hi Simon,

On Wed, Jul 15, 2015 at 10:16 AM, Simon Horman <horms@verge.net.au> wrote:
> Hi Magnus,
>
> On Wed, Jul 15, 2015 at 09:25:01AM +0900, Simon Horman wrote:
>> Hi Magnus,
>>
>> On Mon, Jul 13, 2015 at 03:14:50PM +0900, Magnus Damm wrote:
>> > ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3
>> >
>> > [PATCH v3 01/04] ARM: shmobile: r8a7779: Generic SMP ops
>> > [PATCH v3 02/04] ARM: shmobile: marzen-reference: Remove C board code
>> > [PATCH v3 03/04] ARM: shmobile: Remove Marzen from shmobile_defconfig
>> > [PATCH v3 04/04] ARM: shmobile: r8a7779: Cleanup header file
>> >
>> > This series is simply resending the remaining r8a7779 multiplatform
>> > cleanup patches. The code has not changed since V2:
>> >
>> > [PATCH v2 00/06] ARM: shmobile: r8a7779 IRQ update and Marzen cleanup V2
>> >
>> > With these patches applied the r8a7779 SoC gets DT-only multiplatform
>> > support and old C board code for multiplatform gets removed.
>> >
>> > The legacy r8a7779 Marzen code is not touched by this series, but
>> > with these patches applied basic r8a7779 multiplatform SoC support
>> > is done and only a few I/O devices are legacy-only.
>>
>> Thanks, I have queued these up.
>>
>> Please send a follow-up patch to address Geert's observation that
>> CONFIG_MACH_MARZEN should be removed from multi_v7_defconfig.
>
> Unfortunately I have noticed a problem with patch 02/04,
> and in particular the following portion of it:
>
> --- a/arch/arm/mach-shmobile/Kconfig
> +++ b/arch/arm/mach-shmobile/Kconfig
> @@ -89,13 +89,6 @@ config ARCH_SH73A0
>         select ARCH_RMOBILE
>         select RENESAS_INTC_IRQPIN
>
> -comment "Renesas ARM SoCs Board Type"
> -
> -config MACH_MARZEN
> -       bool "MARZEN board"
> -       depends on ARCH_R8A7779
> -       select REGULATOR_FIXED_VOLTAGE if REGULATOR
> -
>
> It appears that with the above applied REGULATOR_FIXED_VOLTAGE is
> no longer set after make shmobile_defconfig which causes all sorts of
> trouble as the fixed regulator is used by many devices on many boards.

Right, the regulator portion is indeed troublesome. And like you say,
it is needed for many boards including Gen2.

> I wonder if the best way forwards would be to simply enable
> REGULATOR_FIXED_VOLTAGE in shmobile_defconfig (and probably
> multi_v7_defconfig too).

Yeah, I think so.

Thanks,

/ magnus

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 00/04] ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3
  2015-07-13  6:14 [PATCH v3 00/04] ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3 Magnus Damm
                   ` (2 preceding siblings ...)
  2015-07-15  5:56 ` Magnus Damm
@ 2015-07-15  6:43 ` Simon Horman
  2015-07-15  7:41 ` Geert Uytterhoeven
  4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2015-07-15  6:43 UTC (permalink / raw)
  To: linux-sh

On Wed, Jul 15, 2015 at 02:56:33PM +0900, Magnus Damm wrote:
> Hi Simon,
> 
> On Wed, Jul 15, 2015 at 10:16 AM, Simon Horman <horms@verge.net.au> wrote:
> > Hi Magnus,
> >
> > On Wed, Jul 15, 2015 at 09:25:01AM +0900, Simon Horman wrote:
> >> Hi Magnus,
> >>
> >> On Mon, Jul 13, 2015 at 03:14:50PM +0900, Magnus Damm wrote:
> >> > ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3
> >> >
> >> > [PATCH v3 01/04] ARM: shmobile: r8a7779: Generic SMP ops
> >> > [PATCH v3 02/04] ARM: shmobile: marzen-reference: Remove C board code
> >> > [PATCH v3 03/04] ARM: shmobile: Remove Marzen from shmobile_defconfig
> >> > [PATCH v3 04/04] ARM: shmobile: r8a7779: Cleanup header file
> >> >
> >> > This series is simply resending the remaining r8a7779 multiplatform
> >> > cleanup patches. The code has not changed since V2:
> >> >
> >> > [PATCH v2 00/06] ARM: shmobile: r8a7779 IRQ update and Marzen cleanup V2
> >> >
> >> > With these patches applied the r8a7779 SoC gets DT-only multiplatform
> >> > support and old C board code for multiplatform gets removed.
> >> >
> >> > The legacy r8a7779 Marzen code is not touched by this series, but
> >> > with these patches applied basic r8a7779 multiplatform SoC support
> >> > is done and only a few I/O devices are legacy-only.
> >>
> >> Thanks, I have queued these up.
> >>
> >> Please send a follow-up patch to address Geert's observation that
> >> CONFIG_MACH_MARZEN should be removed from multi_v7_defconfig.
> >
> > Unfortunately I have noticed a problem with patch 02/04,
> > and in particular the following portion of it:
> >
> > --- a/arch/arm/mach-shmobile/Kconfig
> > +++ b/arch/arm/mach-shmobile/Kconfig
> > @@ -89,13 +89,6 @@ config ARCH_SH73A0
> >         select ARCH_RMOBILE
> >         select RENESAS_INTC_IRQPIN
> >
> > -comment "Renesas ARM SoCs Board Type"
> > -
> > -config MACH_MARZEN
> > -       bool "MARZEN board"
> > -       depends on ARCH_R8A7779
> > -       select REGULATOR_FIXED_VOLTAGE if REGULATOR
> > -
> >
> > It appears that with the above applied REGULATOR_FIXED_VOLTAGE is
> > no longer set after make shmobile_defconfig which causes all sorts of
> > trouble as the fixed regulator is used by many devices on many boards.
> 
> Right, the regulator portion is indeed troublesome. And like you say,
> it is needed for many boards including Gen2.
> 
> > I wonder if the best way forwards would be to simply enable
> > REGULATOR_FIXED_VOLTAGE in shmobile_defconfig (and probably
> > multi_v7_defconfig too).
> 
> Yeah, I think so.

Thanks, I have sent a patch.
Review would be much appreciated.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 00/04] ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3
  2015-07-13  6:14 [PATCH v3 00/04] ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3 Magnus Damm
                   ` (3 preceding siblings ...)
  2015-07-15  6:43 ` Simon Horman
@ 2015-07-15  7:41 ` Geert Uytterhoeven
  4 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2015-07-15  7:41 UTC (permalink / raw)
  To: linux-sh

Hi Simon,

On Wed, Jul 15, 2015 at 3:16 AM, Simon Horman <horms@verge.net.au> wrote:
> On Wed, Jul 15, 2015 at 09:25:01AM +0900, Simon Horman wrote:
>> On Mon, Jul 13, 2015 at 03:14:50PM +0900, Magnus Damm wrote:
>> > ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3
>> >
>> > [PATCH v3 01/04] ARM: shmobile: r8a7779: Generic SMP ops
>> > [PATCH v3 02/04] ARM: shmobile: marzen-reference: Remove C board code
>> > [PATCH v3 03/04] ARM: shmobile: Remove Marzen from shmobile_defconfig
>> > [PATCH v3 04/04] ARM: shmobile: r8a7779: Cleanup header file
>> >
>> > This series is simply resending the remaining r8a7779 multiplatform
>> > cleanup patches. The code has not changed since V2:
>> >
>> > [PATCH v2 00/06] ARM: shmobile: r8a7779 IRQ update and Marzen cleanup V2
>> >
>> > With these patches applied the r8a7779 SoC gets DT-only multiplatform
>> > support and old C board code for multiplatform gets removed.
>> >
>> > The legacy r8a7779 Marzen code is not touched by this series, but
>> > with these patches applied basic r8a7779 multiplatform SoC support
>> > is done and only a few I/O devices are legacy-only.
>>
>> Thanks, I have queued these up.
>>
>> Please send a follow-up patch to address Geert's observation that
>> CONFIG_MACH_MARZEN should be removed from multi_v7_defconfig.
>
> Unfortunately I have noticed a problem with patch 02/04,
> and in particular the following portion of it:
>
> --- a/arch/arm/mach-shmobile/Kconfig
> +++ b/arch/arm/mach-shmobile/Kconfig
> @@ -89,13 +89,6 @@ config ARCH_SH73A0
>         select ARCH_RMOBILE
>         select RENESAS_INTC_IRQPIN
>
> -comment "Renesas ARM SoCs Board Type"
> -
> -config MACH_MARZEN
> -       bool "MARZEN board"
> -       depends on ARCH_R8A7779
> -       select REGULATOR_FIXED_VOLTAGE if REGULATOR
> -
>
> It appears that with the above applied REGULATOR_FIXED_VOLTAGE is
> no longer set after make shmobile_defconfig which causes all sorts of
> trouble as the fixed regulator is used by many devices on many boards.

Indeed,

"linux-config-from-dt arch/arm/boot/dts/r8a7779-marzen.dtb" says:

    ...
    regulator-fixed is provided by:
            drivers/regulator/fixed.c
                    needs CONFIG_REGULATOR_FIXED_VOLTAGE
    ...

> I wonder if the best way forwards would be to simply enable
> REGULATOR_FIXED_VOLTAGE in shmobile_defconfig (and probably
> multi_v7_defconfig too).

Yes please.

Rule of thumb: check if the .configs generated from defconfigs have
changed after dropping a select.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-07-15  7:41 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-13  6:14 [PATCH v3 00/04] ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3 Magnus Damm
2015-07-15  0:25 ` Simon Horman
2015-07-15  1:16 ` Simon Horman
2015-07-15  5:56 ` Magnus Damm
2015-07-15  6:43 ` Simon Horman
2015-07-15  7:41 ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox