[PATCH][RFC] arm64: renesas: Add EXTAL configuration to Salvator-X

[PATCH][RFC] arm64: renesas: Add EXTAL configuration to Salvator-X

[Magnus Damm]

From: Magnus Damm <damm+renesas@opensource.se>

Configure EXTAL to 16.666 MHz on Salvator-X.

Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
---

 This sets the EXTAL frequency for the V9 integration series:
 [PATCH v9 00/07][RFC] Renesas R-Car H3 (r8a7795) integration patches V9

 To be used with the V7 CPG:
 [PATCH v7 00/05] Renesas R-Car Gen3 CPG support V7

 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts |    4 ++++
 1 file changed, 4 insertions(+)

--- 0007/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
+++ work/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts	2015-09-08 13:44:53.682366518 +0900
@@ -32,6 +32,10 @@
 	};
 };
 
+&extal_clk {
+	clock-frequency = <16666666>;
+};
+
 &pfc {
 	scif1_pins: scif1 {
 		renesas,groups = "scif1_data_a", "scif1_ctrl";

Re: [PATCH][RFC] arm64: renesas: Add EXTAL configuration to Salvator-X

[Geert Uytterhoeven]

On Tue, Sep 8, 2015 at 6:49 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
>
> Configure EXTAL to 16.666 MHz on Salvator-X.
>
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Cfr. "[PATCH 3/3] arm64: renesas: salvator-x: Add missing extal clock override"
http://www.spinics.net/lists/linux-sh/msg44416.html

-- 
Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH][RFC] arm64: renesas: Add EXTAL configuration to Salvator-X

[Laurent Pinchart]

Hi Magnus,

Thank you for the patch.

On Tuesday 08 September 2015 13:49:57 Magnus Damm wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
> 
> Configure EXTAL to 16.666 MHz on Salvator-X.
> 
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>

This looks quite straightforward and good to me. I don't think it requires the 
RFC status.

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> 
>  This sets the EXTAL frequency for the V9 integration series:
>  [PATCH v9 00/07][RFC] Renesas R-Car H3 (r8a7795) integration patches V9
> 
>  To be used with the V7 CPG:
>  [PATCH v7 00/05] Renesas R-Car Gen3 CPG support V7
> 
>  arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> --- 0007/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> +++ work/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts	2015-09-08
> 13:44:53.682366518 +0900 @@ -32,6 +32,10 @@
>  	};
>  };
> 
> +&extal_clk {
> +	clock-frequency = <16666666>;
> +};
> +
>  &pfc {
>  	scif1_pins: scif1 {
>  		renesas,groups = "scif1_data_a", "scif1_ctrl";

-- 
Regards,

Laurent Pinchart

Re: [PATCH][RFC] arm64: renesas: Add EXTAL configuration to Salvator-X

[Magnus Damm]

Hi Geert,

On Tue, Sep 8, 2015 at 3:58 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Tue, Sep 8, 2015 at 6:49 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> From: Magnus Damm <damm+renesas@opensource.se>
>>
>> Configure EXTAL to 16.666 MHz on Salvator-X.
>>
>> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
>
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Cfr. "[PATCH 3/3] arm64: renesas: salvator-x: Add missing extal clock override"
> http://www.spinics.net/lists/linux-sh/msg44416.html

Thanks, yeah I suspected this was done already. =)

To make things slightly more complicated it seems that some boards use
16.6666 MHz and others 16.0 Mhz...

Cheers,

/ magnus

Re: [PATCH][RFC] arm64: renesas: Add EXTAL configuration to Salvator-X

[Khiem Nguyen]

Hi Magnus,

> To make things slightly more complicated it seems that some boards use
> 16.6666 MHz and others 16.0 Mhz...
AFAIK, the 16.0 Mhz is only available in some initial Salvator-X boards.
So, 16.6666 MHz should be standard value, I guess.

Re: [PATCH][RFC] arm64: renesas: Add EXTAL configuration to Salvator-X

[Simon Horman]

On Tue, Sep 08, 2015 at 01:49:57PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
> 
> Configure EXTAL to 16.666 MHz on Salvator-X.
> 
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> ---
> 
>  This sets the EXTAL frequency for the V9 integration series:
>  [PATCH v9 00/07][RFC] Renesas R-Car H3 (r8a7795) integration patches V9
> 
>  To be used with the V7 CPG:
>  [PATCH v7 00/05] Renesas R-Car Gen3 CPG support V7

Thanks,

I have pushed this patch to the renesas tree in a new topic branch, 
topic/arm64-rcar-gen3-v9.plus, which is based on topic/arm64-rcar-gen3-v9.

I am assuming you will include this in/squash this into the next posting of
"Renesas R-Car H3 (r8a7795) integration patches".


Disclaimer: To be quite clear none of these patches are queued up for
mainline yet and as such they are not included in the next or devel
branches of the renesas tree.