Salvator-X I2C is working on HI speed on renesas-drivers-2015-10-27-v4.3-rc7

Salvator-X I2C is working on HI speed on renesas-drivers-2015-10-27-v4.3-rc7

[Kuninori Morimoto]

Hi Geert, Wolfram

I'm debugging renesas-drivers-2015-10-27-v4.3-rc7 yesterday/today
and I noticed that I2C doesn't work on Salvator-X

Sound needs Codec/CS2000, these both needs I2C access.
But, it gets -ENXIO from bus.
At least it works on renesas-drivers-2015-09-29-v4.3-rc3.

In my debug, it seems I2C SCL/SDA speed on 10-27 is very HI.
(I checked this via CN27 73/74pin)
But, i2c clock on /sys/kernel/debug/clk/clk_summary in 09-29 <-> 10-27
seems same value.

Where should I check ?

Best regards
---
Kuninori Morimoto

Re: Salvator-X I2C is working on HI speed on renesas-drivers-2015-10-27-v4.3-rc7

[Geert Uytterhoeven]

Hi Morimoto-san,

On Thu, Oct 29, 2015 at 7:31 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> I'm debugging renesas-drivers-2015-10-27-v4.3-rc7 yesterday/today
> and I noticed that I2C doesn't work on Salvator-X
>
> Sound needs Codec/CS2000, these both needs I2C access.
> But, it gets -ENXIO from bus.
> At least it works on renesas-drivers-2015-09-29-v4.3-rc3.
>
> In my debug, it seems I2C SCL/SDA speed on 10-27 is very HI.
> (I checked this via CN27 73/74pin)
> But, i2c clock on /sys/kernel/debug/clk/clk_summary in 09-29 <-> 10-27
> seems same value.
>
> Where should I check ?

Does it work if you revert commit 2bc3c5a8631db6d8 ("i2c: rcar: init new
messages in irq")?
That commit was reported by Laurent to break HDMI on Koelsch, cfr.
http://www.spinics.net/lists/linux-sh/msg46160.html.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: Salvator-X I2C is working on HI speed on renesas-drivers-2015-10-27-v4.3-rc7

[Kuninori Morimoto]

Hi Geert

> Does it work if you revert commit 2bc3c5a8631db6d8 ("i2c: rcar: init new
> messages in irq")?
> That commit was reported by Laurent to break HDMI on Koelsch, cfr.
> http://www.spinics.net/lists/linux-sh/msg46160.html.

Thank you for your feedback.
I reverted it, but it was same result.

# 09-29 version works with 100kHz,
# but, 10-27 version works with 1MHz over in my quick check

Re: Salvator-X I2C is working on HI speed on renesas-drivers-2015-10-27-v4.3-rc7

[Geert Uytterhoeven]

Hi Morimoto-san,

On Thu, Oct 29, 2015 at 8:40 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>> Does it work if you revert commit 2bc3c5a8631db6d8 ("i2c: rcar: init new
>> messages in irq")?
>> That commit was reported by Laurent to break HDMI on Koelsch, cfr.
>> http://www.spinics.net/lists/linux-sh/msg46160.html.
>
> Thank you for your feedback.
> I reverted it, but it was same result.
>
> # 09-29 version works with 100kHz,
> # but, 10-27 version works with 1MHz over in my quick check

If /sys/kernel/debug/clk/clk_summary doesn't show differences (it
shouldn't ;-), please try reverting more i2c commits.

git log --oneline
renesas-drivers-2015-09-29-v4.3-rc3..renesas-drivers-2015-10-27-v4.3-rc7
-- drivers/i2c/busses/i2c-rcar.c | tac
93c659d820ef291f i2c: rcar: rework hw init
59daef909d9ac2ca i2c: rcar: remove unused IOERROR state
738206dec9354817 i2c: rcar: remove spinlock
344beeb23bfc1150 i2c: rcar: refactor setup of a msg
2bc3c5a8631db6d8 i2c: rcar: init new messages in irq
315a1736a2f2d9ad i2c: rcar: don't issue stop when HW does it automatically
2151ba7584b73255 i2c: rcar: check master irqs before slave irqs
e5a7effa09e25743 i2c: rcar: revoke START request early
708ca40841266927 i2c: rcar: clean up after refactoring
4f7effddf4549d57 i2c: rcar: enable RuntimePM before registering to the core
ecc749660556e02a Merge branch 'i2c/for-current' into i2c/for-next
e7db0d34b38d56bb i2c: rcar: add support for r8a7795 (R-Car H3)
c6f1891323e6a259 i2c: rcar: Remove obsolete platform data support
6e82f74d11c8c33d Merge branch 'i2c/for-4.4' into i2c/for-next

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: Salvator-X I2C is working on HI speed on renesas-drivers-2015-10-27-v4.3-rc7

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

Hi Morimoto-san,

please CC me on such mails, then I'll see them faster.

> In my debug, it seems I2C SCL/SDA speed on 10-27 is very HI.
> (I checked this via CN27 73/74pin)
> But, i2c clock on /sys/kernel/debug/clk/clk_summary in 09-29 <-> 10-27
> seems same value.
> 
> Where should I check ?

Any changes in the pinctrl tables? Maybe some pin misconfiguration?

I'd like to check as well, but seem to have problems booting my Gen3 :/


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Salvator-X I2C is working on HI speed on renesas-drivers-2015-10-27-v4.3-rc7

[Kuninori Morimoto]

Hi Geert

> If /sys/kernel/debug/clk/clk_summary doesn't show differences (it
> shouldn't ;-), please try reverting more i2c commits.
> 
> git log --oneline
> renesas-drivers-2015-09-29-v4.3-rc3..renesas-drivers-2015-10-27-v4.3-rc7
> -- drivers/i2c/busses/i2c-rcar.c | tac
> 93c659d820ef291f i2c: rcar: rework hw init
> 59daef909d9ac2ca i2c: rcar: remove unused IOERROR state
> 738206dec9354817 i2c: rcar: remove spinlock
> 344beeb23bfc1150 i2c: rcar: refactor setup of a msg
> 2bc3c5a8631db6d8 i2c: rcar: init new messages in irq
> 315a1736a2f2d9ad i2c: rcar: don't issue stop when HW does it automatically
> 2151ba7584b73255 i2c: rcar: check master irqs before slave irqs
> e5a7effa09e25743 i2c: rcar: revoke START request early
> 708ca40841266927 i2c: rcar: clean up after refactoring
> 4f7effddf4549d57 i2c: rcar: enable RuntimePM before registering to the core
> ecc749660556e02a Merge branch 'i2c/for-current' into i2c/for-next
> e7db0d34b38d56bb i2c: rcar: add support for r8a7795 (R-Car H3)
> c6f1891323e6a259 i2c: rcar: Remove obsolete platform data support
> 6e82f74d11c8c33d Merge branch 'i2c/for-4.4' into i2c/for-next

Oops, I thought that there is no difference between 09-29 <-> 10-27.
OK, I will try

Re: Salvator-X I2C is working on HI speed on renesas-drivers-2015-10-27-v4.3-rc7

[Kuninori Morimoto]

Hi Geert, Wolfram

> > If /sys/kernel/debug/clk/clk_summary doesn't show differences (it
> > shouldn't ;-), please try reverting more i2c commits.
> > 
> > git log --oneline
> > renesas-drivers-2015-09-29-v4.3-rc3..renesas-drivers-2015-10-27-v4.3-rc7
> > -- drivers/i2c/busses/i2c-rcar.c | tac
> > 93c659d820ef291f i2c: rcar: rework hw init
> > 59daef909d9ac2ca i2c: rcar: remove unused IOERROR state
> > 738206dec9354817 i2c: rcar: remove spinlock
> > 344beeb23bfc1150 i2c: rcar: refactor setup of a msg
> > 2bc3c5a8631db6d8 i2c: rcar: init new messages in irq
> > 315a1736a2f2d9ad i2c: rcar: don't issue stop when HW does it automatically
> > 2151ba7584b73255 i2c: rcar: check master irqs before slave irqs
> > e5a7effa09e25743 i2c: rcar: revoke START request early
> > 708ca40841266927 i2c: rcar: clean up after refactoring
> > 4f7effddf4549d57 i2c: rcar: enable RuntimePM before registering to the core
> > ecc749660556e02a Merge branch 'i2c/for-current' into i2c/for-next
> > e7db0d34b38d56bb i2c: rcar: add support for r8a7795 (R-Car H3)
> > c6f1891323e6a259 i2c: rcar: Remove obsolete platform data support
> > 6e82f74d11c8c33d Merge branch 'i2c/for-4.4' into i2c/for-next
> 
> Oops, I thought that there is no difference between 09-29 <-> 10-27.
> OK, I will try

Thanks!!

I2C clock can be sane if I reverted this commit (= oops, 1st patch).
Correct speed is 100kHz, broken speed was 1.5MHz

commit 93c659d820ef291f6ca5e628f44b26cfb2226aba
Author: Wolfram Sang <wsa+renesas@sang-engineering.com>
Date:   Thu Sep 3 22:20:05 2015 +0200

    i2c: rcar: rework hw init
    
    We don't need to init HW before every transfer since we know the HW
    state then. HW init at probe time is enough. While here, add setting the
    clock register which belongs to init HW. Also, set MDBS bit since not
    setting it is prohibited according to the manual.
    
    Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
    Signed-off-by: Wolfram Sang <wsa@the-dreams.de>