Re: [LTSI-dev] THERMAL:Incorrect measured temperature value after unbind/bind

Re: [LTSI-dev] THERMAL:Incorrect measured temperature value after unbind/bind

[Greg KH]

On Wed, Feb 03, 2016 at 09:55:09AM +0900, Nguyen Viet Dung wrote:
> Hi,
> 
> when testting LTSI-v4.1.13-rc1 on the SOC of RENESAS(Lager board, Koelsch
> board),
> we have found the following the failure about the rcar_thermal driver.
> Detail of this failure is:
> [After unbind/rebind rcar_thermal measured temperature is not
> correct(-65.0°C)]
> error log:
>  Koelsch_Thermal_unbind_rebind_error_log.txt
>  Lager_Thermal_unbind_rebind_error_log.txt
> 
> We have checked that this failure had fixed by one Patch of Linux-Next
> branch.
> (5de85b9d57aba3ed2e04759e6db3b9e826dd0b06
> "PM / runtime: Re-init runtime PM states at probe error and driver unbind")
> 
> Please consider this patch to fix error for next LTSI release

I'm a bit worried that something like this isn't in the stable
kernel releases, shouldn't it also go there as well?

thanks,

greg k-h

RE: [LTSI-dev] THERMAL:Incorrect measured temperature value after unbind/bind

[Hisao Munakata]

R3JlZw0KDQpJZiBJIGFtIG5vdCB3cm9uZywgTFRTSSBjYW4gbWVyZ2UgbGludXgtbmV4dCAobm90
IHlldCBtZXJnZWQpDQpmaXggdW5saWtlIHJlZ3VsYXIgTFRTIHJlbGVhc2UsIGlmIGl0IGlzIGRl
bWFuZGVkIGJ5IHRoZSBpbmR1c3RyeS4NCg0KSW4gdGhpcyBwYXJ0aWN1bGFyIGNhc2UsIEkgdGhp
bmsgaXQgaXMgdG9vIGxhdGUgYXMgTFRTSS00LjEgaXMgYWxyZWFkeSByZWxlYXNlZC4NCkJ1dCBJ
IHdhbnRlZCB0byByZWNvbmZpcm0gZ3VpZGVsaW5lIG9mIExUU0kgcGF0Y2ggYWRvcHRpb24uDQpG
b3IgbWUgbGludXgtbmV4dCBjb2RlIGlzIGFscmVhZHkgdmVyaWZpZWQgaW4gdGhlIGNvbW11bml0
eSBhbmQNCml0IGlzIHJlbGF0aXZlbHkgY2xlYW4gYW5kIHNhZmUgZml4IGNvbXBhcmVkIHRvIGlu
LWhvdXNlIHBhdGNoLg0KDQpIb3cgZG8geW91IHRoaW5rPw0KDQpNdW5ha2F0YQ0KDQotLS0tLU9y
aWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJvbTogR3JlZyBLSCBbbWFpbHRvOmdyZWdraEBsaW51eGZv
dW5kYXRpb24ub3JnXSANClNlbnQ6IFdlZG5lc2RheSwgRmVicnVhcnkgMDMsIDIwMTYgMToxMCBQ
TQ0KVG86IE5ndXllbiBWaWV0IER1bmcgPG52LWR1bmdAamluc28uY28uanA+DQpDYzogbHRzaS1k
ZXZAbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZzsgbGludXgtc2hAdmdlci5rZXJuZWwub3JnOyBZ
b3NoaWhpcm8gU2hpbW9kYSA8eW9zaGloaXJvLnNoaW1vZGEudWhAcmVuZXNhcy5jb20+OyBIaXNh
byBNdW5ha2F0YSA8aGlzYW8ubXVuYWthdGEudnRAcmVuZXNhcy5jb20+OyBLdW5pbm9yaSBNb3Jp
bW90byA8a3VuaW5vcmkubW9yaW1vdG8uZ3hAcmVuZXNhcy5jb20+DQpTdWJqZWN0OiBSZTogW0xU
U0ktZGV2XSBUSEVSTUFMOkluY29ycmVjdCBtZWFzdXJlZCB0ZW1wZXJhdHVyZSB2YWx1ZSBhZnRl
ciB1bmJpbmQvYmluZA0KDQpPbiBXZWQsIEZlYiAwMywgMjAxNiBhdCAwOTo1NTowOUFNICswOTAw
LCBOZ3V5ZW4gVmlldCBEdW5nIHdyb3RlOg0KPiBIaSwNCj4gDQo+IHdoZW4gdGVzdHRpbmcgTFRT
SS12NC4xLjEzLXJjMSBvbiB0aGUgU09DIG9mIFJFTkVTQVMoTGFnZXIgYm9hcmQsIA0KPiBLb2Vs
c2NoIGJvYXJkKSwgd2UgaGF2ZSBmb3VuZCB0aGUgZm9sbG93aW5nIHRoZSBmYWlsdXJlIGFib3V0
IHRoZSANCj4gcmNhcl90aGVybWFsIGRyaXZlci4NCj4gRGV0YWlsIG9mIHRoaXMgZmFpbHVyZSBp
czoNCj4gW0FmdGVyIHVuYmluZC9yZWJpbmQgcmNhcl90aGVybWFsIG1lYXN1cmVkIHRlbXBlcmF0
dXJlIGlzIG5vdCANCj4gY29ycmVjdCgtNjUuMMKwQyldIGVycm9yIGxvZzoNCj4gIEtvZWxzY2hf
VGhlcm1hbF91bmJpbmRfcmViaW5kX2Vycm9yX2xvZy50eHQNCj4gIExhZ2VyX1RoZXJtYWxfdW5i
aW5kX3JlYmluZF9lcnJvcl9sb2cudHh0DQo+IA0KPiBXZSBoYXZlIGNoZWNrZWQgdGhhdCB0aGlz
IGZhaWx1cmUgaGFkIGZpeGVkIGJ5IG9uZSBQYXRjaCBvZiBMaW51eC1OZXh0IA0KPiBicmFuY2gu
DQo+ICg1ZGU4NWI5ZDU3YWJhM2VkMmUwNDc1OWU2ZGIzYjllODI2ZGQwYjA2DQo+ICJQTSAvIHJ1
bnRpbWU6IFJlLWluaXQgcnVudGltZSBQTSBzdGF0ZXMgYXQgcHJvYmUgZXJyb3IgYW5kIGRyaXZl
ciANCj4gdW5iaW5kIikNCj4gDQo+IFBsZWFzZSBjb25zaWRlciB0aGlzIHBhdGNoIHRvIGZpeCBl
cnJvciBmb3IgbmV4dCBMVFNJIHJlbGVhc2UNCg0KSSdtIGEgYml0IHdvcnJpZWQgdGhhdCBzb21l
dGhpbmcgbGlrZSB0aGlzIGlzbid0IGluIHRoZSBzdGFibGUga2VybmVsIHJlbGVhc2VzLCBzaG91
bGRuJ3QgaXQgYWxzbyBnbyB0aGVyZSBhcyB3ZWxsPw0KDQp0aGFua3MsDQoNCmdyZWcgay1oDQo

Re: [LTSI-dev] THERMAL:Incorrect measured temperature value after unbind/bind

[Greg KH]

On Wed, Feb 03, 2016 at 04:57:05AM +0000, Hisao Munakata wrote:
> Greg
> 
> If I am not wrong, LTSI can merge linux-next (not yet merged)
> fix unlike regular LTS release, if it is demanded by the industry.

The patch is in Linus's tree, I don't understand why you are referring
to linux-next here, it came out in 4.5-rc1.

> In this particular case, I think it is too late as LTSI-4.1 is already released.
> But I wanted to reconfirm guideline of LTSI patch adoption.
> For me linux-next code is already verified in the community and
> it is relatively clean and safe fix compared to in-house patch.
> 
> How do you think?

I think that if this is a bugfix that really is needed, then it should
probably go to the stable releases so that everyone can benifit.  Why
wouldn't it be needed there first?  Then, any LTSI user will
automatically get it when they update their base kernel version, as they
always should be doing.

thanks,

greg k-h

RE: [LTSI-dev] THERMAL:Incorrect measured temperature value after unbind/bind

[Hisao Munakata]

R3JlZw0KDQpUaGFua3MgZm9yIHRoZSBjbGFyaWZpY2F0aW9uLCBub3cgdW5kZXJzdGFuZCB3YXkg
eW91IHdhcm4uDQpJIGZ1bGx5IGFncmVlIHdpdGggeW91ciB0aG91Z2h0Lg0KSSB3aWxsIGFzayB0
ZWFtIHRvIHJlY29uc2lkZXIgaXRzIGltcG9ydGFuY2UuDQoNCkJlc3QNCk11bmFrYXRhDQoNCi0t
LS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBHcmVnIEtIIFttYWlsdG86Z3JlZ2toQGxp
bnV4Zm91bmRhdGlvbi5vcmddIA0KU2VudDogV2VkbmVzZGF5LCBGZWJydWFyeSAwMywgMjAxNiA0
OjExIFBNDQpUbzogSGlzYW8gTXVuYWthdGEgPGhpc2FvLm11bmFrYXRhLnZ0QHJlbmVzYXMuY29t
Pg0KQ2M6IE5ndXllbiBWaWV0IER1bmcgPG52LWR1bmdAamluc28uY28uanA+OyBsdHNpLWRldkBs
aXN0cy5saW51eGZvdW5kYXRpb24ub3JnOyBsaW51eC1zaEB2Z2VyLmtlcm5lbC5vcmc7IFlvc2hp
aGlybyBTaGltb2RhIDx5b3NoaWhpcm8uc2hpbW9kYS51aEByZW5lc2FzLmNvbT47IEt1bmlub3Jp
IE1vcmltb3RvIDxrdW5pbm9yaS5tb3JpbW90by5neEByZW5lc2FzLmNvbT4NClN1YmplY3Q6IFJl
OiBbTFRTSS1kZXZdIFRIRVJNQUw6SW5jb3JyZWN0IG1lYXN1cmVkIHRlbXBlcmF0dXJlIHZhbHVl
IGFmdGVyIHVuYmluZC9iaW5kDQoNCk9uIFdlZCwgRmViIDAzLCAyMDE2IGF0IDA0OjU3OjA1QU0g
KzAwMDAsIEhpc2FvIE11bmFrYXRhIHdyb3RlOg0KPiBHcmVnDQo+IA0KPiBJZiBJIGFtIG5vdCB3
cm9uZywgTFRTSSBjYW4gbWVyZ2UgbGludXgtbmV4dCAobm90IHlldCBtZXJnZWQpIGZpeCANCj4g
dW5saWtlIHJlZ3VsYXIgTFRTIHJlbGVhc2UsIGlmIGl0IGlzIGRlbWFuZGVkIGJ5IHRoZSBpbmR1
c3RyeS4NCg0KVGhlIHBhdGNoIGlzIGluIExpbnVzJ3MgdHJlZSwgSSBkb24ndCB1bmRlcnN0YW5k
IHdoeSB5b3UgYXJlIHJlZmVycmluZyB0byBsaW51eC1uZXh0IGhlcmUsIGl0IGNhbWUgb3V0IGlu
IDQuNS1yYzEuDQoNCj4gSW4gdGhpcyBwYXJ0aWN1bGFyIGNhc2UsIEkgdGhpbmsgaXQgaXMgdG9v
IGxhdGUgYXMgTFRTSS00LjEgaXMgYWxyZWFkeSByZWxlYXNlZC4NCj4gQnV0IEkgd2FudGVkIHRv
IHJlY29uZmlybSBndWlkZWxpbmUgb2YgTFRTSSBwYXRjaCBhZG9wdGlvbi4NCj4gRm9yIG1lIGxp
bnV4LW5leHQgY29kZSBpcyBhbHJlYWR5IHZlcmlmaWVkIGluIHRoZSBjb21tdW5pdHkgYW5kIGl0
IGlzIA0KPiByZWxhdGl2ZWx5IGNsZWFuIGFuZCBzYWZlIGZpeCBjb21wYXJlZCB0byBpbi1ob3Vz
ZSBwYXRjaC4NCj4gDQo+IEhvdyBkbyB5b3UgdGhpbms/DQoNCkkgdGhpbmsgdGhhdCBpZiB0aGlz
IGlzIGEgYnVnZml4IHRoYXQgcmVhbGx5IGlzIG5lZWRlZCwgdGhlbiBpdCBzaG91bGQgcHJvYmFi
bHkgZ28gdG8gdGhlIHN0YWJsZSByZWxlYXNlcyBzbyB0aGF0IGV2ZXJ5b25lIGNhbiBiZW5pZml0
LiAgV2h5IHdvdWxkbid0IGl0IGJlIG5lZWRlZCB0aGVyZSBmaXJzdD8gIFRoZW4sIGFueSBMVFNJ
IHVzZXIgd2lsbCBhdXRvbWF0aWNhbGx5IGdldCBpdCB3aGVuIHRoZXkgdXBkYXRlIHRoZWlyIGJh
c2Uga2VybmVsIHZlcnNpb24sIGFzIHRoZXkgYWx3YXlzIHNob3VsZCBiZSBkb2luZy4NCg0KdGhh
bmtzLA0KDQpncmVnIGstaA0K

Re: [LTSI-dev] THERMAL:Incorrect measured temperature value after unbind/bind

[Nguyen Viet Dung]

Hi Grep

Thanhk for your reply.

I have seen the consultation of you and Mr.munakara.
I have understanded your thought.

Best regard,
Nguyen Viet Dung

On 2016年02月03日 13:10, Greg KH wrote:
> On Wed, Feb 03, 2016 at 09:55:09AM +0900, Nguyen Viet Dung wrote:
>> Hi,
>>
>> when testting LTSI-v4.1.13-rc1 on the SOC of RENESAS(Lager board, Koelsch
>> board),
>> we have found the following the failure about the rcar_thermal driver.
>> Detail of this failure is:
>> [After unbind/rebind rcar_thermal measured temperature is not
>> correct(-65.0°C)]
>> error log:
>>   Koelsch_Thermal_unbind_rebind_error_log.txt
>>   Lager_Thermal_unbind_rebind_error_log.txt
>>
>> We have checked that this failure had fixed by one Patch of Linux-Next
>> branch.
>> (5de85b9d57aba3ed2e04759e6db3b9e826dd0b06
>> "PM / runtime: Re-init runtime PM states at probe error and driver unbind")
>>
>> Please consider this patch to fix error for next LTSI release
> I'm a bit worried that something like this isn't in the stable
> kernel releases, shouldn't it also go there as well?
>
> thanks,
>
> greg k-h
>