* Re: [PATCH 2/2] include/asm-generic: vmlinux.lds.h
2020-03-15 17:51 ` [PATCH 2/2] include/asm-generic: vmlinux.lds.h Romain Naour
@ 2020-03-15 18:12 ` Geert Uytterhoeven
2020-03-26 4:56 ` Rob Landley
` (4 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2020-03-15 18:12 UTC (permalink / raw)
To: Romain Naour; +Cc: Linux-sh list, Alan Modra, Arnd Bergmann, Linux-Arch
CC arnd, linux-arch
On Sun, Mar 15, 2020 at 6:51 PM Romain Naour <romain.naour@gmail.com> wrote:
> Since the patch [1], building the kernel using a toolchain built with
> Binutils 2.33.1 prevent booting a sh4 system under Qemu.
> Apply the patch provided by Alan Modra [2] that fix alignment of rodata.
>
> [1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;hëd2263ba9a9124d93bbc0ece63d7e0fae89b40e
> [2] https://www.sourceware.org/ml/binutils/2019-12/msg00112.html
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Alan Modra <amodra@gmail.com>
> ---
> include/asm-generic/vmlinux.lds.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index e00f41aa8ec4..d46d34b58c96 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -374,6 +374,7 @@
> */
> #ifndef RO_AFTER_INIT_DATA
> #define RO_AFTER_INIT_DATA \
> + . = ALIGN(8); \
> __start_ro_after_init = .; \
> *(.data..ro_after_init) \
> JUMP_TABLE_DATA \
> --
> 2.24.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 2/2] include/asm-generic: vmlinux.lds.h
2020-03-15 17:51 ` [PATCH 2/2] include/asm-generic: vmlinux.lds.h Romain Naour
2020-03-15 18:12 ` Geert Uytterhoeven
@ 2020-03-26 4:56 ` Rob Landley
2020-03-26 20:42 ` Rich Felker
` (3 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Rob Landley @ 2020-03-26 4:56 UTC (permalink / raw)
To: linux-sh
On 3/15/20 12:51 PM, Romain Naour wrote:
> Since the patch [1], building the kernel using a toolchain built with
> Binutils 2.33.1 prevent booting a sh4 system under Qemu.
> Apply the patch provided by Alan Modra [2] that fix alignment of rodata.
>
> [1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;hëd2263ba9a9124d93bbc0ece63d7e0fae89b40e
> [2] https://www.sourceware.org/ml/binutils/2019-12/msg00112.html
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Alan Modra <amodra@gmail.com>
> ---
> include/asm-generic/vmlinux.lds.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index e00f41aa8ec4..d46d34b58c96 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -374,6 +374,7 @@
> */
> #ifndef RO_AFTER_INIT_DATA
> #define RO_AFTER_INIT_DATA \
> + . = ALIGN(8); \
> __start_ro_after_init = .; \
> *(.data..ro_after_init) \
> JUMP_TABLE_DATA \
>
This patch and the previous one:
Tested-by: Rob Landley <rob@landley.net>
Worked for me with a current musl-cross-make toolchain.
It would be nice if we could get this into 5.6.
Rob
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 2/2] include/asm-generic: vmlinux.lds.h
2020-03-15 17:51 ` [PATCH 2/2] include/asm-generic: vmlinux.lds.h Romain Naour
2020-03-15 18:12 ` Geert Uytterhoeven
2020-03-26 4:56 ` Rob Landley
@ 2020-03-26 20:42 ` Rich Felker
2020-03-27 22:05 ` Rob Landley
` (2 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Rich Felker @ 2020-03-26 20:42 UTC (permalink / raw)
To: linux-sh
On Sun, Mar 15, 2020 at 06:51:08PM +0100, Romain Naour wrote:
> Since the patch [1], building the kernel using a toolchain built with
> Binutils 2.33.1 prevent booting a sh4 system under Qemu.
> Apply the patch provided by Alan Modra [2] that fix alignment of rodata.
>
> [1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;hëd2263ba9a9124d93bbc0ece63d7e0fae89b40e
> [2] https://www.sourceware.org/ml/binutils/2019-12/msg00112.html
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Alan Modra <amodra@gmail.com>
Acked-by: Rich Felker <dalias@libc.org>
> ---
> include/asm-generic/vmlinux.lds.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index e00f41aa8ec4..d46d34b58c96 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -374,6 +374,7 @@
> */
> #ifndef RO_AFTER_INIT_DATA
> #define RO_AFTER_INIT_DATA \
> + . = ALIGN(8); \
> __start_ro_after_init = .; \
> *(.data..ro_after_init) \
> JUMP_TABLE_DATA \
> --
> 2.24.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 2/2] include/asm-generic: vmlinux.lds.h
2020-03-15 17:51 ` [PATCH 2/2] include/asm-generic: vmlinux.lds.h Romain Naour
` (2 preceding siblings ...)
2020-03-26 20:42 ` Rich Felker
@ 2020-03-27 22:05 ` Rob Landley
2020-03-28 10:29 ` Geert Uytterhoeven
2020-03-29 2:10 ` Rob Landley
5 siblings, 0 replies; 9+ messages in thread
From: Rob Landley @ 2020-03-27 22:05 UTC (permalink / raw)
To: linux-sh
On 3/26/20 3:42 PM, Rich Felker wrote:
> On Sun, Mar 15, 2020 at 06:51:08PM +0100, Romain Naour wrote:
>> Since the patch [1], building the kernel using a toolchain built with
>> Binutils 2.33.1 prevent booting a sh4 system under Qemu.
>> Apply the patch provided by Alan Modra [2] that fix alignment of rodata.
>>
>> [1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;hëd2263ba9a9124d93bbc0ece63d7e0fae89b40e
>> [2] https://www.sourceware.org/ml/binutils/2019-12/msg00112.html
>>
>> Signed-off-by: Romain Naour <romain.naour@gmail.com>
>> Cc: Alan Modra <amodra@gmail.com>
>
> Acked-by: Rich Felker <dalias@libc.org>
Is there any way to get this into sunday's release?
Acked-by: Rob Landley <rob@landley.net>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 2/2] include/asm-generic: vmlinux.lds.h
2020-03-15 17:51 ` [PATCH 2/2] include/asm-generic: vmlinux.lds.h Romain Naour
` (3 preceding siblings ...)
2020-03-27 22:05 ` Rob Landley
@ 2020-03-28 10:29 ` Geert Uytterhoeven
2020-03-29 2:10 ` Rob Landley
5 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2020-03-28 10:29 UTC (permalink / raw)
To: linux-sh
CC arnd
On Fri, Mar 27, 2020 at 11:00 PM Rob Landley <rob@landley.net> wrote:
> On 3/26/20 3:42 PM, Rich Felker wrote:
> > On Sun, Mar 15, 2020 at 06:51:08PM +0100, Romain Naour wrote:
> >> Since the patch [1], building the kernel using a toolchain built with
> >> Binutils 2.33.1 prevent booting a sh4 system under Qemu.
> >> Apply the patch provided by Alan Modra [2] that fix alignment of rodata.
> >>
> >> [1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;hëd2263ba9a9124d93bbc0ece63d7e0fae89b40e
> >> [2] https://www.sourceware.org/ml/binutils/2019-12/msg00112.html
> >>
> >> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> >> Cc: Alan Modra <amodra@gmail.com>
> >
> > Acked-by: Rich Felker <dalias@libc.org>
>
> Is there any way to get this into sunday's release?
Not if the maintainer isn't in CC.
> Acked-by: Rob Landley <rob@landley.net>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 2/2] include/asm-generic: vmlinux.lds.h
2020-03-15 17:51 ` [PATCH 2/2] include/asm-generic: vmlinux.lds.h Romain Naour
` (4 preceding siblings ...)
2020-03-28 10:29 ` Geert Uytterhoeven
@ 2020-03-29 2:10 ` Rob Landley
5 siblings, 0 replies; 9+ messages in thread
From: Rob Landley @ 2020-03-29 2:10 UTC (permalink / raw)
To: linux-sh
[-- Attachment #1: Type: text/plain, Size: 1271 bytes --]
Binutils 2.33.1 needs explicit alignment directives or sh kernel won't boot.
https://www.spinics.net/lists/linux-sh/msg56835.html
https://www.spinics.net/lists/linux-sh/msg56836.html
Patches attached, acked by arch maintainer and tested by me.
On 3/28/20 5:29 AM, Geert Uytterhoeven wrote:
> CC arnd
>
> On Fri, Mar 27, 2020 at 11:00 PM Rob Landley <rob@landley.net> wrote:
>> On 3/26/20 3:42 PM, Rich Felker wrote:
>>> On Sun, Mar 15, 2020 at 06:51:08PM +0100, Romain Naour wrote:
>>>> Since the patch [1], building the kernel using a toolchain built with
>>>> Binutils 2.33.1 prevent booting a sh4 system under Qemu.
>>>> Apply the patch provided by Alan Modra [2] that fix alignment of rodata.
>>>>
>>>> [1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ebd2263ba9a9124d93bbc0ece63d7e0fae89b40e
>>>> [2] https://www.sourceware.org/ml/binutils/2019-12/msg00112.html
>>>>
>>>> Signed-off-by: Romain Naour <romain.naour@gmail.com>
>>>> Cc: Alan Modra <amodra@gmail.com>
>>>
>>> Acked-by: Rich Felker <dalias@libc.org>
>>
>> Is there any way to get this into sunday's release?
>
> Not if the maintainer isn't in CC.
>
>> Acked-by: Rob Landley <rob@landley.net>
>
> Gr{oetje,eeting}s,
>
> Geert
>
[Puppy eyes intensify.]
Rob
[-- Attachment #2: patch1.patch --]
[-- Type: text/x-patch, Size: 1336 bytes --]
From: Romain Naour <romain.naour@gmail.com>
To: linux-sh@vger.kernel.org
Cc: Romain Naour <romain.naour@gmail.com>,
Alan Modra <amodra@gmail.com>
Subject: [PATCH 1/2] arch/sh: vmlinux.scr
Date: Sun, 15 Mar 2020 18:51:07 +0100
Message-Id: <20200315175108.9694-1-romain.naour@gmail.com>
Since the patch [1], building the kernel using a toolchain built with
Binutils 2.33.1 prevent booting a sh4 system under Qemu.
Apply the patch provided by Alan Modra [2] that fix alignment of rodata.
[1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ebd2263ba9a9124d93bbc0ece63d7e0fae89b40e
[2] https://www.sourceware.org/ml/binutils/2019-12/msg00112.html
Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Alan Modra <amodra@gmail.com>
Acked-by: Rich Felker <dalias@libc.org>
Tested-by: Rob Landley <rob@landley.net>
---
arch/sh/boot/compressed/vmlinux.scr | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/sh/boot/compressed/vmlinux.scr b/arch/sh/boot/compressed/vmlinux.scr
index 862d74808236..dd292b4b9082 100644
--- a/arch/sh/boot/compressed/vmlinux.scr
+++ b/arch/sh/boot/compressed/vmlinux.scr
@@ -1,6 +1,6 @@
SECTIONS
{
- .rodata..compressed : {
+ .rodata..compressed : ALIGN(8) {
input_len = .;
LONG(input_data_end - input_data) input_data = .;
*(.data)
--
2.24.1
[-- Attachment #3: patch2.patch --]
[-- Type: text/x-patch, Size: 1358 bytes --]
From: Romain Naour <romain.naour@gmail.com>
To: linux-sh@vger.kernel.org
Cc: Romain Naour <romain.naour@gmail.com>,
Alan Modra <amodra@gmail.com>
Subject: [PATCH 2/2] include/asm-generic: vmlinux.lds.h
Date: Sun, 15 Mar 2020 18:51:08 +0100
Message-Id: <20200315175108.9694-2-romain.naour@gmail.com>
Since the patch [1], building the kernel using a toolchain built with
Binutils 2.33.1 prevent booting a sh4 system under Qemu.
Apply the patch provided by Alan Modra [2] that fix alignment of rodata.
[1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ebd2263ba9a9124d93bbc0ece63d7e0fae89b40e
[2] https://www.sourceware.org/ml/binutils/2019-12/msg00112.html
Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Alan Modra <amodra@gmail.com>
Acked-by: Rich Felker <dalias@libc.org>
Tested-by: Rob Landley <rob@landley.net>
---
include/asm-generic/vmlinux.lds.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index e00f41aa8ec4..d46d34b58c96 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -374,6 +374,7 @@
*/
#ifndef RO_AFTER_INIT_DATA
#define RO_AFTER_INIT_DATA \
+ . = ALIGN(8); \
__start_ro_after_init = .; \
*(.data..ro_after_init) \
JUMP_TABLE_DATA \
--
2.24.1
^ permalink raw reply related [flat|nested] 9+ messages in thread