* [PATCH 03/14] sh: pci: Do PCI error check on own line [not found] <20230824132832.78705-1-ilpo.jarvinen@linux.intel.com> @ 2023-08-24 13:28 ` Ilpo Järvinen 2023-08-24 13:44 ` John Paul Adrian Glaubitz 0 siblings, 1 reply; 2+ messages in thread From: Ilpo Järvinen @ 2023-08-24 13:28 UTC (permalink / raw) To: linux-pci, Bjorn Helgaas, Yoshinori Sato, Rich Felker, John Paul Adrian Glaubitz, linux-sh, linux-kernel Cc: Ilpo Järvinen Instead of a if condition with a line split, use the usual error handling pattern with a separate variable to improve readability. No functional changes intended. Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> --- arch/sh/drivers/pci/common.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/sh/drivers/pci/common.c b/arch/sh/drivers/pci/common.c index 2fd2b77e12ce..f59e5b9a6a80 100644 --- a/arch/sh/drivers/pci/common.c +++ b/arch/sh/drivers/pci/common.c @@ -53,15 +53,16 @@ int __init pci_is_66mhz_capable(struct pci_channel *hose, unsigned short vid; int cap66 = -1; u16 stat; + int ret; pr_info("PCI: Checking 66MHz capabilities...\n"); for (pci_devfn = 0; pci_devfn < 0xff; pci_devfn++) { if (PCI_FUNC(pci_devfn)) continue; - if (early_read_config_word(hose, top_bus, current_bus, - pci_devfn, PCI_VENDOR_ID, &vid) != - PCIBIOS_SUCCESSFUL) + ret = early_read_config_word(hose, top_bus, current_bus, + pci_devfn, PCI_VENDOR_ID, &vid); + if (ret != PCIBIOS_SUCCESSFUL) continue; if (vid == 0xffff) continue; -- 2.30.2 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 03/14] sh: pci: Do PCI error check on own line 2023-08-24 13:28 ` [PATCH 03/14] sh: pci: Do PCI error check on own line Ilpo Järvinen @ 2023-08-24 13:44 ` John Paul Adrian Glaubitz 0 siblings, 0 replies; 2+ messages in thread From: John Paul Adrian Glaubitz @ 2023-08-24 13:44 UTC (permalink / raw) To: Ilpo Järvinen, linux-pci, Bjorn Helgaas, Yoshinori Sato, Rich Felker, linux-sh, linux-kernel On Thu, 2023-08-24 at 16:28 +0300, Ilpo Järvinen wrote: > Instead of a if condition with a line split, use the usual error > handling pattern with a separate variable to improve readability. > > No functional changes intended. > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > --- > arch/sh/drivers/pci/common.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/arch/sh/drivers/pci/common.c b/arch/sh/drivers/pci/common.c > index 2fd2b77e12ce..f59e5b9a6a80 100644 > --- a/arch/sh/drivers/pci/common.c > +++ b/arch/sh/drivers/pci/common.c > @@ -53,15 +53,16 @@ int __init pci_is_66mhz_capable(struct pci_channel *hose, > unsigned short vid; > int cap66 = -1; > u16 stat; > + int ret; > > pr_info("PCI: Checking 66MHz capabilities...\n"); > > for (pci_devfn = 0; pci_devfn < 0xff; pci_devfn++) { > if (PCI_FUNC(pci_devfn)) > continue; > - if (early_read_config_word(hose, top_bus, current_bus, > - pci_devfn, PCI_VENDOR_ID, &vid) != > - PCIBIOS_SUCCESSFUL) > + ret = early_read_config_word(hose, top_bus, current_bus, > + pci_devfn, PCI_VENDOR_ID, &vid); > + if (ret != PCIBIOS_SUCCESSFUL) > continue; > if (vid == 0xffff) > continue; Acked-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-24 13:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230824132832.78705-1-ilpo.jarvinen@linux.intel.com>
2023-08-24 13:28 ` [PATCH 03/14] sh: pci: Do PCI error check on own line Ilpo Järvinen
2023-08-24 13:44 ` John Paul Adrian Glaubitz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox