* [PATCH AUTOSEL 6.8 75/98] sh: Fix build with CONFIG_UBSAN=y
[not found] <20240329123919.3087149-1-sashal@kernel.org>
@ 2024-03-29 12:37 ` Sasha Levin
2024-03-30 2:06 ` Kees Cook
0 siblings, 1 reply; 2+ messages in thread
From: Sasha Levin @ 2024-03-29 12:37 UTC (permalink / raw)
To: linux-kernel, stable
Cc: Kees Cook, kernel test robot, Yoshinori Sato, Rich Felker,
John Paul Adrian Glaubitz, Masahiro Yamada, Nicolas Schier,
linux-sh, Sasha Levin
From: Kees Cook <keescook@chromium.org>
[ Upstream commit e36b70fb8c707a0688960184380bc151390d671b ]
The early boot stub for sh had UBSan instrumentation present where it is
not supported. Disable it for this part of the build.
sh4-linux-ld: arch/sh/boot/compressed/misc.o: in function `zlib_inflate_table':
misc.c:(.text+0x670): undefined reference to `__ubsan_handle_shift_out_of_bounds'
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202401310416.s8HLiLnC-lkp@intel.com/
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: Nicolas Schier <n.schier@avm.de>
Cc: <linux-sh@vger.kernel.org>
Link: https://lore.kernel.org/r/20240130232717.work.088-kees@kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
arch/sh/boot/compressed/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/sh/boot/compressed/Makefile b/arch/sh/boot/compressed/Makefile
index b5e29f99c02c8..6c6c791a1d063 100644
--- a/arch/sh/boot/compressed/Makefile
+++ b/arch/sh/boot/compressed/Makefile
@@ -12,6 +12,7 @@ targets := vmlinux vmlinux.bin vmlinux.bin.gz vmlinux.bin.bz2 \
vmlinux.bin.lzma vmlinux.bin.xz vmlinux.bin.lzo $(OBJECTS)
GCOV_PROFILE := n
+UBSAN_SANITIZE := n
#
# IMAGE_OFFSET is the load offset of the compression loader
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH AUTOSEL 6.8 75/98] sh: Fix build with CONFIG_UBSAN=y
2024-03-29 12:37 ` [PATCH AUTOSEL 6.8 75/98] sh: Fix build with CONFIG_UBSAN=y Sasha Levin
@ 2024-03-30 2:06 ` Kees Cook
0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2024-03-30 2:06 UTC (permalink / raw)
To: Sasha Levin
Cc: linux-kernel, stable, kernel test robot, Yoshinori Sato,
Rich Felker, John Paul Adrian Glaubitz, Masahiro Yamada,
Nicolas Schier, linux-sh
On Fri, Mar 29, 2024 at 08:37:46AM -0400, Sasha Levin wrote:
> From: Kees Cook <keescook@chromium.org>
>
> [ Upstream commit e36b70fb8c707a0688960184380bc151390d671b ]
>
> The early boot stub for sh had UBSan instrumentation present where it is
> not supported. Disable it for this part of the build.
>
> sh4-linux-ld: arch/sh/boot/compressed/misc.o: in function `zlib_inflate_table':
> misc.c:(.text+0x670): undefined reference to `__ubsan_handle_shift_out_of_bounds'
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202401310416.s8HLiLnC-lkp@intel.com/
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Cc: Rich Felker <dalias@libc.org>
> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Cc: Nicolas Schier <n.schier@avm.de>
> Cc: <linux-sh@vger.kernel.org>
> Link: https://lore.kernel.org/r/20240130232717.work.088-kees@kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
Same as the other:
This is harmless to backport, but doesn't do anything. (The UBSAN
changes needing this are only in Linus's tree.)
-Kees
--
Kees Cook
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-30 2:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240329123919.3087149-1-sashal@kernel.org>
2024-03-29 12:37 ` [PATCH AUTOSEL 6.8 75/98] sh: Fix build with CONFIG_UBSAN=y Sasha Levin
2024-03-30 2:06 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox