Re: [PATCH v4 5/9] ARM: shmobile: marzen: Enable DU device in DT

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Sergei,

Thank you for the review.

On Friday 24 October 2014 16:36:38 Sergei Shtylyov wrote:
> On 10/24/2014 4:03 PM, Laurent Pinchart wrote:
> > Specify the DU output topology, enable the DU device and configure the
> > related pins.
> > 
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >   arch/arm/boot/dts/r8a7779-marzen.dts | 81 ++++++++++++++++++++++++++++++
> >   1 file changed, 81 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/r8a7779-marzen.dts
> > b/arch/arm/boot/dts/r8a7779-marzen.dts index 9e1b859190ca..64a5d634edc1
> > 100644
> > --- a/arch/arm/boot/dts/r8a7779-marzen.dts
> > +++ b/arch/arm/boot/dts/r8a7779-marzen.dts
> > @@ -69,6 +69,76 @@
> >   			gpios = <&gpio4 31 GPIO_ACTIVE_HIGH>;
> >   		};
> >   	};
> > +
> > +	vga-encoder {
> > +		compatible = "adi,adv7123";
> 
> [...]
> 
> > +	lvds-enc {
> 
> Using "lvds-encoder" would have been more consistent.

I'll fix that.

> > +		compatible = "thine,thc63lvdm83d";
> > +
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		ports {
> > +			port@0 {
> 
> Hm, I don't see the "reg" prop, where is it?

In arch/arm/boot/dts/r8a7779.dtsi.

> > +				lvds_enc_in: endpoint {
> > +					remote-endpoint = <&du_out_rgb1>;
> > +				};
> > +			};
> > +			port@1 {
> > +				lvds_connector: endpoint {
> > +				};
> > +			};
> > +		};
> > +	};
> > +};

-- 
Regards,

Laurent Pinchart