Re: [PATCH v4 5/9] ARM: shmobile: marzen: Enable DU device in DT

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

On Monday 27 October 2014 10:18:16 Geert Uytterhoeven wrote:
> On Mon, Oct 27, 2014 at 2:23 AM, Simon Horman <horms@verge.net.au> wrote:
> > I have this patch queued up but I notice that it seems to introduce
> > the following warnings. Can this be addressed somehow?
> > 
> > Warning (reg_format): "reg" property in /lvds-encoder/ports/port@0 has
> > invalid length (4 bytes) (#address-cells = 2, #size-cells = 1) Warning
> > (reg_format): "reg" property in /lvds-encoder/ports/port@1 has invalid
> > length (4 bytes) (#address-cells = 2, #size-cells = 1) Warning
> > (avoid_default_addr_size): Relying on default #address-cells value for
> > /lvds-encoder/ports/port@0 Warning (avoid_default_addr_size): Relying on
> > default #size-cells value for /lvds-encoder/ports/port@0 Warning
> > (avoid_default_addr_size): Relying on default #address-cells value for
> > /lvds-encoder/ports/port@1 Warning (avoid_default_addr_size): Relying on
> > default #size-cells value for /lvds-encoder/ports/port@1> 
> >> ---
> >> 
> >>  arch/arm/boot/dts/r8a7779-marzen.dts | 81 ++++++++++++++++++++++++++++++
> >>  1 file changed, 81 insertions(+)
> >> 
> >> diff --git a/arch/arm/boot/dts/r8a7779-marzen.dts
> >> b/arch/arm/boot/dts/r8a7779-marzen.dts index 9e1b859190ca..64a5d634edc1
> >> 100644
> >> --- a/arch/arm/boot/dts/r8a7779-marzen.dts
> >> +++ b/arch/arm/boot/dts/r8a7779-marzen.dts
> >> @@ -69,6 +69,76 @@
> >>                       gpios = <&gpio4 31 GPIO_ACTIVE_HIGH>;
> >>               };
> >>       };
> >> +
> >> +     vga-encoder {
> >> +             compatible = "adi,adv7123";
> >> +
> >> +             ports {
> >> +                     #address-cells = <1>;
> >> +                     #size-cells = <0>;
> >> +
> >> +                     port@0 {
> >> +                             reg = <0>;
> >> +                             vga_enc_in: endpoint {
> >> +                                     remote-endpoint = <&du_out_rgb0>;
> >> +                             };
> >> +                     };
> >> +                     port@1 {
> >> +                             reg = <1>;
> >> +                             vga_enc_out: endpoint {
> >> +                                     remote-endpoint = <&vga_in>;
> >> +                             };
> >> +                     };
> >> +             };
> >> +     };
> >> +
> >> +     vga {
> >> +             compatible = "vga-connector";
> >> +
> >> +             port {
> >> +                     vga_in: endpoint {
> >> +                             remote-endpoint = <&vga_enc_out>;
> >> +                     };
> >> +             };
> >> +     };
> >> +
> >> +     lvds-enc {
> >> +             compatible = "thine,thc63lvdm83d";
> >> +
> >> +             #address-cells = <1>;
> >> +             #size-cells = <0>;
> 
> I think the two properties above should be moved to the ports node below.
> 
> >> +
> >> +             ports {
> 
> ---> HERE.

That's correct. Sorry for the oversight. I've submitted a patch to fix this.

> Yes, this can be a real PITA. I had to sprinkle lots of #address-cells = <1>
> and #size-cells = <0> to the hierarchical PM domain nodes, too.

I wonder if there's a reason why those properties are not inherited.

> >> +                     port@0 {
> >> +                             lvds_enc_in: endpoint {
> >> +                                     remote-endpoint = <&du_out_rgb1>;
> >> +                             };
> >> +                     };
> >> +                     port@1 {
> >> +                             lvds_connector: endpoint {
> >> +                             };
> >> +                     };
> >> +             };
> >> +     };

-- 
Regards,

Laurent Pinchart