From: Richard Henderson <rth@twiddle.net>
To: Aleksa Sarai <asarai@suse.de>, Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Arnd Bergmann <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
alpha <linux-alpha@vger.kernel.org>,
Linux MIPS Mailing List <linux-mips@linux-mips.org>,
Parisc List <linux-parisc@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
sparclinux <sparclinux@vger.kernel.org>,
"linux-xtensa@linux-xtensa.org" <linux-xtensa@linux-xtensa.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
Christian Brauner <christian.brauner@ubuntu.com>,
Valentin Rothberg <vrothberg@suse.com>
Subject: Re: [PATCH] tty: add TIOCGPTPEER ioctl
Date: Thu, 01 Jun 2017 20:12:15 +0000 [thread overview]
Message-ID: <4e16e83b-8fb7-c9b6-2f06-ee48499a67db@twiddle.net> (raw)
In-Reply-To: <a0671efc-4c4e-bbdc-c9d8-a7bdc22b872a@suse.de>
On 06/01/2017 01:00 PM, Aleksa Sarai wrote:
>>> --- a/arch/alpha/include/uapi/asm/ioctls.h
>>> +++ b/arch/alpha/include/uapi/asm/ioctls.h
>>> @@ -94,6 +94,7 @@
>>> #define TIOCSRS485 _IOWR('T', 0x2F, struct serial_rs485)
>>> #define TIOCGPTN _IOR('T',0x30, unsigned int) /* Get Pty Number (of
>>> pty-mux device) */
>>> #define TIOCSPTLCK _IOW('T',0x31, int) /* Lock/unlock Pty */
>>> +#define TIOCGPTPEER _IOR('T', 0x41, int) /* Safely open the slave */
>>
>> Shouldn't the list of definitions be kept sorted, by hex number?
>> (everywhere)
>
> Probably. The reason I put it here is because it logically is very similar to
> TIOCGPTN and TIOSPTLCK, but I can move it if the hex order is more important
> for maintainence.
>
Yes please.
r~
prev parent reply other threads:[~2017-06-01 20:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 17:38 [PATCH] tty: add TIOCGPTPEER ioctl Aleksa Sarai
2017-06-01 18:46 ` Geert Uytterhoeven
2017-06-01 20:00 ` Aleksa Sarai
2017-06-01 20:12 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e16e83b-8fb7-c9b6-2f06-ee48499a67db@twiddle.net \
--to=rth@twiddle.net \
--cc=arnd@arndb.de \
--cc=asarai@suse.de \
--cc=christian.brauner@ubuntu.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sparclinux@vger.kernel.org \
--cc=vrothberg@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox