* Re: [PATCH 1/2] ARM: shmobile: kzm9g-reference: Add PCF8575 GPIO extender to DT
2013-11-26 1:21 [PATCH 1/2] ARM: shmobile: kzm9g-reference: Add PCF8575 GPIO extender to DT Laurent Pinchart
@ 2013-11-28 7:53 ` Simon Horman
2014-11-07 13:46 ` [PATCH 1/2] ARM: shmobile: kzm9g-reference: Add restart callback Geert Uytterhoeven
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2013-11-28 7:53 UTC (permalink / raw)
To: linux-sh
On Tue, Nov 26, 2013 at 02:21:18AM +0100, Laurent Pinchart wrote:
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> arch/arm/boot/dts/sh73a0-kzm9g-reference.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
Thanks, I have queued this up.
>
> diff --git a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> index 12fdfaa..d58877d 100644
> --- a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> +++ b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> @@ -186,6 +186,17 @@
> pinctrl-0 = <&i2c3_pins>;
> pinctrl-names = "default";
> status = "okay";
> +
> + pcf8575: gpio@20 {
> + compatible = "nxp,pcf8575";
> + reg = <0x20>;
> + interrupt-parent = <&irqpin2>;
> + interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> };
>
> &mmcif {
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/2] ARM: shmobile: kzm9g-reference: Add restart callback
2013-11-26 1:21 [PATCH 1/2] ARM: shmobile: kzm9g-reference: Add PCF8575 GPIO extender to DT Laurent Pinchart
2013-11-28 7:53 ` Simon Horman
@ 2014-11-07 13:46 ` Geert Uytterhoeven
2014-11-07 13:53 ` Sergei Shtylyov
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2014-11-07 13:46 UTC (permalink / raw)
To: linux-sh
Port the sh73a0 restart handling from the kzm9g-legacy board code to the
kzm9g-reference board code.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Tested on kzm9g-reference
arch/arm/mach-shmobile/board-kzm9g-reference.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/mach-shmobile/board-kzm9g-reference.c b/arch/arm/mach-shmobile/board-kzm9g-reference.c
index f2ef759b6e969cc8..2e82e44ab85258b7 100644
--- a/arch/arm/mach-shmobile/board-kzm9g-reference.c
+++ b/arch/arm/mach-shmobile/board-kzm9g-reference.c
@@ -39,6 +39,13 @@ static void __init kzm_init(void)
#endif
}
+#define RESCNT2 IOMEM(0xe6188020)
+static void kzm9g_restart(enum reboot_mode mode, const char *cmd)
+{
+ /* Do soft power on reset */
+ writel((1 << 31), RESCNT2);
+}
+
static const char *kzm9g_boards_compat_dt[] __initdata = {
"renesas,kzm9g-reference",
NULL,
@@ -50,5 +57,6 @@ DT_MACHINE_START(KZM9G_DT, "kzm9g-reference")
.init_early = shmobile_init_delay,
.init_machine = kzm_init,
.init_late = shmobile_init_late,
+ .restart = kzm9g_restart,
.dt_compat = kzm9g_boards_compat_dt,
MACHINE_END
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] ARM: shmobile: kzm9g-reference: Add restart callback
2013-11-26 1:21 [PATCH 1/2] ARM: shmobile: kzm9g-reference: Add PCF8575 GPIO extender to DT Laurent Pinchart
2013-11-28 7:53 ` Simon Horman
2014-11-07 13:46 ` [PATCH 1/2] ARM: shmobile: kzm9g-reference: Add restart callback Geert Uytterhoeven
@ 2014-11-07 13:53 ` Sergei Shtylyov
2014-11-10 0:41 ` Simon Horman
2014-11-10 1:14 ` Simon Horman
4 siblings, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2014-11-07 13:53 UTC (permalink / raw)
To: linux-sh
Hello.
On 11/7/2014 4:46 PM, Geert Uytterhoeven wrote:
> Port the sh73a0 restart handling from the kzm9g-legacy board code to the
> kzm9g-reference board code.
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Tested on kzm9g-reference
>
> arch/arm/mach-shmobile/board-kzm9g-reference.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
> diff --git a/arch/arm/mach-shmobile/board-kzm9g-reference.c b/arch/arm/mach-shmobile/board-kzm9g-reference.c
> index f2ef759b6e969cc8..2e82e44ab85258b7 100644
> --- a/arch/arm/mach-shmobile/board-kzm9g-reference.c
> +++ b/arch/arm/mach-shmobile/board-kzm9g-reference.c
> @@ -39,6 +39,13 @@ static void __init kzm_init(void)
> #endif
> }
>
> +#define RESCNT2 IOMEM(0xe6188020)
> +static void kzm9g_restart(enum reboot_mode mode, const char *cmd)
> +{
> + /* Do soft power on reset */
> + writel((1 << 31), RESCNT2);
Inner () should not be needed.
[...]
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] ARM: shmobile: kzm9g-reference: Add restart callback
2013-11-26 1:21 [PATCH 1/2] ARM: shmobile: kzm9g-reference: Add PCF8575 GPIO extender to DT Laurent Pinchart
` (2 preceding siblings ...)
2014-11-07 13:53 ` Sergei Shtylyov
@ 2014-11-10 0:41 ` Simon Horman
2014-11-10 1:14 ` Simon Horman
4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2014-11-10 0:41 UTC (permalink / raw)
To: linux-sh
On Fri, Nov 07, 2014 at 04:53:31PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 11/7/2014 4:46 PM, Geert Uytterhoeven wrote:
>
> >Port the sh73a0 restart handling from the kzm9g-legacy board code to the
> >kzm9g-reference board code.
>
> >Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >---
> >Tested on kzm9g-reference
> >
> > arch/arm/mach-shmobile/board-kzm9g-reference.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
>
> >diff --git a/arch/arm/mach-shmobile/board-kzm9g-reference.c b/arch/arm/mach-shmobile/board-kzm9g-reference.c
> >index f2ef759b6e969cc8..2e82e44ab85258b7 100644
> >--- a/arch/arm/mach-shmobile/board-kzm9g-reference.c
> >+++ b/arch/arm/mach-shmobile/board-kzm9g-reference.c
> >@@ -39,6 +39,13 @@ static void __init kzm_init(void)
> > #endif
> > }
> >
> >+#define RESCNT2 IOMEM(0xe6188020)
> >+static void kzm9g_restart(enum reboot_mode mode, const char *cmd)
> >+{
> >+ /* Do soft power on reset */
> >+ writel((1 << 31), RESCNT2);
>
> Inner () should not be needed.
Over in the purple bike shed someone told me that all the cool kids
are using BIT(31) these days.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] ARM: shmobile: kzm9g-reference: Add restart callback
2013-11-26 1:21 [PATCH 1/2] ARM: shmobile: kzm9g-reference: Add PCF8575 GPIO extender to DT Laurent Pinchart
` (3 preceding siblings ...)
2014-11-10 0:41 ` Simon Horman
@ 2014-11-10 1:14 ` Simon Horman
4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2014-11-10 1:14 UTC (permalink / raw)
To: linux-sh
On Fri, Nov 07, 2014 at 02:46:32PM +0100, Geert Uytterhoeven wrote:
> Port the sh73a0 restart handling from the kzm9g-legacy board code to the
> kzm9g-reference board code.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Tested on kzm9g-reference
Thanks, I have queued this up.
>
> arch/arm/mach-shmobile/board-kzm9g-reference.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/mach-shmobile/board-kzm9g-reference.c b/arch/arm/mach-shmobile/board-kzm9g-reference.c
> index f2ef759b6e969cc8..2e82e44ab85258b7 100644
> --- a/arch/arm/mach-shmobile/board-kzm9g-reference.c
> +++ b/arch/arm/mach-shmobile/board-kzm9g-reference.c
> @@ -39,6 +39,13 @@ static void __init kzm_init(void)
> #endif
> }
>
> +#define RESCNT2 IOMEM(0xe6188020)
> +static void kzm9g_restart(enum reboot_mode mode, const char *cmd)
> +{
> + /* Do soft power on reset */
> + writel((1 << 31), RESCNT2);
> +}
> +
> static const char *kzm9g_boards_compat_dt[] __initdata = {
> "renesas,kzm9g-reference",
> NULL,
> @@ -50,5 +57,6 @@ DT_MACHINE_START(KZM9G_DT, "kzm9g-reference")
> .init_early = shmobile_init_delay,
> .init_machine = kzm_init,
> .init_late = shmobile_init_late,
> + .restart = kzm9g_restart,
> .dt_compat = kzm9g_boards_compat_dt,
> MACHINE_END
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread