[PATCH/RFC v3 3/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X

[PATCH/RFC v3 3/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X

[Simon Horman]

From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>

Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
[horms: minor updates]
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

---
v0 [Kazuya Mizuguchi]

v1 [Simon Horman]
* updated filename to salvator-x
* updated patch subject

v2 [Simon Horman]
* Removed spurious update to r8a7795.dtsi introduced in v1
* Removed unused renesas,phy property

v3 [Simon Horman]
* No change but provided PFC driver update in separate patch(set)
---
 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 33 ++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
index 5bae2cc0c61e..4fb141230f0c 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
@@ -41,6 +41,11 @@
 		renesas,groups = "scif2_data_a";
 		renesas,function = "scif2";
 	};
+
+	avb_pins: avb {
+		renesas,groups = "avb_mdc";
+		renesas,function = "avb";
+	};
 };
 
 &scif1 {
@@ -56,3 +61,31 @@
 
 	status = "okay";
 };
+
+&avb {
+	pinctrl-0 = <&avb_pins>;
+	pinctrl-names = "default";
+	renesas,no-ether-link;
+	phy-reset-gpio = <&gpio2 10 0>;
+	phy-handle = <&phy0>;
+	status = "okay";
+
+	phy0: ethernet-phy@0 {
+		rxc-skew-ps = <900>;
+		rxdv-skew-ps = <0>;
+		rxd0-skew-ps = <0>;
+		rxd1-skew-ps = <0>;
+		rxd2-skew-ps = <0>;
+		rxd3-skew-ps = <0>;
+		txc-skew-ps = <900>;
+		txen-skew-ps = <0>;
+		txd0-skew-ps = <0>;
+		txd1-skew-ps = <0>;
+		txd2-skew-ps = <0>;
+		txd3-skew-ps = <0>;
+		reg = <0>;
+		interrupt-parent = <&gpio2>;
+		interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
+	};
+
+};
-- 
2.1.4

Re: [PATCH/RFC v3 3/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X

[Sergei Shtylyov]

Hello.

On 9/18/2015 9:05 AM, Simon Horman wrote:

> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> [horms: minor updates]
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

[...]

> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> index 5bae2cc0c61e..4fb141230f0c 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
[...]
> @@ -56,3 +61,31 @@
>
>   	status = "okay";
>   };
> +
> +&avb {
> +	pinctrl-0 = <&avb_pins>;
> +	pinctrl-names = "default";
> +	renesas,no-ether-link;
> +	phy-reset-gpio = <&gpio2 10 0>;

    Undocumented prop. You were going to delete it from the binding example.

> +	phy-handle = <&phy0>;
> +	status = "okay";
> +
> +	phy0: ethernet-phy@0 {
> +		rxc-skew-ps = <900>;
> +		rxdv-skew-ps = <0>;
> +		rxd0-skew-ps = <0>;
> +		rxd1-skew-ps = <0>;
> +		rxd2-skew-ps = <0>;
> +		rxd3-skew-ps = <0>;
> +		txc-skew-ps = <900>;
> +		txen-skew-ps = <0>;
> +		txd0-skew-ps = <0>;
> +		txd1-skew-ps = <0>;
> +		txd2-skew-ps = <0>;
> +		txd3-skew-ps = <0>;
> +		reg = <0>;
> +		interrupt-parent = <&gpio2>;
> +		interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> +	};
> +

    This line is hardly needed...

> +};

MBR, Sergei

Re: [PATCH/RFC v3 3/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X

[Simon Horman]

On Fri, Sep 18, 2015 at 03:58:27PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 9/18/2015 9:05 AM, Simon Horman wrote:
> 
> >From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> >
> >Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> >[horms: minor updates]
> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> 
> [...]
> 
> >diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> >index 5bae2cc0c61e..4fb141230f0c 100644
> >--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> >+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> [...]
> >@@ -56,3 +61,31 @@
> >
> >  	status = "okay";
> >  };
> >+
> >+&avb {
> >+	pinctrl-0 = <&avb_pins>;
> >+	pinctrl-names = "default";
> >+	renesas,no-ether-link;
> >+	phy-reset-gpio = <&gpio2 10 0>;
> 
>    Undocumented prop. You were going to delete it from the binding example.

Thanks and sorry for letting that slip through a second time.