public inbox for linux-sh@vger.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v5 09/14] ARM: shmobile: koelsch: Enable DU device in DT
Date: Fri, 25 Dec 2015 23:45:55 +0000	[thread overview]
Message-ID: <567DD533.7000001@cogentembedded.com> (raw)
In-Reply-To: <1414332679-15497-10-git-send-email-laurent.pinchart+renesas@ideasonboard.com>

Hello.

On 12/24/2015 10:54 PM, Sergei Shtylyov wrote:

>> Specify the DU output topology, enable the DU device and configure the
>> related pins.
>>
>> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>> ---
>>   arch/arm/boot/dts/r8a7791-koelsch.dts | 16 +++++++++++++---
>>   1 file changed, 13 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts
>> b/arch/arm/boot/dts/r8a7791-koelsch.dts
>> index 53184637f160..0402c498b05b 100644
>> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
>> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
>> @@ -212,14 +212,24 @@
>>       };
>>   };
>>
>> +&du {
>> +    pinctrl-0 = <&du_pins>;
>> +    pinctrl-names = "default";
>> +    status = "okay";
>> +
>> +    ports {
>> +        port@1 {
>> +            lvds_connector: endpoint {
>
>     I don't understand what this unreferenced label achieves. Also, the
> Koelsch schematics tells me LVDS is connected to DU0, not DU1...

    OK, figured it out now! However in the absence of #include for a LCD panel 
this still makes little sense.

> [...]

MBR, Sergei


  parent reply	other threads:[~2015-12-25 23:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-26 14:11 [PATCH v5 09/14] ARM: shmobile: koelsch: Enable DU device in DT Laurent Pinchart
2015-12-24 19:54 ` Sergei Shtylyov
2015-12-25 23:45 ` Sergei Shtylyov [this message]
2015-12-26 10:53 ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=567DD533.7000001@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox