From: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 01/10] ARM: shmobile: r8a7790: add DVC support on DTSI
Date: Thu, 19 Jun 2014 00:52:54 +0000 [thread overview]
Message-ID: <87sin190uv.wl%kuninori.morimoto.gx@gmail.com> (raw)
In-Reply-To: <878uouy3zl.wl%kuninori.morimoto.gx@renesas.com>
Hi Geert
Thank you for your feedback
> > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> > index df59707..493762d 100644
> > --- a/arch/arm/boot/dts/r8a7790.dtsi
> > +++ b/arch/arm/boot/dts/r8a7790.dtsi
> > @@ -1114,16 +1114,23 @@
>
> You forgot to add 2 entries to "clocks" above.
>
> > <&mstp10_clks R8A7790_CLK_SCU_SRC5>, <&mstp10_clks R8A7790_CLK_SCU_SRC4>,
> > <&mstp10_clks R8A7790_CLK_SCU_SRC3>, <&mstp10_clks R8A7790_CLK_SCU_SRC2>,
> > <&mstp10_clks R8A7790_CLK_SCU_SRC1>, <&mstp10_clks R8A7790_CLK_SCU_SRC0>,
> > + <&mstp10_clks R8A7790_CLK_SCU_DVC0>, <&mstp10_clks R8A7790_CLK_SCU_DVC1>,
> > <&audio_clk_a>, <&audio_clk_b>, <&audio_clk_c>, <&m2_clk>;
> > clock-names = "ssi-all",
> > "ssi.9", "ssi.8", "ssi.7", "ssi.6", "ssi.5",
> > "ssi.4", "ssi.3", "ssi.2", "ssi.1", "ssi.0",
> > "src.9", "src.8", "src.7", "src.6", "src.5",
> > "src.4", "src.3", "src.2", "src.1", "src.0",
>
> The above don't match with the version in renesas-devel-v3.15-20140616,
> which has "scu-all", and "scu-src.*".
>
> > + "dvc.0", "dvc.1",
>
> Oh, they're already there, as "scu-dvc*", since
>
> commit 78a29b8be588ecf7b2a7ee8d2b7e12f325730caa
> Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Date: Tue Jun 10 23:53:27 2014 -0700
>
> ARM: shmobile: r8a7790: add MSTP10 support on DTSI
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
>
> > "clk_a", "clk_b", "clk_c", "clk_i";
I guess,
above patch (78a29b8be588ecf7b2a7ee8d2b7e12f325730caa) adds
"MSTP10 entries" to r8a7790.dtsi.
This patch adds DVC entries to "sound node"
which didn't have it.
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2014-06-19 0:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 9:13 [PATCH 01/10] ARM: shmobile: r8a7790: add DVC support on DTSI Kuninori Morimoto
2014-06-18 10:28 ` Geert Uytterhoeven
2014-06-19 0:52 ` Kuninori Morimoto [this message]
2014-06-19 7:45 ` Geert Uytterhoeven
2014-06-19 8:05 ` Simon Horman
2014-06-19 9:26 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sin190uv.wl%kuninori.morimoto.gx@gmail.com \
--to=kuninori.morimoto.gx@gmail.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox