* [PATCH 01/10] ARM: shmobile: r8a7790: add DVC support on DTSI
@ 2014-06-18 9:13 Kuninori Morimoto
2014-06-18 10:28 ` Geert Uytterhoeven
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Kuninori Morimoto @ 2014-06-18 9:13 UTC (permalink / raw)
To: linux-sh
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
arch/arm/boot/dts/r8a7790.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index df59707..493762d 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -1114,16 +1114,23 @@
<&mstp10_clks R8A7790_CLK_SCU_SRC5>, <&mstp10_clks R8A7790_CLK_SCU_SRC4>,
<&mstp10_clks R8A7790_CLK_SCU_SRC3>, <&mstp10_clks R8A7790_CLK_SCU_SRC2>,
<&mstp10_clks R8A7790_CLK_SCU_SRC1>, <&mstp10_clks R8A7790_CLK_SCU_SRC0>,
+ <&mstp10_clks R8A7790_CLK_SCU_DVC0>, <&mstp10_clks R8A7790_CLK_SCU_DVC1>,
<&audio_clk_a>, <&audio_clk_b>, <&audio_clk_c>, <&m2_clk>;
clock-names = "ssi-all",
"ssi.9", "ssi.8", "ssi.7", "ssi.6", "ssi.5",
"ssi.4", "ssi.3", "ssi.2", "ssi.1", "ssi.0",
"src.9", "src.8", "src.7", "src.6", "src.5",
"src.4", "src.3", "src.2", "src.1", "src.0",
+ "dvc.0", "dvc.1",
"clk_a", "clk_b", "clk_c", "clk_i";
status = "disabled";
+ rcar_sound,dvc {
+ dvc0: dvc@0 { };
+ dvc1: dvc@1 { };
+ };
+
rcar_sound,src {
src0: src@0 { };
src1: src@1 { };
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 01/10] ARM: shmobile: r8a7790: add DVC support on DTSI
2014-06-18 9:13 [PATCH 01/10] ARM: shmobile: r8a7790: add DVC support on DTSI Kuninori Morimoto
@ 2014-06-18 10:28 ` Geert Uytterhoeven
2014-06-19 0:52 ` Kuninori Morimoto
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2014-06-18 10:28 UTC (permalink / raw)
To: linux-sh
Hi Morimoto-san,
On Wed, Jun 18, 2014 at 11:13 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index df59707..493762d 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -1114,16 +1114,23 @@
You forgot to add 2 entries to "clocks" above.
> <&mstp10_clks R8A7790_CLK_SCU_SRC5>, <&mstp10_clks R8A7790_CLK_SCU_SRC4>,
> <&mstp10_clks R8A7790_CLK_SCU_SRC3>, <&mstp10_clks R8A7790_CLK_SCU_SRC2>,
> <&mstp10_clks R8A7790_CLK_SCU_SRC1>, <&mstp10_clks R8A7790_CLK_SCU_SRC0>,
> + <&mstp10_clks R8A7790_CLK_SCU_DVC0>, <&mstp10_clks R8A7790_CLK_SCU_DVC1>,
> <&audio_clk_a>, <&audio_clk_b>, <&audio_clk_c>, <&m2_clk>;
> clock-names = "ssi-all",
> "ssi.9", "ssi.8", "ssi.7", "ssi.6", "ssi.5",
> "ssi.4", "ssi.3", "ssi.2", "ssi.1", "ssi.0",
> "src.9", "src.8", "src.7", "src.6", "src.5",
> "src.4", "src.3", "src.2", "src.1", "src.0",
The above don't match with the version in renesas-devel-v3.15-20140616,
which has "scu-all", and "scu-src.*".
> + "dvc.0", "dvc.1",
Oh, they're already there, as "scu-dvc*", since
commit 78a29b8be588ecf7b2a7ee8d2b7e12f325730caa
Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date: Tue Jun 10 23:53:27 2014 -0700
ARM: shmobile: r8a7790: add MSTP10 support on DTSI
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> "clk_a", "clk_b", "clk_c", "clk_i";
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 01/10] ARM: shmobile: r8a7790: add DVC support on DTSI
2014-06-18 9:13 [PATCH 01/10] ARM: shmobile: r8a7790: add DVC support on DTSI Kuninori Morimoto
2014-06-18 10:28 ` Geert Uytterhoeven
@ 2014-06-19 0:52 ` Kuninori Morimoto
2014-06-19 7:45 ` Geert Uytterhoeven
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Kuninori Morimoto @ 2014-06-19 0:52 UTC (permalink / raw)
To: linux-sh
Hi Geert
Thank you for your feedback
> > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> > index df59707..493762d 100644
> > --- a/arch/arm/boot/dts/r8a7790.dtsi
> > +++ b/arch/arm/boot/dts/r8a7790.dtsi
> > @@ -1114,16 +1114,23 @@
>
> You forgot to add 2 entries to "clocks" above.
>
> > <&mstp10_clks R8A7790_CLK_SCU_SRC5>, <&mstp10_clks R8A7790_CLK_SCU_SRC4>,
> > <&mstp10_clks R8A7790_CLK_SCU_SRC3>, <&mstp10_clks R8A7790_CLK_SCU_SRC2>,
> > <&mstp10_clks R8A7790_CLK_SCU_SRC1>, <&mstp10_clks R8A7790_CLK_SCU_SRC0>,
> > + <&mstp10_clks R8A7790_CLK_SCU_DVC0>, <&mstp10_clks R8A7790_CLK_SCU_DVC1>,
> > <&audio_clk_a>, <&audio_clk_b>, <&audio_clk_c>, <&m2_clk>;
> > clock-names = "ssi-all",
> > "ssi.9", "ssi.8", "ssi.7", "ssi.6", "ssi.5",
> > "ssi.4", "ssi.3", "ssi.2", "ssi.1", "ssi.0",
> > "src.9", "src.8", "src.7", "src.6", "src.5",
> > "src.4", "src.3", "src.2", "src.1", "src.0",
>
> The above don't match with the version in renesas-devel-v3.15-20140616,
> which has "scu-all", and "scu-src.*".
>
> > + "dvc.0", "dvc.1",
>
> Oh, they're already there, as "scu-dvc*", since
>
> commit 78a29b8be588ecf7b2a7ee8d2b7e12f325730caa
> Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Date: Tue Jun 10 23:53:27 2014 -0700
>
> ARM: shmobile: r8a7790: add MSTP10 support on DTSI
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
>
> > "clk_a", "clk_b", "clk_c", "clk_i";
I guess,
above patch (78a29b8be588ecf7b2a7ee8d2b7e12f325730caa) adds
"MSTP10 entries" to r8a7790.dtsi.
This patch adds DVC entries to "sound node"
which didn't have it.
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 01/10] ARM: shmobile: r8a7790: add DVC support on DTSI
2014-06-18 9:13 [PATCH 01/10] ARM: shmobile: r8a7790: add DVC support on DTSI Kuninori Morimoto
2014-06-18 10:28 ` Geert Uytterhoeven
2014-06-19 0:52 ` Kuninori Morimoto
@ 2014-06-19 7:45 ` Geert Uytterhoeven
2014-06-19 8:05 ` Simon Horman
2014-06-19 9:26 ` Kuninori Morimoto
4 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2014-06-19 7:45 UTC (permalink / raw)
To: linux-sh
Hi Morimoto-san,
On Thu, Jun 19, 2014 at 2:52 AM, Kuninori Morimoto
<kuninori.morimoto.gx@gmail.com> wrote:
> Thank you for your feedback
>
>> > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>> > index df59707..493762d 100644
>> > --- a/arch/arm/boot/dts/r8a7790.dtsi
>> > +++ b/arch/arm/boot/dts/r8a7790.dtsi
>> > @@ -1114,16 +1114,23 @@
>>
>> You forgot to add 2 entries to "clocks" above.
>>
>> > <&mstp10_clks R8A7790_CLK_SCU_SRC5>, <&mstp10_clks R8A7790_CLK_SCU_SRC4>,
>> > <&mstp10_clks R8A7790_CLK_SCU_SRC3>, <&mstp10_clks R8A7790_CLK_SCU_SRC2>,
>> > <&mstp10_clks R8A7790_CLK_SCU_SRC1>, <&mstp10_clks R8A7790_CLK_SCU_SRC0>,
>> > + <&mstp10_clks R8A7790_CLK_SCU_DVC0>, <&mstp10_clks R8A7790_CLK_SCU_DVC1>,
>> > <&audio_clk_a>, <&audio_clk_b>, <&audio_clk_c>, <&m2_clk>;
>> > clock-names = "ssi-all",
>> > "ssi.9", "ssi.8", "ssi.7", "ssi.6", "ssi.5",
>> > "ssi.4", "ssi.3", "ssi.2", "ssi.1", "ssi.0",
>> > "src.9", "src.8", "src.7", "src.6", "src.5",
>> > "src.4", "src.3", "src.2", "src.1", "src.0",
>>
>> The above don't match with the version in renesas-devel-v3.15-20140616,
>> which has "scu-all", and "scu-src.*".
>>
>> > + "dvc.0", "dvc.1",
>>
>> Oh, they're already there, as "scu-dvc*", since
>>
>> commit 78a29b8be588ecf7b2a7ee8d2b7e12f325730caa
>> Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>> Date: Tue Jun 10 23:53:27 2014 -0700
>>
>> ARM: shmobile: r8a7790: add MSTP10 support on DTSI
>>
>> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>>
>>
>> > "clk_a", "clk_b", "clk_c", "clk_i";
>
> I guess,
> above patch (78a29b8be588ecf7b2a7ee8d2b7e12f325730caa) adds
> "MSTP10 entries" to r8a7790.dtsi.
> This patch adds DVC entries to "sound node"
> which didn't have it.
Bummer. Too much identical context in DTS files, confusing human beings
(and sometimes patch/git am)...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 01/10] ARM: shmobile: r8a7790: add DVC support on DTSI
2014-06-18 9:13 [PATCH 01/10] ARM: shmobile: r8a7790: add DVC support on DTSI Kuninori Morimoto
` (2 preceding siblings ...)
2014-06-19 7:45 ` Geert Uytterhoeven
@ 2014-06-19 8:05 ` Simon Horman
2014-06-19 9:26 ` Kuninori Morimoto
4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2014-06-19 8:05 UTC (permalink / raw)
To: linux-sh
On Thu, Jun 19, 2014 at 09:45:12AM +0200, Geert Uytterhoeven wrote:
> Hi Morimoto-san,
>
> On Thu, Jun 19, 2014 at 2:52 AM, Kuninori Morimoto
> <kuninori.morimoto.gx@gmail.com> wrote:
> > Thank you for your feedback
> >
> >> > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> >> > index df59707..493762d 100644
> >> > --- a/arch/arm/boot/dts/r8a7790.dtsi
> >> > +++ b/arch/arm/boot/dts/r8a7790.dtsi
> >> > @@ -1114,16 +1114,23 @@
> >>
> >> You forgot to add 2 entries to "clocks" above.
> >>
> >> > <&mstp10_clks R8A7790_CLK_SCU_SRC5>, <&mstp10_clks R8A7790_CLK_SCU_SRC4>,
> >> > <&mstp10_clks R8A7790_CLK_SCU_SRC3>, <&mstp10_clks R8A7790_CLK_SCU_SRC2>,
> >> > <&mstp10_clks R8A7790_CLK_SCU_SRC1>, <&mstp10_clks R8A7790_CLK_SCU_SRC0>,
> >> > + <&mstp10_clks R8A7790_CLK_SCU_DVC0>, <&mstp10_clks R8A7790_CLK_SCU_DVC1>,
> >> > <&audio_clk_a>, <&audio_clk_b>, <&audio_clk_c>, <&m2_clk>;
> >> > clock-names = "ssi-all",
> >> > "ssi.9", "ssi.8", "ssi.7", "ssi.6", "ssi.5",
> >> > "ssi.4", "ssi.3", "ssi.2", "ssi.1", "ssi.0",
> >> > "src.9", "src.8", "src.7", "src.6", "src.5",
> >> > "src.4", "src.3", "src.2", "src.1", "src.0",
> >>
> >> The above don't match with the version in renesas-devel-v3.15-20140616,
> >> which has "scu-all", and "scu-src.*".
> >>
> >> > + "dvc.0", "dvc.1",
> >>
> >> Oh, they're already there, as "scu-dvc*", since
> >>
> >> commit 78a29b8be588ecf7b2a7ee8d2b7e12f325730caa
> >> Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >> Date: Tue Jun 10 23:53:27 2014 -0700
> >>
> >> ARM: shmobile: r8a7790: add MSTP10 support on DTSI
> >>
> >> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >>
> >>
> >> > "clk_a", "clk_b", "clk_c", "clk_i";
> >
> > I guess,
> > above patch (78a29b8be588ecf7b2a7ee8d2b7e12f325730caa) adds
> > "MSTP10 entries" to r8a7790.dtsi.
> > This patch adds DVC entries to "sound node"
> > which didn't have it.
>
> Bummer. Too much identical context in DTS files, confusing human beings
> (and sometimes patch/git am)...
It happens. Please let me know if there is anything I can do to help.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 01/10] ARM: shmobile: r8a7790: add DVC support on DTSI
2014-06-18 9:13 [PATCH 01/10] ARM: shmobile: r8a7790: add DVC support on DTSI Kuninori Morimoto
` (3 preceding siblings ...)
2014-06-19 8:05 ` Simon Horman
@ 2014-06-19 9:26 ` Kuninori Morimoto
4 siblings, 0 replies; 6+ messages in thread
From: Kuninori Morimoto @ 2014-06-19 9:26 UTC (permalink / raw)
To: linux-sh
Hi Simon, Geert
> > > I guess,
> > > above patch (78a29b8be588ecf7b2a7ee8d2b7e12f325730caa) adds
> > > "MSTP10 entries" to r8a7790.dtsi.
> > > This patch adds DVC entries to "sound node"
> > > which didn't have it.
> >
> > Bummer. Too much identical context in DTS files, confusing human beings
> > (and sometimes patch/git am)...
>
> It happens. Please let me know if there is anything I can do to help.
Sorry, this patch title itself was very confusable.
So, how about this ?
- ARM: shmobile: r8a7790: add DVC support on DTSI
+ ARM: shmobile: r8a7790: add DVC support to sound node on DTSI
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-06-19 9:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-18 9:13 [PATCH 01/10] ARM: shmobile: r8a7790: add DVC support on DTSI Kuninori Morimoto
2014-06-18 10:28 ` Geert Uytterhoeven
2014-06-19 0:52 ` Kuninori Morimoto
2014-06-19 7:45 ` Geert Uytterhoeven
2014-06-19 8:05 ` Simon Horman
2014-06-19 9:26 ` Kuninori Morimoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox