From: Chris Ball <cjb@laptop.org>
To: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-mmc@vger.kernel.org, yusuke.goda.sx@renesas.com,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Paul Mundt <lethal@linux-sh.org>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [PATCH] mmc: sh-mmcif: properly handle MMC_WRITE_MULTIPLE_BLOCK completion IRQ
Date: Wed, 19 Sep 2012 06:25:41 +0000 [thread overview]
Message-ID: <m37grqil5m.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <505932E9.8050202@kmckk.co.jp> (Tetsuyuki Kobayashi's message of "Wed, 19 Sep 2012 11:50:17 +0900")
Hi,
On Tue, Sep 18 2012, Tetsuyuki Kobayashi wrote:
> (2012/09/19 8:10), Guennadi Liakhovetski wrote:
>> Upon completion of a MMC_WRITE_MULTIPLE_BLOCK command MMCIF issues an IRQ
>> with the DTRANE bit set and often with one or several of CMD12 bits set.
>> If those interrupts are not acknowledged, an additional interrupt can be
>> produced and will be delivered later, possibly, when the transaction has
>> already been completed. To prevent this from happening, CMD12 completion
>> interrupt sources have to be cleared too upon reception of an DTRANE IRQ.
>>
>> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>> ---
>>
>> Tested on kzm9g and mackerel. Kobayashi-san, this fixes spurious
>> interrupts, that you are observing.
>
> I verified on kzm9g.
> This works with
> [PATCH] mmc: sh-mmcif: avoid Oops on spurious interrupts
>
> Tested-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
Thanks, pushed to mmc-next for 3.7.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2012-09-19 6:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 23:10 [PATCH] mmc: sh-mmcif: properly handle MMC_WRITE_MULTIPLE_BLOCK completion IRQ Guennadi Liakhovetski
2012-09-19 2:50 ` Tetsuyuki Kobayashi
2012-09-19 6:25 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37grqil5m.fsf@pullcord.laptop.org \
--to=cjb@laptop.org \
--cc=g.liakhovetski@gmx.de \
--cc=koba@kmckk.co.jp \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lethal@linux-sh.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=yusuke.goda.sx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox