Linux SNPS ARC Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vineet.Gupta1@synopsys.com (Vineet Gupta)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH v3 03/11] ARC: Allow irq threading
Date: Fri, 25 Aug 2017 13:45:06 -0700	[thread overview]
Message-ID: <12582c31-9ff0-708c-5c85-1e31efd2a170@synopsys.com> (raw)
In-Reply-To: <1497516241-16446-4-git-send-email-noamca@mellanox.com>

+CC Peter, Tglx, Steven

On 06/15/2017 01:43 AM, Noam Camus wrote:
> From: Noam Camus <noamc at ezchip.com>
> 
> Working with NPS400 we noticed that there is a possibility of L1
> interrupt nesting that may run out kernel stack.
> The scenario include serving invoke_softirqs() from irq_exit()
> and once local_irq_enable() called can hit another one before we
> managed to restore last one and pop some place from kernel stack.
> 
> Serving softirqs at dedicated kernel thread may mitigate this.
> We see that many architectures, including x86, behave like this.
> 
> Note 1: All interrupts which must be non threaded
> should be marked IRQF_NO_THREAD.
> Note 2: using kernel param "threadirqs" is needed to actually
> turn this on. This configuration is only a preperation.
> 
> Signed-off-by: Noam Camus <noamc at ezchip.com>
> ---
>   arch/arc/Kconfig |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig
> index a545969..f464f97 100644
> --- a/arch/arc/Kconfig
> +++ b/arch/arc/Kconfig
> @@ -33,6 +33,7 @@ config ARC
>   	select HAVE_OPROFILE
>   	select HAVE_PERF_EVENTS
>   	select HANDLE_DOMAIN_IRQ
> +	select IRQ_FORCED_THREADING
>   	select IRQ_DOMAIN
>   	select MODULES_USE_ELF_RELA
>   	select NO_BOOTMEM> 

As Noam notes above and looking at work needed in other arches prior to switching 
to this: we need mark the low level ints as NO_THREAD.

ARC ipi, timer, perf interrupts happen to use request_percpu_irq() which doesn't 
take flags and doesn't seem to force NO_THREAD internally either. Does that mean 
we first need to convert all of these sites to __request_percpu_irq(.. NO_THREAD 
...) or is there a better way of doing this !

Thx,
-Vineet

  reply	other threads:[~2017-08-25 20:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-15  8:43 [PATCH v3 00/11] plat-eznps upstream cont. set 2 Noam Camus
2017-06-15  8:43 ` [PATCH v3 01/11] ARC: set level of log per CPU during boot to be info level Noam Camus
2017-06-15  8:43 ` [PATCH v3 02/11] ARC: send ipi to all cpus sharing task mm in case of page fault Noam Camus
2017-06-15  8:43 ` [PATCH v3 03/11] ARC: Allow irq threading Noam Camus
2017-08-25 20:45   ` Vineet Gupta [this message]
2017-08-25 20:59     ` Thomas Gleixner
2017-08-25 21:02       ` Thomas Gleixner
2017-06-15  8:43 ` [PATCH v3 04/11] ARC: Add CPU topology Noam Camus
2017-06-15  8:43 ` [PATCH v3 05/11] ARC: Support more than one PGDIR for KVADDR Noam Camus
2017-06-15  8:43 ` [PATCH v3 06/11] ARC: [NUMA] added CONFIG_NUMA for plat-eznps Noam Camus
2017-06-15  8:43 ` [PATCH v3 07/11] ARC: [plat-eznps] new command line argument for HW scheduler at MTM Noam Camus
2017-08-21 17:04   ` Vineet Gupta
2017-08-22  6:16     ` Noam Camus
2017-06-15  8:43 ` [PATCH v3 08/11] ARC: [plat-eznps] Update the init sequence of aux regs per cpu Noam Camus
2017-06-15  8:43 ` [PATCH v3 09/11] ARC: [plat-eznps] Save/Restore extra auxiliary registers Noam Camus
2017-06-15  8:44 ` [PATCH v3 10/11] ARC: [plat-eznps] handle dedicated AUX registers Noam Camus
2017-06-15  8:44 ` [PATCH v3 11/11] ARC: [plat-eznps] avoid toggling of DPC register Noam Camus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12582c31-9ff0-708c-5c85-1e31efd2a170@synopsys.com \
    --to=vineet.gupta1@synopsys.com \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox