Linux SNPS ARC Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 19/20] ARC: Fix malformed ARC_EMUL_UNALIGNED default
       [not found] <20180205012146.23981-1-ulfalizer@gmail.com>
@ 2018-02-05  1:21 ` Ulf Magnusson
  2018-02-05 17:17   ` Vineet Gupta
  0 siblings, 1 reply; 2+ messages in thread
From: Ulf Magnusson @ 2018-02-05  1:21 UTC (permalink / raw)
  To: linux-snps-arc

'default N' should be 'default n', though they happen to have the same
effect here, due to undefined symbols (N in this case) evaluating to n
in a tristate sense.

Remove the default from ARC_EMUL_UNALIGNED instead of changing it. bool
and tristate symbols implicitly default to n.

Discovered with the
https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
script.

Signed-off-by: Ulf Magnusson <ulfalizer at gmail.com>
---
 arch/arc/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig
index f3a80cf164cc..d76bf4a83740 100644
--- a/arch/arc/Kconfig
+++ b/arch/arc/Kconfig
@@ -484,7 +484,6 @@ config ARC_CURR_IN_REG
 
 config ARC_EMUL_UNALIGNED
 	bool "Emulate unaligned memory access (userspace only)"
-	default N
 	select SYSCTL_ARCH_UNALIGN_NO_WARN
 	select SYSCTL_ARCH_UNALIGN_ALLOW
 	depends on ISA_ARCOMPACT
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH 19/20] ARC: Fix malformed ARC_EMUL_UNALIGNED default
  2018-02-05  1:21 ` [PATCH 19/20] ARC: Fix malformed ARC_EMUL_UNALIGNED default Ulf Magnusson
@ 2018-02-05 17:17   ` Vineet Gupta
  0 siblings, 0 replies; 2+ messages in thread
From: Vineet Gupta @ 2018-02-05 17:17 UTC (permalink / raw)
  To: linux-snps-arc

On 02/04/2018 05:21 PM, Ulf Magnusson wrote:
> 'default N' should be 'default n', though they happen to have the same
> effect here, due to undefined symbols (N in this case) evaluating to n
> in a tristate sense.
> 
> Remove the default from ARC_EMUL_UNALIGNED instead of changing it. bool
> and tristate symbols implicitly default to n.
> 
> Discovered with the
> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> script.
> 
> Signed-off-by: Ulf Magnusson <ulfalizer at gmail.com>


Added to ARC for-curr.

Thx,
-Vineet

> ---
>   arch/arc/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig
> index f3a80cf164cc..d76bf4a83740 100644
> --- a/arch/arc/Kconfig
> +++ b/arch/arc/Kconfig
> @@ -484,7 +484,6 @@ config ARC_CURR_IN_REG
>   
>   config ARC_EMUL_UNALIGNED
>   	bool "Emulate unaligned memory access (userspace only)"
> -	default N
>   	select SYSCTL_ARCH_UNALIGN_NO_WARN
>   	select SYSCTL_ARCH_UNALIGN_ALLOW
>   	depends on ISA_ARCOMPACT
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-02-05 17:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20180205012146.23981-1-ulfalizer@gmail.com>
2018-02-05  1:21 ` [PATCH 19/20] ARC: Fix malformed ARC_EMUL_UNALIGNED default Ulf Magnusson
2018-02-05 17:17   ` Vineet Gupta

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox