* [PATCH] DRM: UDL: get rid of useless vblank initialization
@ 2018-09-28 14:41 Eugeniy Paltsev
2018-10-01 8:14 ` Daniel Vetter
2018-10-23 11:01 ` Eugeniy Paltsev
0 siblings, 2 replies; 4+ messages in thread
From: Eugeniy Paltsev @ 2018-09-28 14:41 UTC (permalink / raw)
To: linux-snps-arc
UDL doesn't support vblank functionality so we don't need to
initialize vblank here (we are able to send page flip
completion events even without vblank initialization)
Moreover current drm_vblank_init call with num_crtcs > 0 causes
sending DRM_EVENT_FLIP_COMPLETE event with zero timestamp every
time. This breaks userspace apps (for example weston) which
relies on timestamp value.
Cc: stable at vger.kernel.org
Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com>
---
drivers/gpu/drm/udl/udl_main.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c
index f455f095a146..1b014d92855b 100644
--- a/drivers/gpu/drm/udl/udl_main.c
+++ b/drivers/gpu/drm/udl/udl_main.c
@@ -350,15 +350,10 @@ int udl_driver_load(struct drm_device *dev, unsigned long flags)
if (ret)
goto err;
- ret = drm_vblank_init(dev, 1);
- if (ret)
- goto err_fb;
-
drm_kms_helper_poll_init(dev);
return 0;
-err_fb:
- udl_fbdev_cleanup(dev);
+
err:
if (udl->urbs.count)
udl_free_urb_list(dev);
--
2.14.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] DRM: UDL: get rid of useless vblank initialization
2018-09-28 14:41 [PATCH] DRM: UDL: get rid of useless vblank initialization Eugeniy Paltsev
@ 2018-10-01 8:14 ` Daniel Vetter
2018-10-23 11:01 ` Eugeniy Paltsev
1 sibling, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2018-10-01 8:14 UTC (permalink / raw)
To: linux-snps-arc
On Fri, Sep 28, 2018@05:41:26PM +0300, Eugeniy Paltsev wrote:
> UDL doesn't support vblank functionality so we don't need to
> initialize vblank here (we are able to send page flip
> completion events even without vblank initialization)
>
> Moreover current drm_vblank_init call with num_crtcs > 0 causes
> sending DRM_EVENT_FLIP_COMPLETE event with zero timestamp every
> time. This breaks userspace apps (for example weston) which
> relies on timestamp value.
>
> Cc: stable at vger.kernel.org
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com>
Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> ---
> drivers/gpu/drm/udl/udl_main.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c
> index f455f095a146..1b014d92855b 100644
> --- a/drivers/gpu/drm/udl/udl_main.c
> +++ b/drivers/gpu/drm/udl/udl_main.c
> @@ -350,15 +350,10 @@ int udl_driver_load(struct drm_device *dev, unsigned long flags)
> if (ret)
> goto err;
>
> - ret = drm_vblank_init(dev, 1);
> - if (ret)
> - goto err_fb;
> -
> drm_kms_helper_poll_init(dev);
>
> return 0;
> -err_fb:
> - udl_fbdev_cleanup(dev);
> +
> err:
> if (udl->urbs.count)
> udl_free_urb_list(dev);
> --
> 2.14.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] DRM: UDL: get rid of useless vblank initialization
2018-09-28 14:41 [PATCH] DRM: UDL: get rid of useless vblank initialization Eugeniy Paltsev
2018-10-01 8:14 ` Daniel Vetter
@ 2018-10-23 11:01 ` Eugeniy Paltsev
2018-10-23 13:42 ` Daniel Vetter
1 sibling, 1 reply; 4+ messages in thread
From: Eugeniy Paltsev @ 2018-10-23 11:01 UTC (permalink / raw)
To: linux-snps-arc
Hi David,
Maybe you have any comments or remarks about this patch?
And if you don't could you please apply it. Thanks!
On Fri, 2018-09-28@17:41 +0300, Eugeniy Paltsev wrote:
> UDL doesn't support vblank functionality so we don't need to
> initialize vblank here (we are able to send page flip
> completion events even without vblank initialization)
>
> Moreover current drm_vblank_init call with num_crtcs > 0 causes
> sending DRM_EVENT_FLIP_COMPLETE event with zero timestamp every
> time. This breaks userspace apps (for example weston) which
> relies on timestamp value.
>
> Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> Cc: stable at vger.kernel.org
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com>
> ---
> drivers/gpu/drm/udl/udl_main.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c
> index f455f095a146..1b014d92855b 100644
> --- a/drivers/gpu/drm/udl/udl_main.c
> +++ b/drivers/gpu/drm/udl/udl_main.c
> @@ -350,15 +350,10 @@ int udl_driver_load(struct drm_device *dev, unsigned long flags)
> if (ret)
> goto err;
>
> - ret = drm_vblank_init(dev, 1);
> - if (ret)
> - goto err_fb;
> -
> drm_kms_helper_poll_init(dev);
>
> return 0;
> -err_fb:
> - udl_fbdev_cleanup(dev);
> +
> err:
> if (udl->urbs.count)
> udl_free_urb_list(dev);
--
Eugeniy Paltsev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] DRM: UDL: get rid of useless vblank initialization
2018-10-23 11:01 ` Eugeniy Paltsev
@ 2018-10-23 13:42 ` Daniel Vetter
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2018-10-23 13:42 UTC (permalink / raw)
To: linux-snps-arc
On Tue, Oct 23, 2018@11:01:14AM +0000, Eugeniy Paltsev wrote:
> Hi David,
>
> Maybe you have any comments or remarks about this patch?
> And if you don't could you please apply it. Thanks!
Hm I hoped Sean would pick this up. I stuffed it into drm-misc-next now,
and Sean owes me one. Generally pinging Dave is a last resort in dri-devel
(and doesn't work too well).
Thanks for your patch.
-Daniel
>
> On Fri, 2018-09-28@17:41 +0300, Eugeniy Paltsev wrote:
> > UDL doesn't support vblank functionality so we don't need to
> > initialize vblank here (we are able to send page flip
> > completion events even without vblank initialization)
> >
> > Moreover current drm_vblank_init call with num_crtcs > 0 causes
> > sending DRM_EVENT_FLIP_COMPLETE event with zero timestamp every
> > time. This breaks userspace apps (for example weston) which
> > relies on timestamp value.
> >
> > Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> > Cc: stable at vger.kernel.org
> > Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com>
> > ---
> > drivers/gpu/drm/udl/udl_main.c | 7 +------
> > 1 file changed, 1 insertion(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c
> > index f455f095a146..1b014d92855b 100644
> > --- a/drivers/gpu/drm/udl/udl_main.c
> > +++ b/drivers/gpu/drm/udl/udl_main.c
> > @@ -350,15 +350,10 @@ int udl_driver_load(struct drm_device *dev, unsigned long flags)
> > if (ret)
> > goto err;
> >
> > - ret = drm_vblank_init(dev, 1);
> > - if (ret)
> > - goto err_fb;
> > -
> > drm_kms_helper_poll_init(dev);
> >
> > return 0;
> > -err_fb:
> > - udl_fbdev_cleanup(dev);
> > +
> > err:
> > if (udl->urbs.count)
> > udl_free_urb_list(dev);
> --
> Eugeniy Paltsev
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-23 13:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-28 14:41 [PATCH] DRM: UDL: get rid of useless vblank initialization Eugeniy Paltsev
2018-10-01 8:14 ` Daniel Vetter
2018-10-23 11:01 ` Eugeniy Paltsev
2018-10-23 13:42 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox