From: Lukasz Majewski <lukma@denx.de>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: Albert ARIBAUD <albert.aribaud@3adev.fr>,
arcml <linux-snps-arc@lists.infradead.org>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH 1/3] y2038: linux: Provide __futimes64 implementation
Date: Wed, 8 Jul 2020 08:58:57 +0200 [thread overview]
Message-ID: <20200708085857.22f7568f@jawa> (raw)
In-Reply-To: <d93d6c50-92e7-65aa-9ee8-990c7a036ef3@synopsys.com>
[-- Attachment #1.1: Type: text/plain, Size: 2524 bytes --]
Hi Vineet,
> On 7/7/20 12:21 AM, Lukasz Majewski wrote:
> >> ARC is 32-bit + TIMESIZE==64 but the new code is not getting built
> >> (instead generic variant is). How do I override the generic fiel to
> >> be built instead ?
> > The futimes.c from sysdeps/unix/sysv/linux/ shall be built.
> >
> > The futimes.c is defined in following locations:
> > y2038-glibc/misc
> > y2038-glibc/sysdeps/unix/sysv/linux
> > y2038-glibc/sysdeps/mach/hurd
> >
> > The first one is a stub. The last one is for hurd.
> > ARC shall use the middle one as well.
>
> It seems I mixed up the various *utime* files.
> Following are currently building for ARC
>
> sysdeps/unix/sysv/linux/generic/futimesat.c
> sysdeps/unix/sysv/linux/generic/utimes.c #2
>
> sysdeps/unix/sysv/linux/futimes.c
> sysdeps/unix/sysv/linux/futimens.c
> sysdeps/unix/sysv/linux/utimensat.c
>
> The issue is generic/utimes.c
>
> Is that the right file to build. If yes then it needs fixing as it
> expects __NR_utimensat (and thus require the aliasing hack in ARC
> sysdep.h)
>
> #define __NR_utimensat __NR_utimensat_time6
>
> P.S. I know glibc wiki has a bunch of pages (from Arnd?) for the
> y2038 support.
This wiki page was developed by Albert Aribaud and shall give you a
grasp about the work needed for Y2038 conversion.
However, it is now outdated as we already made some progress.
The most accurate list of supported/converted syscalls can be found
here:
https://github.com/lmajewski/y2038_glibc/commit/b94a7f1126dc5bd652ba3a856753e85e48a6e845
and the most up to date development branch for Y2038 conversion:
https://github.com/lmajewski/y2038_glibc/commits/y2038_edge
(I've sent yesterday a patch series to convert futex to futex_time64).
> Are there other (newer) docs which explain the whole
> song and dance or is it the usual RTFC.
>
> > When I'm in doubt (or when for example code is auto generated to
> > wrap a syscall) I do use
> > https://github.com/lmajewski/meta-y2038/blob/master/README
> >
> > with gdb to check which function is called. Maybe it would help you
> > too?
>
> Yeah. I typically use build logs to see which exact file is built and
> then objdump to corroborate.
Ok.
>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
prev parent reply other threads:[~2020-07-08 6:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200217131735.18180-1-lukma@denx.de>
[not found] ` <20200217131735.18180-2-lukma@denx.de>
2020-07-06 22:58 ` [PATCH 1/3] y2038: linux: Provide __futimes64 implementation Vineet Gupta
2020-07-07 7:21 ` Lukasz Majewski
2020-07-07 18:25 ` Vineet Gupta
2020-07-07 20:36 ` Joseph Myers
2020-07-08 6:58 ` Lukasz Majewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708085857.22f7568f@jawa \
--to=lukma@denx.de \
--cc=Vineet.Gupta1@synopsys.com \
--cc=albert.aribaud@3adev.fr \
--cc=libc-alpha@sourceware.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox