From: Joseph Myers <joseph@codesourcery.com>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: arcml <linux-snps-arc@lists.infradead.org>,
GNU C Library <libc-alpha@sourceware.org>,
Lukasz Majewski <lukma@denx.de>
Subject: Re: [PATCH 1/3] y2038: linux: Provide __futimes64 implementation
Date: Tue, 7 Jul 2020 20:36:02 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.2007072027450.16069@digraph.polyomino.org.uk> (raw)
In-Reply-To: <d93d6c50-92e7-65aa-9ee8-990c7a036ef3@synopsys.com>
On Tue, 7 Jul 2020, Vineet Gupta via Libc-alpha wrote:
> The issue is generic/utimes.c
>
> Is that the right file to build. If yes then it needs fixing as it expects
> __NR_utimensat (and thus require the aliasing hack in ARC sysdep.h)
It was the right file to build, back when sysdeps/unix/sysv/linux/utimes.c
required a utimes syscall to be present and architectures with the generic
syscall interface didn't gave one.
Now, there is nothing in sysdeps/unix/sysv/linux/utimes.c that wouldn't
work on asm-generic architectures. So generic/utimes.c should be removed.
Likewise, hppa/utimes.c should also be removed (now that
sysdeps/unix/sysv/linux/utimes.c doesn't use the utimes syscalls, it
doesn't matter than hppa got it late), and the __ASSUME_UTIMES definition
in sysdeps/unix/sysv/linux/hppa/kernel-features.h should also be removed
(because nothing will use it once the hppa utimes.c goes away).
Similarly, there is no longer a need for generic/futimesat.c so that can
go away as well.
--
Joseph S. Myers
joseph@codesourcery.com
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2020-07-07 20:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200217131735.18180-1-lukma@denx.de>
[not found] ` <20200217131735.18180-2-lukma@denx.de>
2020-07-06 22:58 ` [PATCH 1/3] y2038: linux: Provide __futimes64 implementation Vineet Gupta
2020-07-07 7:21 ` Lukasz Majewski
2020-07-07 18:25 ` Vineet Gupta
2020-07-07 20:36 ` Joseph Myers [this message]
2020-07-08 6:58 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2007072027450.16069@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=lukma@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox