From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Vineet Gupta <vgupta@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Carpenter <error27@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] bit_spinlock: Include <asm/processor.h>
Date: Tue, 10 Jan 2023 19:08:33 +0100 [thread overview]
Message-ID: <f4aa7f0d-50a9-b5e0-e980-1e8e779b48bc@wanadoo.fr> (raw)
In-Reply-To: <b5e0bd90-ff29-d301-30ca-2f12028109ce@kernel.org>
Le 10/01/2023 à 08:19, Vineet Gupta a écrit :
>
> On 1/8/23 11:04, Christophe JAILLET wrote:
>> In an attempt to simplify some includes in <include/dcache.h>, it
>> appeared, when compiling fs/ecryptfs/dentry.c, that
>> <linux/bit_spinlock.h>
>> was relying on other includes to get the definition of cpu_relax().
>> (see [1])
>>
>> It broke on arc.
>
> It its just ARC that broke, maybe we can do something there ?
Hi,
It is all what build-bots have spotted so far :)
I don't think that "fixing" it in ARC is the right approach, unless I
missed something.
<linux/bit_spinlock.h> does use cpu_relax(), so it should include what
is need for that, and not rely on other black magic.
CJ
>
>> Include <asm/processor.h> in <linux/bit_spinlock.h> to fix the issue.
>> This will help remove some un-needed includes from <include/dcache.h>.
>>
>> [1]: https://lore.kernel.org/all/202301082130.LXMj5qkD-lkp@intel.com/
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
>> Not sure who to send this to.
>> get_maintainer.pl is of no help, and the file is untouched from a too
>> long
>> time.
>>
>> Greg? Dan? Any pointer?
>> ---
>> include/linux/bit_spinlock.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/bit_spinlock.h b/include/linux/bit_spinlock.h
>> index bbc4730a6505..d0fd2a7afca2 100644
>> --- a/include/linux/bit_spinlock.h
>> +++ b/include/linux/bit_spinlock.h
>> @@ -2,6 +2,7 @@
>> #ifndef __LINUX_BIT_SPINLOCK_H
>> #define __LINUX_BIT_SPINLOCK_H
>> +#include <asm/processor.h>
>> #include <linux/kernel.h>
>> #include <linux/preempt.h>
>> #include <linux/atomic.h>
>
>
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2023-01-10 18:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-08 19:04 [PATCH] bit_spinlock: Include <asm/processor.h> Christophe JAILLET
2023-01-09 8:26 ` Dan Carpenter
2023-01-09 22:46 ` Andrew Morton
2023-01-10 7:19 ` Vineet Gupta
2023-01-10 18:08 ` Christophe JAILLET [this message]
2023-01-10 21:23 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4aa7f0d-50a9-b5e0-e980-1e8e779b48bc@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=akpm@linux-foundation.org \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=vgupta@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox