From: Andrew Morton <akpm@linux-foundation.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Vineet Gupta <vgupta@kernel.org>,
Dan Carpenter <error27@gmail.com>,
linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] bit_spinlock: Include <asm/processor.h>
Date: Mon, 9 Jan 2023 14:46:07 -0800 [thread overview]
Message-ID: <20230109144607.02edd319f9b5e25ee774f9a5@linux-foundation.org> (raw)
In-Reply-To: <8b81101d59a31f4927016c17e49be96754a23380.1673204461.git.christophe.jaillet@wanadoo.fr>
On Sun, 8 Jan 2023 20:04:44 +0100 Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> In an attempt to simplify some includes in <include/dcache.h>, it
> appeared, when compiling fs/ecryptfs/dentry.c, that <linux/bit_spinlock.h>
> was relying on other includes to get the definition of cpu_relax().
> (see [1])
>
> It broke on arc.
>
> Include <asm/processor.h> in <linux/bit_spinlock.h> to fix the issue.
> This will help remove some un-needed includes from <include/dcache.h>.
>
> [1]: https://lore.kernel.org/all/202301082130.LXMj5qkD-lkp@intel.com/
>
> ...
>
> --- a/include/linux/bit_spinlock.h
> +++ b/include/linux/bit_spinlock.h
> @@ -2,6 +2,7 @@
> #ifndef __LINUX_BIT_SPINLOCK_H
> #define __LINUX_BIT_SPINLOCK_H
>
> +#include <asm/processor.h>
> #include <linux/kernel.h>
> #include <linux/preempt.h>
> #include <linux/atomic.h>
linux/processor.h would be preferable, rather than diving straight into asm/?
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2023-01-09 22:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-08 19:04 [PATCH] bit_spinlock: Include <asm/processor.h> Christophe JAILLET
2023-01-09 8:26 ` Dan Carpenter
2023-01-09 22:46 ` Andrew Morton [this message]
2023-01-10 7:19 ` Vineet Gupta
2023-01-10 18:08 ` Christophe JAILLET
2023-01-10 21:23 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230109144607.02edd319f9b5e25ee774f9a5@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=vgupta@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox