[PATCH] ASoC: sn624x: use dev_err_probe() for the regmap failure

[PATCH] ASoC: sn624x: use dev_err_probe() for the regmap failure

[Aryan Sinha]

dev_err_probe() prints the symbolic errno and stays quiet on
 -EPROBE_DEFER. The sn624x prefix goes too, dev_err_probe() already prints the device name..

Signed-off-by: Aryan Sinha <sinha.aryan03@gmail.com>
---
 sound/soc/codecs/sn624x-sdca-sdw.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/sound/soc/codecs/sn624x-sdca-sdw.c b/sound/soc/codecs/sn624x-sdca-sdw.c
index c9e690482..1a83f0a11 100644
--- a/sound/soc/codecs/sn624x-sdca-sdw.c
+++ b/sound/soc/codecs/sn624x-sdca-sdw.c
@@ -1736,11 +1736,9 @@ static int sn624x_sdca_sdw_probe(struct sdw_slave *slave,
 	regmap = devm_regmap_init_sdw_mbq_cfg(&slave->dev, slave,
 					      &sn624x_sdca_regmap,
 					      &sn624x_sdca_mbq_cfg);
-	if (IS_ERR(regmap)) {
-		dev_err(&slave->dev, "sn624x: devm_regmap_init_sdw_mbq_cfg failed (%ld)\n",
-			PTR_ERR(regmap));
-		return PTR_ERR(regmap);
-	}
+	if (IS_ERR(regmap))
+		return dev_err_probe(&slave->dev, PTR_ERR(regmap),
+				     "devm_regmap_init_sdw_mbq_cfg failed\n");
 
 	ret = sn624x_sdca_init(&slave->dev, regmap, slave);
 	if (ret < 0)
-- 
2.46.0

回复: [PATCH] ASoC: sn624x: use dev_err_probe() for the regmap failure

[qianghua.wang]

On Thu, 5 Nov 2026, Aryan Sinha wrote:
> dev_err_probe() prints the symbolic errno and stays quiet on
> -EPROBE_DEFER. ...

Acked-by: Qianghua Wang <qianghua.wang@senarytech.com>

Qianghua Wang

Email: qianghua.wang@senarytech.com
Website: https://www.senarytech.com      

-----Original Message-----
From: Aryan Sinha sinha.aryan03@gmail.com
Sent: November 4, 2026 23:02
To: bo liu bo.liu@senarytech.com; qianghua . wang qianghua.wang@senarytech.com
Cc: Mark Brown broonie@kernel.org; Liam Girdwood lgirdwood@gmail.com; linux-sound@vger.kernel.org; linux-kernel@vger.kernel.org; Aryan Sinha sinha.aryan03@gmail.com
Subject: [PATCH] ASoC: sn624x: use dev_err_probe() for the regmap failure

dev_err_probe() prints the symbolic errno and stays quiet on  -EPROBE_DEFER. The sn624x prefix goes too, dev_err_probe() already prints the device name..

Signed-off-by: Aryan Sinha <sinha.aryan03@gmail.com>
---
 sound/soc/codecs/sn624x-sdca-sdw.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/sound/soc/codecs/sn624x-sdca-sdw.c b/sound/soc/codecs/sn624x-sdca-sdw.c
index c9e690482..1a83f0a11 100644
--- a/sound/soc/codecs/sn624x-sdca-sdw.c
+++ b/sound/soc/codecs/sn624x-sdca-sdw.c
@@ -1736,11 +1736,9 @@ static int sn624x_sdca_sdw_probe(struct sdw_slave *slave,
 	regmap = devm_regmap_init_sdw_mbq_cfg(&slave->dev, slave,
 					      &sn624x_sdca_regmap,
 					      &sn624x_sdca_mbq_cfg);
-	if (IS_ERR(regmap)) {
-		dev_err(&slave->dev, "sn624x: devm_regmap_init_sdw_mbq_cfg failed (%ld)\n",
-			PTR_ERR(regmap));
-		return PTR_ERR(regmap);
-	}
+	if (IS_ERR(regmap))
+		return dev_err_probe(&slave->dev, PTR_ERR(regmap),
+				     "devm_regmap_init_sdw_mbq_cfg failed\n");
 
 	ret = sn624x_sdca_init(&slave->dev, regmap, slave);
 	if (ret < 0)
--
2.46.0

Re: [PATCH] ASoC: sn624x: use dev_err_probe() for the regmap failure

[Mark Brown]

On Wed, 04 Nov 2026 20:31:54 +0530, Aryan Sinha wrote:
> ASoC: sn624x: use dev_err_probe() for the regmap failure

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.5

Thanks!

[1/1] ASoC: sn624x: use dev_err_probe() for the regmap failure
      https://git.kernel.org/broonie/sound/c/9d12f5640132

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark