Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Cezary Rojewski <cezary.rojewski@intel.com>
To: <phucduc.bui@gmail.com>
Cc: <linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH 5/6] ASoC: samsung: spdif: Drop redundant probe error messages
Date: Tue, 11 Aug 2026 15:16:27 +0200	[thread overview]
Message-ID: <0180ffef-6096-4429-853f-e01ce89c748c@intel.com> (raw)
In-Reply-To: <20260811090550.38930-6-phucduc.bui@gmail.com>

On 8/11/2026 11:05 AM, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> Remove the probe error messages to avoid duplicate error reporting,
> since the error is already reported by the called functions.

...

> @@ -415,19 +415,15 @@ static int spdif_probe(struct platform_device *pdev)
>   
>   	ret = samsung_asoc_dma_platform_register(&pdev->dev, filter,
>   						 NULL, NULL, NULL);
> -	if (ret) {
> -		dev_err(&pdev->dev, "failed to register DMA: %d\n", ret);

Which function reports the dmaengine registration failure?

> +	if (ret)
>   		goto err2;
> -	}

  reply	other threads:[~2026-08-11 13:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11  9:05 [PATCH 0/6] ASoC: samsung: Improve probe error handling phucduc.bui
2026-08-11  9:05 ` [PATCH 1/6] ASoC: samsung: aries_wm8994: Preserve gpiod_to_irq() error codes phucduc.bui
2026-08-11 13:17   ` Cezary Rojewski
2026-08-11  9:05 ` [PATCH 2/6] ASoC: samsung: aries_wm8994: Drop redundant probe error messages phucduc.bui
2026-08-11 13:10   ` Cezary Rojewski
2026-08-12  2:59     ` Bui Duc Phuc
2026-08-11  9:05 ` [PATCH 3/6] ASoC: samsung: pcm: Use dev_err_probe() for error handling phucduc.bui
2026-08-11 13:21   ` Cezary Rojewski
2026-08-11  9:05 ` [PATCH 4/6] ASoC: samsung: pcm: Drop redundant probe error messages phucduc.bui
2026-08-11  9:05 ` [PATCH 5/6] ASoC: samsung: spdif: " phucduc.bui
2026-08-11 13:16   ` Cezary Rojewski [this message]
2026-08-11  9:05 ` [PATCH 6/6] ASoC: samsung: tm2_wm5110: " phucduc.bui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0180ffef-6096-4429-853f-e01ce89c748c@intel.com \
    --to=cezary.rojewski@intel.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=phucduc.bui@gmail.com \
    --cc=s.nawrocki@samsung.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox