From: phucduc.bui@gmail.com
To: Sylwester Nawrocki <s.nawrocki@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH 2/6] ASoC: samsung: aries_wm8994: Drop redundant probe error messages
Date: Tue, 11 Aug 2026 16:05:46 +0700 [thread overview]
Message-ID: <20260811090550.38930-3-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20260811090550.38930-1-phucduc.bui@gmail.com>
From: bui duc phuc <phucduc.bui@gmail.com>
Remove the probe error messages to avoid duplicate error reporting,
since the error is already reported by the called functions.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
sound/soc/samsung/aries_wm8994.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/sound/soc/samsung/aries_wm8994.c b/sound/soc/samsung/aries_wm8994.c
index 58e3e08225de..d189db96cf17 100644
--- a/sound/soc/samsung/aries_wm8994.c
+++ b/sound/soc/samsung/aries_wm8994.c
@@ -381,10 +381,8 @@ static int aries_late_probe(struct snd_soc_card *card)
headset_det_irq_thread,
IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING |
IRQF_ONESHOT, "headset_detect", priv);
- if (ret) {
- dev_err(card->dev, "Failed to request headset detect irq");
+ if (ret)
return ret;
- }
headset_button_gpio[0].data = priv;
headset_button_gpio[0].desc = priv->gpio_headset_key;
@@ -623,10 +621,8 @@ static int aries_audio_probe(struct platform_device *pdev)
if (ret < 0) {
/* Backwards compatible way */
ret = snd_soc_of_parse_audio_routing(card, "samsung,audio-routing");
- if (ret < 0) {
- dev_err(dev, "Audio routing invalid/unspecified\n");
+ if (ret < 0)
return ret;
- }
}
aries_dai[1].dai_fmt = priv->variant->modem_dai_fmt;
@@ -671,10 +667,8 @@ static int aries_audio_probe(struct platform_device *pdev)
ret = devm_snd_soc_register_component(dev, &aries_component,
aries_ext_dai, ARRAY_SIZE(aries_ext_dai));
- if (ret < 0) {
- dev_err(dev, "Failed to register component: %d\n", ret);
+ if (ret < 0)
goto out;
- }
ret = devm_snd_soc_register_card(dev, card);
if (ret)
--
2.43.0
next prev parent reply other threads:[~2026-08-11 9:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 9:05 [PATCH 0/6] ASoC: samsung: Improve probe error handling phucduc.bui
2026-08-11 9:05 ` [PATCH 1/6] ASoC: samsung: aries_wm8994: Preserve gpiod_to_irq() error codes phucduc.bui
2026-08-11 13:17 ` Cezary Rojewski
2026-08-11 9:05 ` phucduc.bui [this message]
2026-08-11 13:10 ` [PATCH 2/6] ASoC: samsung: aries_wm8994: Drop redundant probe error messages Cezary Rojewski
2026-08-12 2:59 ` Bui Duc Phuc
2026-08-12 6:52 ` Cezary Rojewski
2026-08-11 9:05 ` [PATCH 3/6] ASoC: samsung: pcm: Use dev_err_probe() for error handling phucduc.bui
2026-08-11 13:21 ` Cezary Rojewski
2026-08-11 9:05 ` [PATCH 4/6] ASoC: samsung: pcm: Drop redundant probe error messages phucduc.bui
2026-08-11 9:05 ` [PATCH 5/6] ASoC: samsung: spdif: " phucduc.bui
2026-08-11 13:16 ` Cezary Rojewski
2026-08-11 9:05 ` [PATCH 6/6] ASoC: samsung: tm2_wm5110: " phucduc.bui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260811090550.38930-3-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=s.nawrocki@samsung.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox