* [Patch] Dont call ac97_release_codec with NULL argument in
@ 2006-04-09 15:09 Eric Sesterhenn
0 siblings, 0 replies; only message in thread
From: Eric Sesterhenn @ 2006-04-09 15:09 UTC (permalink / raw)
To: linux-sound
hi,
this is a fix for coverity id #243. We only jump to err_codec
if ac97_alloc_codec() fails its malloc() in which case codec is NULL.
Since ac97_release_codec dereferences its argument we shouldnt call
it with a NULL argument.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.17-rc1/sound/oss/es1371.c.orig 2006-04-09 17:03:22.000000000 +0200
+++ linux-2.6.17-rc1/sound/oss/es1371.c 2006-04-09 17:03:55.000000000 +0200
@@ -3040,8 +3040,8 @@ static int __devinit es1371_probe(struct
err_irq:
release_region(s->io, ES1371_EXTENT);
err_region:
- err_codec:
ac97_release_codec(s->codec);
+ err_codec:
kfree(s);
return res;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-04-09 15:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-09 15:09 [Patch] Dont call ac97_release_codec with NULL argument in Eric Sesterhenn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox