From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bharadwaj Raju <bharadwaj.raju@machinesoul.in>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Weidong Wang <wangweidong.a@awinic.com>
Cc: Bhushan Shah <bhushan.shah@machinesoul.in>,
Luca Weiss <luca.weiss@fairphone.com>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: dt-bindings: document dvdd-supply property for awinic,aw88261
Date: Sun, 11 Jan 2026 17:10:28 +0100 [thread overview]
Message-ID: <1ab13178-8253-4dc7-9143-6684ededd8f9@kernel.org> (raw)
In-Reply-To: <5e47fe91-e150-4b5d-a669-3a7beeea4f03@app.fastmail.com>
On 11/01/2026 13:48, Bharadwaj Raju wrote:
> On Sun, 11 Jan 2026, at 5:00 PM, Krzysztof Kozlowski wrote:
>> Why? Was it missing? Why require it, which is an ABI break (or is not?)?
>> Why is ABI break allowed or what is its impact?
>
> Right now there are no users of aw88261 in the kernel device tree sources.
> This patch is part of an effort to mainline the FairPhone 5, for which we
> will add the first use of this compatible, and there we need to specify
> dvdd-supply for this chip's power supply.
You mean the bindings were incomplete?
>
> Since there are no present users, I thought it was OK to add a new required
> property. If not, I can make it optional.
Nothing like that was explained in commit msg. Also your explanation
above does not consider out of tree users of this ABI. That's fine in
general, but needs reason why you are doing this.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-11 16:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-11 10:10 [PATCH 0/2] ASoC: codecs: aw88261: add dvdd-supply property Bharadwaj Raju via B4 Relay
2026-01-11 10:10 ` [PATCH 1/2] ASoC: codecs: aw88261: use dvdd-supply regulator Bharadwaj Raju via B4 Relay
2026-01-11 11:30 ` Krzysztof Kozlowski
2026-01-11 10:10 ` [PATCH 2/2] ASoC: dt-bindings: document dvdd-supply property for awinic,aw88261 Bharadwaj Raju via B4 Relay
2026-01-11 11:30 ` Krzysztof Kozlowski
2026-01-11 12:48 ` Bharadwaj Raju
2026-01-11 16:10 ` Krzysztof Kozlowski [this message]
2026-01-12 16:27 ` Bharadwaj Raju
2026-01-12 16:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ab13178-8253-4dc7-9143-6684ededd8f9@kernel.org \
--to=krzk@kernel.org \
--cc=bharadwaj.raju@machinesoul.in \
--cc=bhushan.shah@machinesoul.in \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=perex@perex.cz \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
--cc=wangweidong.a@awinic.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox