From: Krzysztof Kozlowski <krzk@kernel.org>
To: bharadwaj.raju@machinesoul.in,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Weidong Wang <wangweidong.a@awinic.com>
Cc: Bhushan Shah <bhushan.shah@machinesoul.in>,
Luca Weiss <luca.weiss@fairphone.com>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: codecs: aw88261: use dvdd-supply regulator
Date: Sun, 11 Jan 2026 12:30:32 +0100 [thread overview]
Message-ID: <d77fe637-01cc-4737-8bc1-4ed8892bd1d9@kernel.org> (raw)
In-Reply-To: <20260111-aw88261-dvdd-v1-1-83fa0850d561@machinesoul.in>
On 11/01/2026 11:10, Bharadwaj Raju via B4 Relay wrote:
> From: Bharadwaj Raju <bharadwaj.raju@machinesoul.in>
>
> Enable the dvdd regulator on startup.
>
> Signed-off-by: Bharadwaj Raju <bharadwaj.raju@machinesoul.in>
> ---
> sound/soc/codecs/aw88261.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/sound/soc/codecs/aw88261.c b/sound/soc/codecs/aw88261.c
> index 6bd6e7ffd1aa..9a2d167cf809 100644
> --- a/sound/soc/codecs/aw88261.c
> +++ b/sound/soc/codecs/aw88261.c
> @@ -11,6 +11,7 @@
> #include <linux/i2c.h>
> #include <linux/firmware.h>
> #include <linux/regmap.h>
> +#include <linux/regulator/consumer.h>
> #include <sound/soc.h>
> #include "aw88261.h"
> #include "aw88395/aw88395_data_type.h"
> @@ -1295,6 +1296,10 @@ static int aw88261_init(struct aw88261 **aw88261, struct i2c_client *i2c, struct
> unsigned int chip_id;
> int ret;
>
> + ret = devm_regulator_get_enable(&i2c->dev, "dvdd");
Do not use ABI before you document it. See submitting patches in DT dir.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-11 11:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-11 10:10 [PATCH 0/2] ASoC: codecs: aw88261: add dvdd-supply property Bharadwaj Raju via B4 Relay
2026-01-11 10:10 ` [PATCH 1/2] ASoC: codecs: aw88261: use dvdd-supply regulator Bharadwaj Raju via B4 Relay
2026-01-11 11:30 ` Krzysztof Kozlowski [this message]
2026-01-11 10:10 ` [PATCH 2/2] ASoC: dt-bindings: document dvdd-supply property for awinic,aw88261 Bharadwaj Raju via B4 Relay
2026-01-11 11:30 ` Krzysztof Kozlowski
2026-01-11 12:48 ` Bharadwaj Raju
2026-01-11 16:10 ` Krzysztof Kozlowski
2026-01-12 16:27 ` Bharadwaj Raju
2026-01-12 16:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d77fe637-01cc-4737-8bc1-4ed8892bd1d9@kernel.org \
--to=krzk@kernel.org \
--cc=bharadwaj.raju@machinesoul.in \
--cc=bhushan.shah@machinesoul.in \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=perex@perex.cz \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
--cc=wangweidong.a@awinic.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox