[PATCH 0/2] ASoC: codecs: aw88261: add dvdd-supply property

[PATCH 0/2] ASoC: codecs: aw88261: add dvdd-supply property

[Bharadwaj Raju via B4 Relay]

Make the aw88261 driver depend on and enable the dvdd-supply regulator,
so that the correct regulator can be specified in the device tree.

Signed-off-by: Bharadwaj Raju <bharadwaj.raju@machinesoul.in>
---
Bharadwaj Raju (2):
      ASoC: codecs: aw88261: use dvdd-supply regulator
      ASoC: dt-bindings: document dvdd-supply property for awinic,aw88261

 Documentation/devicetree/bindings/sound/awinic,aw88395.yaml | 13 +++++++++++++
 sound/soc/codecs/aw88261.c                                  |  5 +++++
 2 files changed, 18 insertions(+)
---
base-commit: db1c30e19243982e34f027a2e564c93e94f42cb2
change-id: 20260111-aw88261-dvdd-50c41c151ba0

Best regards,
-- 
Bharadwaj Raju <bharadwaj.raju@machinesoul.in>

[PATCH 1/2] ASoC: codecs: aw88261: use dvdd-supply regulator

[Bharadwaj Raju via B4 Relay]

From: Bharadwaj Raju <bharadwaj.raju@machinesoul.in>

Enable the dvdd regulator on startup.

Signed-off-by: Bharadwaj Raju <bharadwaj.raju@machinesoul.in>
---
 sound/soc/codecs/aw88261.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/sound/soc/codecs/aw88261.c b/sound/soc/codecs/aw88261.c
index 6bd6e7ffd1aa..9a2d167cf809 100644
--- a/sound/soc/codecs/aw88261.c
+++ b/sound/soc/codecs/aw88261.c
@@ -11,6 +11,7 @@
 #include <linux/i2c.h>
 #include <linux/firmware.h>
 #include <linux/regmap.h>
+#include <linux/regulator/consumer.h>
 #include <sound/soc.h>
 #include "aw88261.h"
 #include "aw88395/aw88395_data_type.h"
@@ -1295,6 +1296,10 @@ static int aw88261_init(struct aw88261 **aw88261, struct i2c_client *i2c, struct
 	unsigned int chip_id;
 	int ret;
 
+	ret = devm_regulator_get_enable(&i2c->dev, "dvdd");
+	if (ret)
+		return dev_err_probe(&i2c->dev, ret, "Failed to enable dvdd supply\n");
+
 	/* read chip id */
 	ret = regmap_read(regmap, AW88261_ID_REG, &chip_id);
 	if (ret) {

-- 
2.43.0

[PATCH 2/2] ASoC: dt-bindings: document dvdd-supply property for awinic,aw88261

[Bharadwaj Raju via B4 Relay]

From: Bharadwaj Raju <bharadwaj.raju@machinesoul.in>

Add (and require) the dvdd-supply property for awinic,aw88261 in
the awinic,aw88395.yaml binding.

Signed-off-by: Bharadwaj Raju <bharadwaj.raju@machinesoul.in>
---
 Documentation/devicetree/bindings/sound/awinic,aw88395.yaml | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
index bb92d6ca3144..994d68c074a9 100644
--- a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
+++ b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
@@ -33,6 +33,8 @@ properties:
   reset-gpios:
     maxItems: 1
 
+  dvdd-supply: true
+
   awinic,audio-channel:
     description:
       It is used to distinguish multiple PA devices, so that different
@@ -65,6 +67,17 @@ allOf:
     then:
       properties:
         reset-gpios: false
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: awinic,aw88261
+    then:
+      required:
+        - dvdd-supply
+    else:
+      properties:
+        dvdd-supply: false
 
 unevaluatedProperties: false
 

-- 
2.43.0

Re: [PATCH 2/2] ASoC: dt-bindings: document dvdd-supply property for awinic,aw88261

[Krzysztof Kozlowski]

On 11/01/2026 11:10, Bharadwaj Raju via B4 Relay wrote:
> From: Bharadwaj Raju <bharadwaj.raju@machinesoul.in>
> 
> Add (and require) the dvdd-supply property for awinic,aw88261 in

Why? Was it missing? Why require it, which is an ABI break (or is not?)?
Why is ABI break allowed or what is its impact?

> the awinic,aw88395.yaml binding.



Best regards,
Krzysztof

Re: [PATCH 1/2] ASoC: codecs: aw88261: use dvdd-supply regulator

[Krzysztof Kozlowski]

On 11/01/2026 11:10, Bharadwaj Raju via B4 Relay wrote:
> From: Bharadwaj Raju <bharadwaj.raju@machinesoul.in>
> 
> Enable the dvdd regulator on startup.
> 
> Signed-off-by: Bharadwaj Raju <bharadwaj.raju@machinesoul.in>
> ---
>  sound/soc/codecs/aw88261.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/sound/soc/codecs/aw88261.c b/sound/soc/codecs/aw88261.c
> index 6bd6e7ffd1aa..9a2d167cf809 100644
> --- a/sound/soc/codecs/aw88261.c
> +++ b/sound/soc/codecs/aw88261.c
> @@ -11,6 +11,7 @@
>  #include <linux/i2c.h>
>  #include <linux/firmware.h>
>  #include <linux/regmap.h>
> +#include <linux/regulator/consumer.h>
>  #include <sound/soc.h>
>  #include "aw88261.h"
>  #include "aw88395/aw88395_data_type.h"
> @@ -1295,6 +1296,10 @@ static int aw88261_init(struct aw88261 **aw88261, struct i2c_client *i2c, struct
>  	unsigned int chip_id;
>  	int ret;
>  
> +	ret = devm_regulator_get_enable(&i2c->dev, "dvdd");

Do not use ABI before you document it. See submitting patches in DT dir.


Best regards,
Krzysztof

Re: [PATCH 2/2] ASoC: dt-bindings: document dvdd-supply property for awinic,aw88261

[Bharadwaj Raju]

On Sun, 11 Jan 2026, at 5:00 PM, Krzysztof Kozlowski wrote:
> Why? Was it missing? Why require it, which is an ABI break (or is not?)?
> Why is ABI break allowed or what is its impact?

Right now there are no users of aw88261 in the kernel device tree sources.
This patch is part of an effort to mainline the FairPhone 5, for which we 
will add the first use of this compatible, and there we need to specify 
dvdd-supply for this chip's power supply.

Since there are no present users, I thought it was OK to add a new required 
property. If not, I can make it optional.

Re: [PATCH 2/2] ASoC: dt-bindings: document dvdd-supply property for awinic,aw88261

[Krzysztof Kozlowski]

On 11/01/2026 13:48, Bharadwaj Raju wrote:
> On Sun, 11 Jan 2026, at 5:00 PM, Krzysztof Kozlowski wrote:
>> Why? Was it missing? Why require it, which is an ABI break (or is not?)?
>> Why is ABI break allowed or what is its impact?
> 
> Right now there are no users of aw88261 in the kernel device tree sources.
> This patch is part of an effort to mainline the FairPhone 5, for which we 
> will add the first use of this compatible, and there we need to specify 
> dvdd-supply for this chip's power supply.

You mean the bindings were incomplete?

> 
> Since there are no present users, I thought it was OK to add a new required 
> property. If not, I can make it optional.

Nothing like that was explained in commit msg. Also your explanation
above does not consider out of tree users of this ABI. That's fine in
general, but needs reason why you are doing this.

Best regards,
Krzysztof

Re: [PATCH 2/2] ASoC: dt-bindings: document dvdd-supply property for awinic,aw88261

[Bharadwaj Raju]

On Sun, 11 Jan 2026, at 9:40 PM, Krzysztof Kozlowski wrote:
> On 11/01/2026 13:48, Bharadwaj Raju wrote:
>> On Sun, 11 Jan 2026, at 5:00 PM, Krzysztof Kozlowski wrote:
>>> Why? Was it missing? Why require it, which is an ABI break (or is not?)?
>>> Why is ABI break allowed or what is its impact?
>> 
>> Right now there are no users of aw88261 in the kernel device tree sources.
>> This patch is part of an effort to mainline the FairPhone 5, for which we 
>> will add the first use of this compatible, and there we need to specify 
>> dvdd-supply for this chip's power supply.
>
> You mean the bindings were incomplete?

Yes, the chip needs DVDD to power on.

>> 
>> Since there are no present users, I thought it was OK to add a new required 
>> property. If not, I can make it optional.
>
> Nothing like that was explained in commit msg. Also your explanation
> above does not consider out of tree users of this ABI. That's fine in
> general, but needs reason why you are doing this.

After looking at other codec drivers, they generally make it optional 
in the binding but error out from probe if it can't be enabled.

I'll resend the series with it made optional.

Regards,
Bharadwaj

Re: [PATCH 2/2] ASoC: dt-bindings: document dvdd-supply property for awinic,aw88261

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

On Mon, Jan 12, 2026 at 09:57:46PM +0530, Bharadwaj Raju wrote:
> On Sun, 11 Jan 2026, at 9:40 PM, Krzysztof Kozlowski wrote:

> > You mean the bindings were incomplete?

> Yes, the chip needs DVDD to power on.

> After looking at other codec drivers, they generally make it optional 
> in the binding but error out from probe if it can't be enabled.

> I'll resend the series with it made optional.

No, if the chip needs the supply it shouldn't be optional in the
bindings - it is an ABI break, but in practice only for validation since
the kernel will assume some supply is there even if not described.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]