Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Jerome Brunet <jbrunet@baylibre.com>
To: Zhang Zekun <zhangzekun11@huawei.com>
Cc: <lgirdwood@gmail.com>,  <broonie@kernel.org>,  <perex@perex.cz>,
	<tiwai@suse.com>,  <linux-sound@vger.kernel.org>,
	<chenjun102@huawei.com>
Subject: Re: [PATCH] ASoC: meson: Remove unused declartion in header file
Date: Tue, 10 Sep 2024 15:06:31 +0200	[thread overview]
Message-ID: <1jv7z3slns.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20240910122330.70684-1-zhangzekun11@huawei.com> (Zhang Zekun's message of "Tue, 10 Sep 2024 20:23:30 +0800")

On Tue 10 Sep 2024 at 20:23, Zhang Zekun <zhangzekun11@huawei.com> wrote:

> The declaration of aiu_fifo_hw_free() has been removed since
> commit e05cde84eabc ("ASoC: meson: Use managed DMA buffer allocation").

Missing the fixes tag then:
Fixes: e05cde84eabc ("ASoC: meson: Use managed DMA buffer allocation")

> Let's remove the unused declaration.

With the tag
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>

>
> Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
> ---
>  sound/soc/meson/aiu-fifo.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/sound/soc/meson/aiu-fifo.h b/sound/soc/meson/aiu-fifo.h
> index 84ab4577815a..b02cfcc4de7f 100644
> --- a/sound/soc/meson/aiu-fifo.h
> +++ b/sound/soc/meson/aiu-fifo.h
> @@ -38,8 +38,6 @@ int aiu_fifo_prepare(struct snd_pcm_substream *substream,
>  int aiu_fifo_hw_params(struct snd_pcm_substream *substream,
>  		       struct snd_pcm_hw_params *params,
>  		       struct snd_soc_dai *dai);
> -int aiu_fifo_hw_free(struct snd_pcm_substream *substream,
> -		     struct snd_soc_dai *dai);
>  int aiu_fifo_startup(struct snd_pcm_substream *substream,
>  		     struct snd_soc_dai *dai);
>  void aiu_fifo_shutdown(struct snd_pcm_substream *substream,

-- 
Jerome

  reply	other threads:[~2024-09-10 13:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-10 12:23 [PATCH] ASoC: meson: Remove unused declartion in header file Zhang Zekun
2024-09-10 13:06 ` Jerome Brunet [this message]
2024-09-10 19:49 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1jv7z3slns.fsf@starbuckisacylon.baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=broonie@kernel.org \
    --cc=chenjun102@huawei.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=zhangzekun11@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox