Linux Sound subsystem development
 help / color / mirror / Atom feed
* [PATCH] ASoC: meson: Remove unused declartion in header file
@ 2024-09-10 12:23 Zhang Zekun
  2024-09-10 13:06 ` Jerome Brunet
  2024-09-10 19:49 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Zhang Zekun @ 2024-09-10 12:23 UTC (permalink / raw)
  To: jbrunet, lgirdwood, broonie, perex, tiwai, linux-sound
  Cc: chenjun102, zhangzekun11

The declaration of aiu_fifo_hw_free() has been removed since
commit e05cde84eabc ("ASoC: meson: Use managed DMA buffer allocation").
Let's remove the unused declaration.

Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
---
 sound/soc/meson/aiu-fifo.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sound/soc/meson/aiu-fifo.h b/sound/soc/meson/aiu-fifo.h
index 84ab4577815a..b02cfcc4de7f 100644
--- a/sound/soc/meson/aiu-fifo.h
+++ b/sound/soc/meson/aiu-fifo.h
@@ -38,8 +38,6 @@ int aiu_fifo_prepare(struct snd_pcm_substream *substream,
 int aiu_fifo_hw_params(struct snd_pcm_substream *substream,
 		       struct snd_pcm_hw_params *params,
 		       struct snd_soc_dai *dai);
-int aiu_fifo_hw_free(struct snd_pcm_substream *substream,
-		     struct snd_soc_dai *dai);
 int aiu_fifo_startup(struct snd_pcm_substream *substream,
 		     struct snd_soc_dai *dai);
 void aiu_fifo_shutdown(struct snd_pcm_substream *substream,
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: meson: Remove unused declartion in header file
  2024-09-10 12:23 [PATCH] ASoC: meson: Remove unused declartion in header file Zhang Zekun
@ 2024-09-10 13:06 ` Jerome Brunet
  2024-09-10 19:49 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Jerome Brunet @ 2024-09-10 13:06 UTC (permalink / raw)
  To: Zhang Zekun; +Cc: lgirdwood, broonie, perex, tiwai, linux-sound, chenjun102

On Tue 10 Sep 2024 at 20:23, Zhang Zekun <zhangzekun11@huawei.com> wrote:

> The declaration of aiu_fifo_hw_free() has been removed since
> commit e05cde84eabc ("ASoC: meson: Use managed DMA buffer allocation").

Missing the fixes tag then:
Fixes: e05cde84eabc ("ASoC: meson: Use managed DMA buffer allocation")

> Let's remove the unused declaration.

With the tag
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>

>
> Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
> ---
>  sound/soc/meson/aiu-fifo.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/sound/soc/meson/aiu-fifo.h b/sound/soc/meson/aiu-fifo.h
> index 84ab4577815a..b02cfcc4de7f 100644
> --- a/sound/soc/meson/aiu-fifo.h
> +++ b/sound/soc/meson/aiu-fifo.h
> @@ -38,8 +38,6 @@ int aiu_fifo_prepare(struct snd_pcm_substream *substream,
>  int aiu_fifo_hw_params(struct snd_pcm_substream *substream,
>  		       struct snd_pcm_hw_params *params,
>  		       struct snd_soc_dai *dai);
> -int aiu_fifo_hw_free(struct snd_pcm_substream *substream,
> -		     struct snd_soc_dai *dai);
>  int aiu_fifo_startup(struct snd_pcm_substream *substream,
>  		     struct snd_soc_dai *dai);
>  void aiu_fifo_shutdown(struct snd_pcm_substream *substream,

-- 
Jerome

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: meson: Remove unused declartion in header file
  2024-09-10 12:23 [PATCH] ASoC: meson: Remove unused declartion in header file Zhang Zekun
  2024-09-10 13:06 ` Jerome Brunet
@ 2024-09-10 19:49 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2024-09-10 19:49 UTC (permalink / raw)
  To: jbrunet, lgirdwood, perex, tiwai, linux-sound, Zhang Zekun; +Cc: chenjun102

On Tue, 10 Sep 2024 20:23:30 +0800, Zhang Zekun wrote:
> The declaration of aiu_fifo_hw_free() has been removed since
> commit e05cde84eabc ("ASoC: meson: Use managed DMA buffer allocation").
> Let's remove the unused declaration.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: meson: Remove unused declartion in header file
      commit: afe671ac3e9309e55d556d066250bd37d9c47d1a

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-09-10 19:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-10 12:23 [PATCH] ASoC: meson: Remove unused declartion in header file Zhang Zekun
2024-09-10 13:06 ` Jerome Brunet
2024-09-10 19:49 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox