From: "Scott Thompson" <postfail@hushmail.com>
To: kernel-janitors@vger.kernel.org
Subject: [PATCH] sound/pci ioremap unchecked return
Date: Wed, 01 Aug 2007 13:33:13 +0000 [thread overview]
Message-ID: <20070801133313.A408E22822@mailserver9.hushmail.com> (raw)
two unchecked ioremap calls. upon further review and discussion
these are only 'valid' changes from previously posted "[PATCH 2/3]
sound/pci ioremap/iounmap balancing".
Signed-off-by: Scott Thompson <postfail <at> hushmail.com>
---
diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c
index ac007ce..871b09f 100644
--- a/sound/pci/mixart/mixart.c
+++ b/sound/pci/mixart/mixart.c
@@ -1319,6 +1319,13 @@ static int __devinit snd_mixart_probe(struct
pci_dev *pci,
pci_resource_len(pci, i));
}
+ if (!mgr->mem[0].virt || !mgr->mem[1].virt){
+ printk(KERN_ERR "unable to remap resource 0x%lx and/or
0x%lx\n",
+ mgr->mem[0].phys, mgr->mem[1].phys);
+ snd_mixart_free(mgr);
+ return -EBUSY;
+ }
+
if (request_irq(pci->irq, snd_mixart_interrupt, IRQF_SHARED,
CARD_NAME, mgr)) {
snd_printk(KERN_ERR "unable to grab IRQ %d\n", pci->irq);
--
Not making enough money? Click here to get free info on medical jobs
http://tagline.hushmail.com/fc/Ioyw6h4d93U6JUZpepI2qWsIMxmUitzPzo18AVd8LFg3yKzbPiL6Vn/
reply other threads:[~2007-08-01 13:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070801133313.A408E22822@mailserver9.hushmail.com \
--to=postfail@hushmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox