* [PATCH] sound/pci ioremap unchecked return
@ 2007-08-01 13:33 Scott Thompson
0 siblings, 0 replies; only message in thread
From: Scott Thompson @ 2007-08-01 13:33 UTC (permalink / raw)
To: kernel-janitors
two unchecked ioremap calls. upon further review and discussion
these are only 'valid' changes from previously posted "[PATCH 2/3]
sound/pci ioremap/iounmap balancing".
Signed-off-by: Scott Thompson <postfail <at> hushmail.com>
---
diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c
index ac007ce..871b09f 100644
--- a/sound/pci/mixart/mixart.c
+++ b/sound/pci/mixart/mixart.c
@@ -1319,6 +1319,13 @@ static int __devinit snd_mixart_probe(struct
pci_dev *pci,
pci_resource_len(pci, i));
}
+ if (!mgr->mem[0].virt || !mgr->mem[1].virt){
+ printk(KERN_ERR "unable to remap resource 0x%lx and/or
0x%lx\n",
+ mgr->mem[0].phys, mgr->mem[1].phys);
+ snd_mixart_free(mgr);
+ return -EBUSY;
+ }
+
if (request_irq(pci->irq, snd_mixart_interrupt, IRQF_SHARED,
CARD_NAME, mgr)) {
snd_printk(KERN_ERR "unable to grab IRQ %d\n", pci->irq);
--
Not making enough money? Click here to get free info on medical jobs
http://tagline.hushmail.com/fc/Ioyw6h4d93U6JUZpepI2qWsIMxmUitzPzo18AVd8LFg3yKzbPiL6Vn/
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2007-08-01 13:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-01 13:33 [PATCH] sound/pci ioremap unchecked return Scott Thompson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox