public inbox for linux-sound@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: atmel: disable error interrupt
@ 2013-09-04  7:27 Bo Shen
  2013-09-04  9:48 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Bo Shen @ 2013-09-04  7:27 UTC (permalink / raw)
  To: broonie
  Cc: alsa-devel, nicolas.ferre, linux-sound, Bo Shen, plagnioj,
	linux-arm-kernel

As once the error interrupt is triggered, it can not be cleared.
So, disable it.

No side effect found while testing on sama5d3xek and at91sam9x5ek
boards.

Signed-off-by: Bo Shen <voice.shen@atmel.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
 sound/soc/atmel/atmel_ssc_dai.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c
index 0ecf356..bb53dea 100644
--- a/sound/soc/atmel/atmel_ssc_dai.c
+++ b/sound/soc/atmel/atmel_ssc_dai.c
@@ -649,7 +649,7 @@ static int atmel_ssc_prepare(struct snd_pcm_substream *substream,
 	dma_params = ssc_p->dma_params[dir];
 
 	ssc_writel(ssc_p->ssc->regs, CR, dma_params->mask->ssc_enable);
-	ssc_writel(ssc_p->ssc->regs, IER, dma_params->mask->ssc_error);
+	ssc_writel(ssc_p->ssc->regs, IDR, dma_params->mask->ssc_error);
 
 	pr_debug("%s enabled SSC_SR=0x%08x\n",
 			dir ? "receive" : "transmit",
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: atmel: disable error interrupt
  2013-09-04  7:27 [PATCH] ASoC: atmel: disable error interrupt Bo Shen
@ 2013-09-04  9:48 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-09-04  9:48 UTC (permalink / raw)
  To: Bo Shen; +Cc: plagnioj, alsa-devel, nicolas.ferre, linux-arm-kernel,
	linux-sound

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

On Wed, Sep 04, 2013 at 03:27:46PM +0800, Bo Shen wrote:
> As once the error interrupt is triggered, it can not be cleared.
> So, disable it.
> 
> No side effect found while testing on sama5d3xek and at91sam9x5ek
> boards.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-09-04  9:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-04  7:27 [PATCH] ASoC: atmel: disable error interrupt Bo Shen
2013-09-04  9:48 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox