[PATCH 0/7] ASoC: Add missing module descriptions

[PATCH 0/7] ASoC: Add missing module descriptions

[Takashi Iwai]

Hi,

here is a trivial patch series to add the missing module descriptions
to ASoC drivers, as make W=1 starts complaining the lack of
MODULE_DESCRIPTION() since recently.

The whole sound/soc/sof/* are untouched as there are too many files
involved, and I left SOF people to address them.


thanks,

Takashi

===

Takashi Iwai (7):
  ASoC: ab8500: Add missing module description
  ASoC: sigmadsp: Add missing module description
  ASoC: qcom: Add missing module descriptions
  ASoC: dmaengine: Add missing module description
  ASoC: topology-test: Add missing module description
  ASoC: ux500: Add missing module description
  ASoC: xilinx: Add missing module descriptions

 sound/soc/codecs/ab8500-codec.c       | 1 +
 sound/soc/codecs/sigmadsp.c           | 1 +
 sound/soc/qcom/common.c               | 2 ++
 sound/soc/qcom/qdsp6/q6dsp-common.c   | 2 ++
 sound/soc/soc-generic-dmaengine-pcm.c | 1 +
 sound/soc/soc-topology-test.c         | 1 +
 sound/soc/ux500/ux500_msp_dai.c       | 1 +
 sound/soc/xilinx/xlnx_formatter_pcm.c | 2 ++
 sound/soc/xilinx/xlnx_i2s.c           | 1 +
 9 files changed, 12 insertions(+)

-- 
2.43.0

[PATCH 1/7] ASoC: ab8500: Add missing module description

[Takashi Iwai]

Now that make W=1 starts complaining the lack of MODULE_DESCRIPTION(),
let's add the missing information.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/ZjpQm-hxLQtpgkUx@smile.fi.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/soc/codecs/ab8500-codec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/ab8500-codec.c b/sound/soc/codecs/ab8500-codec.c
index 68342917419e..04b5e1d5a653 100644
--- a/sound/soc/codecs/ab8500-codec.c
+++ b/sound/soc/codecs/ab8500-codec.c
@@ -2571,4 +2571,5 @@ static struct platform_driver ab8500_codec_platform_driver = {
 };
 module_platform_driver(ab8500_codec_platform_driver);
 
+MODULE_DESCRIPTION("ASoC AB8500 codec driver");
 MODULE_LICENSE("GPL v2");
-- 
2.43.0

Re: [PATCH 1/7] ASoC: ab8500: Add missing module description

[Andy Shevchenko]

On Wed, May 08, 2024 at 11:19:00AM +0200, Takashi Iwai wrote:
> Now that make W=1 starts complaining the lack of MODULE_DESCRIPTION(),
> let's add the missing information.

Probably Reported-by: fits better, but I'm fine with either.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

P.S. I don't see cover letter, so the tag applies to all patches.

-- 
With Best Regards,
Andy Shevchenko

[PATCH 2/7] ASoC: sigmadsp: Add missing module description

[Takashi Iwai]

Now that make W=1 starts complaining the lack of MODULE_DESCRIPTION(),
let's add the missing information.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/ZjpQm-hxLQtpgkUx@smile.fi.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/soc/codecs/sigmadsp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/sigmadsp.c b/sound/soc/codecs/sigmadsp.c
index 56546e2394ab..201f74e3a7ae 100644
--- a/sound/soc/codecs/sigmadsp.c
+++ b/sound/soc/codecs/sigmadsp.c
@@ -805,4 +805,5 @@ int sigmadsp_restrict_params(struct sigmadsp *sigmadsp,
 }
 EXPORT_SYMBOL_GPL(sigmadsp_restrict_params);
 
+MODULE_DESCRIPTION("Analog Devices SigmaStudio firmware helpers");
 MODULE_LICENSE("GPL");
-- 
2.43.0

[PATCH 3/7] ASoC: qcom: Add missing module descriptions

[Takashi Iwai]

Now that make W=1 starts complaining the lack of MODULE_DESCRIPTION(),
let's add the missing information.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/ZjpQm-hxLQtpgkUx@smile.fi.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/soc/qcom/common.c             | 2 ++
 sound/soc/qcom/qdsp6/q6dsp-common.c | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/sound/soc/qcom/common.c b/sound/soc/qcom/common.c
index 747041fa7866..3d02aa3844f2 100644
--- a/sound/soc/qcom/common.c
+++ b/sound/soc/qcom/common.c
@@ -239,4 +239,6 @@ int qcom_snd_wcd_jack_setup(struct snd_soc_pcm_runtime *rtd,
 	return 0;
 }
 EXPORT_SYMBOL_GPL(qcom_snd_wcd_jack_setup);
+
+MODULE_DESCRIPTION("ASoC Qualcomm helper functions");
 MODULE_LICENSE("GPL");
diff --git a/sound/soc/qcom/qdsp6/q6dsp-common.c b/sound/soc/qcom/qdsp6/q6dsp-common.c
index 95585dea2b36..f74585d88bd6 100644
--- a/sound/soc/qcom/qdsp6/q6dsp-common.c
+++ b/sound/soc/qcom/qdsp6/q6dsp-common.c
@@ -98,4 +98,6 @@ int q6dsp_get_channel_allocation(int channels)
 	return channel_allocation;
 }
 EXPORT_SYMBOL_GPL(q6dsp_get_channel_allocation);
+
+MODULE_DESCRIPTION("ASoC MSM QDSP6 helper functions");
 MODULE_LICENSE("GPL v2");
-- 
2.43.0

[PATCH 4/7] ASoC: dmaengine: Add missing module description

[Takashi Iwai]

Now that make W=1 starts complaining the lack of MODULE_DESCRIPTION(),
let's add the missing information.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/ZjpQm-hxLQtpgkUx@smile.fi.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/soc/soc-generic-dmaengine-pcm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/soc-generic-dmaengine-pcm.c b/sound/soc/soc-generic-dmaengine-pcm.c
index 092ca09f3631..c29082eea09f 100644
--- a/sound/soc/soc-generic-dmaengine-pcm.c
+++ b/sound/soc/soc-generic-dmaengine-pcm.c
@@ -491,4 +491,5 @@ void snd_dmaengine_pcm_unregister(struct device *dev)
 }
 EXPORT_SYMBOL_GPL(snd_dmaengine_pcm_unregister);
 
+MODULE_DESCRIPTION("ASoC helpers for generic PCM dmaengine API");
 MODULE_LICENSE("GPL");
-- 
2.43.0

[PATCH 5/7] ASoC: topology-test: Add missing module description

[Takashi Iwai]

Now that make W=1 starts complaining the lack of MODULE_DESCRIPTION(),
let's add the missing information.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/ZjpQm-hxLQtpgkUx@smile.fi.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/soc/soc-topology-test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/soc-topology-test.c b/sound/soc/soc-topology-test.c
index 70cbccc42a42..40147788f22a 100644
--- a/sound/soc/soc-topology-test.c
+++ b/sound/soc/soc-topology-test.c
@@ -819,4 +819,5 @@ static struct kunit_suite snd_soc_tplg_test_suite = {
 
 kunit_test_suites(&snd_soc_tplg_test_suite);
 
+MODULE_DESCRIPTION("ASoC Topology Kernel Unit Tests");
 MODULE_LICENSE("GPL");
-- 
2.43.0

[PATCH 6/7] ASoC: ux500: Add missing module description

[Takashi Iwai]

Now that make W=1 starts complaining the lack of MODULE_DESCRIPTION(),
let's add the missing information.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/ZjpQm-hxLQtpgkUx@smile.fi.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/soc/ux500/ux500_msp_dai.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/ux500/ux500_msp_dai.c b/sound/soc/ux500/ux500_msp_dai.c
index cde0dd8e2569..3fd13e8dd110 100644
--- a/sound/soc/ux500/ux500_msp_dai.c
+++ b/sound/soc/ux500/ux500_msp_dai.c
@@ -820,4 +820,5 @@ static struct platform_driver msp_i2s_driver = {
 };
 module_platform_driver(msp_i2s_driver);
 
+MODULE_DESCRIPTION("ASoC Ux500 I2S driver");
 MODULE_LICENSE("GPL v2");
-- 
2.43.0

[PATCH 7/7] ASoC: xilinx: Add missing module descriptions

[Takashi Iwai]

Now that make W=1 starts complaining the lack of MODULE_DESCRIPTION(),
let's add the missing information.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/ZjpQm-hxLQtpgkUx@smile.fi.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/soc/xilinx/xlnx_formatter_pcm.c | 2 ++
 sound/soc/xilinx/xlnx_i2s.c           | 1 +
 2 files changed, 3 insertions(+)

diff --git a/sound/soc/xilinx/xlnx_formatter_pcm.c b/sound/soc/xilinx/xlnx_formatter_pcm.c
index 299cfb5e2022..158fc21a86c1 100644
--- a/sound/soc/xilinx/xlnx_formatter_pcm.c
+++ b/sound/soc/xilinx/xlnx_formatter_pcm.c
@@ -721,5 +721,7 @@ static struct platform_driver xlnx_formatter_pcm_driver = {
 };
 
 module_platform_driver(xlnx_formatter_pcm_driver);
+
+MODULE_DESCRIPTION("ASoC driver for Xilinx audio formatter");
 MODULE_AUTHOR("Maruthi Srinivas Bayyavarapu <maruthis@xilinx.com>");
 MODULE_LICENSE("GPL v2");
diff --git a/sound/soc/xilinx/xlnx_i2s.c b/sound/soc/xilinx/xlnx_i2s.c
index 9de92d35e30e..ca915a001ad5 100644
--- a/sound/soc/xilinx/xlnx_i2s.c
+++ b/sound/soc/xilinx/xlnx_i2s.c
@@ -253,6 +253,7 @@ static struct platform_driver xlnx_i2s_aud_driver = {
 
 module_platform_driver(xlnx_i2s_aud_driver);
 
+MODULE_DESCRIPTION("ASoC driver for Xilinx I2S audio");
 MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Praveen Vuppala  <praveenv@xilinx.com>");
 MODULE_AUTHOR("Maruthi Srinivas Bayyavarapu <maruthis@xilinx.com>");
-- 
2.43.0

Re: [PATCH 0/7] ASoC: Add missing module descriptions

[Dragan Simic]

On 2024-05-08 11:18, Takashi Iwai wrote:
> here is a trivial patch series to add the missing module descriptions
> to ASoC drivers, as make W=1 starts complaining the lack of
> MODULE_DESCRIPTION() since recently.
> 
> The whole sound/soc/sof/* are untouched as there are too many files
> involved, and I left SOF people to address them.

The changes are looking good to me.  Thus, please add for the
entire series:

Reviewed-by: Dragan Simic <dsimic@manjaro.org>

> ===
> 
> Takashi Iwai (7):
>   ASoC: ab8500: Add missing module description
>   ASoC: sigmadsp: Add missing module description
>   ASoC: qcom: Add missing module descriptions
>   ASoC: dmaengine: Add missing module description
>   ASoC: topology-test: Add missing module description
>   ASoC: ux500: Add missing module description
>   ASoC: xilinx: Add missing module descriptions
> 
>  sound/soc/codecs/ab8500-codec.c       | 1 +
>  sound/soc/codecs/sigmadsp.c           | 1 +
>  sound/soc/qcom/common.c               | 2 ++
>  sound/soc/qcom/qdsp6/q6dsp-common.c   | 2 ++
>  sound/soc/soc-generic-dmaengine-pcm.c | 1 +
>  sound/soc/soc-topology-test.c         | 1 +
>  sound/soc/ux500/ux500_msp_dai.c       | 1 +
>  sound/soc/xilinx/xlnx_formatter_pcm.c | 2 ++
>  sound/soc/xilinx/xlnx_i2s.c           | 1 +
>  9 files changed, 12 insertions(+)

Re: [PATCH 0/7] ASoC: Add missing module descriptions

[Mark Brown]

On Wed, 08 May 2024 11:18:59 +0200, Takashi Iwai wrote:
> here is a trivial patch series to add the missing module descriptions
> to ASoC drivers, as make W=1 starts complaining the lack of
> MODULE_DESCRIPTION() since recently.
> 
> The whole sound/soc/sof/* are untouched as there are too many files
> involved, and I left SOF people to address them.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/7] ASoC: ab8500: Add missing module description
      commit: 1dec672e8686b824aa8742cf9cc00748289de95b
[2/7] ASoC: sigmadsp: Add missing module description
      commit: 1a7dc1cf9e46d2e4c732679775c3a06fba9d94a8
[3/7] ASoC: qcom: Add missing module descriptions
      commit: 6d21f0a2be88d34e53fcbf66fb8e298787837c01
[4/7] ASoC: dmaengine: Add missing module description
      commit: 2c846d7cc4ee3382aed6dfd322fcaaf309eb2c9a
[5/7] ASoC: topology-test: Add missing module description
      commit: ea762d10b92a423b6e4980241a7bfa809c7cffd1
[6/7] ASoC: ux500: Add missing module description
      commit: e85d8aeef23376ef10569c555819d301f3364f28
[7/7] ASoC: xilinx: Add missing module descriptions
      commit: 3423ad19ea912694a15ebbc48cbc8e1fcd8439da

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark