* [PATCH] ALSA: hda/conexant - Use cached pin control for Node 0x1d on HP EliteOne 1000 G2
@ 2024-10-16 8:07 Vasiliy Kovalev
2024-10-16 8:30 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Vasiliy Kovalev @ 2024-10-16 8:07 UTC (permalink / raw)
To: Takashi Iwai, linux-sound, linux-kernel
Cc: Vasiliy Kovalev, Kai-Heng Feng, Takashi Iwai
The cached version avoids redundant commands to the codec, improving
stability and reducing unnecessary operations. This change ensures
better power management and reliable restoration of pin configurations,
especially after hibernation (S4) and other power transitions.
Fixes: 9988844c457f ("ALSA: hda/conexant - Fix audio routing for HP EliteOne 1000 G2")
Suggested-by: Kai-Heng Feng <kaihengf@nvidia.com>
Suggested-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org>
---
sound/pci/hda/patch_conexant.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
index 3a647f3c65d1b..e7107a14fa9dc 100644
--- a/sound/pci/hda/patch_conexant.c
+++ b/sound/pci/hda/patch_conexant.c
@@ -330,7 +330,7 @@ static void cxt_fixup_update_pinctl(struct hda_codec *codec,
* This is the value stored in the codec register after
* the correct initialization of the previous windows boot.
*/
- snd_hda_set_pin_ctl(codec, 0x1d, AC_PINCTL_HP_EN);
+ snd_hda_set_pin_ctl_cache(codec, 0x1d, AC_PINCTL_HP_EN);
}
}
--
2.33.8
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: hda/conexant - Use cached pin control for Node 0x1d on HP EliteOne 1000 G2
2024-10-16 8:07 [PATCH] ALSA: hda/conexant - Use cached pin control for Node 0x1d on HP EliteOne 1000 G2 Vasiliy Kovalev
@ 2024-10-16 8:30 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2024-10-16 8:30 UTC (permalink / raw)
To: Vasiliy Kovalev
Cc: Takashi Iwai, linux-sound, linux-kernel, Kai-Heng Feng,
Takashi Iwai
On Wed, 16 Oct 2024 10:07:13 +0200,
Vasiliy Kovalev wrote:
>
> The cached version avoids redundant commands to the codec, improving
> stability and reducing unnecessary operations. This change ensures
> better power management and reliable restoration of pin configurations,
> especially after hibernation (S4) and other power transitions.
>
> Fixes: 9988844c457f ("ALSA: hda/conexant - Fix audio routing for HP EliteOne 1000 G2")
> Suggested-by: Kai-Heng Feng <kaihengf@nvidia.com>
> Suggested-by: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-16 8:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-16 8:07 [PATCH] ALSA: hda/conexant - Use cached pin control for Node 0x1d on HP EliteOne 1000 G2 Vasiliy Kovalev
2024-10-16 8:30 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox