From: Ryan Walklin <ryan@testtoast.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Chris Morgan <macroalpha82@gmail.com>,
Philippe Simons <simons.philippe@gmail.com>
Cc: linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, Ryan Walklin <ryan@testtoast.com>
Subject: [PATCH v3 0/7] ASoC: add Allwinner H616 audio codec support
Date: Wed, 23 Oct 2024 20:56:56 +1300 [thread overview]
Message-ID: <20241023075917.186835-1-ryan@testtoast.com> (raw)
Hi All,
V3 of this patch adding support for the Allwinner H616 (and variant)'s audio codec. Some clarification of comments, particularly regarding the clock driver changes, and a small fix for the device tree binding (apologies I forgot to re-run dt_binding_check on V2). Review comments otherwise addressed and reviews noted.
Changelog v1..v2:
- Reordered patches to group ASoC changes
- Corrected PLL_AUDIO clock dividers to match values from manual and vendor SDK.
- Remove PLL_AUDIO_4X clock from the device tree binding (not used in the driver).
- Restrict TX-only DMA changes to the H616.
- Change the codec name to fit into the 16 char limit.
- Move the codec (and spdif) blocks in the H616 DTSI to restore address-order.
- Add board enablement (and power/GPIO changes for RG35XX to support speaker amp).
Changelog v2..v3:
- Update clock driver patch commit message and inline comments to more accurately describe SDM changes.
- Fix missing "-" in H616 conditional binding as reported by dt_binding_check
- Add additional clarification of internal playback_only quirk in sun4i-codec driver
- Add short driver_name to H616 codec driver and restore descriptive name.
- Remove leading 0 from codec node's address in H616 device tree to match other blocks.
Original blurb below:
Hi,
The Allwinner H616 has a playback-only audio codec, with a single stereo or differential-mono line output.
This patch adds support for the H616 (and H313/H618/H700/T507) SoC. Based on the Allwinner kernel SDK driver, and tested on the H700.
Regards,
Ryan
Marcus Cooper (2):
ASoC: sun4i-codec: Add support for different DAC FIFOC addresses to
quirks
ASoC: sun4i-codec: Add playback only flag to quirks
Ryan Walklin (5):
clk: sunxi-ng: h616: Add sigma-delta modulation settings for audio PLL
dt-bindings: allwinner: add H616 sun4i audio codec binding
ASoC: sun4i-codec: support allwinner H616 codec
arm64: dts: allwinner: h616: Add audio codec node
arm64: dts: allwinner: h313/h616/h618/h700: Enable audio codec for all
supported boards
.../sound/allwinner,sun4i-a10-codec.yaml | 53 +++-
.../dts/allwinner/sun50i-h313-tanix-tx1.dts | 5 +
.../allwinner/sun50i-h616-orangepi-zero.dtsi | 5 +
.../dts/allwinner/sun50i-h616-x96-mate.dts | 5 +
.../arm64/boot/dts/allwinner/sun50i-h616.dtsi | 44 ++-
.../allwinner/sun50i-h618-orangepi-zero2w.dts | 5 +
.../sun50i-h618-transpeed-8k618-t.dts | 5 +
.../sun50i-h700-anbernic-rg35xx-2024.dts | 13 +-
drivers/clk/sunxi-ng/ccu-sun50i-h616.c | 46 ++-
sound/soc/sunxi/sun4i-codec.c | 298 +++++++++++++++---
10 files changed, 404 insertions(+), 75 deletions(-)
--
2.47.0
next reply other threads:[~2024-10-23 7:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 7:56 Ryan Walklin [this message]
2024-10-23 7:56 ` [PATCH v3 1/7] clk: sunxi-ng: h616: Add sigma-delta modulation settings for audio PLL Ryan Walklin
2024-10-25 9:38 ` Andre Przywara
2024-10-25 13:20 ` Code Kipper
2024-10-25 14:59 ` Chen-Yu Tsai
2024-10-23 7:56 ` [PATCH v3 2/7] dt-bindings: allwinner: add H616 sun4i audio codec binding Ryan Walklin
2024-10-24 7:15 ` Krzysztof Kozlowski
2024-10-24 12:14 ` Mark Brown
2024-10-23 7:56 ` [PATCH v3 3/7] ASoC: sun4i-codec: Add support for different DAC FIFOC addresses to quirks Ryan Walklin
2024-10-23 7:57 ` [PATCH v3 4/7] ASoC: sun4i-codec: Add playback only flag " Ryan Walklin
2024-10-23 7:57 ` [PATCH v3 5/7] ASoC: sun4i-codec: support allwinner H616 codec Ryan Walklin
2024-10-23 7:57 ` [PATCH v3 6/7] arm64: dts: allwinner: h616: Add audio codec node Ryan Walklin
2024-10-23 7:57 ` [PATCH v3 7/7] arm64: dts: allwinner: h313/h616/h618/h700: Enable audio codec for all supported boards Ryan Walklin
2024-10-25 10:05 ` Andre Przywara
2024-10-24 12:15 ` [PATCH v3 0/7] ASoC: add Allwinner H616 audio codec support Mark Brown
2024-10-24 20:16 ` (subset) " Mark Brown
2024-10-25 15:21 ` Chen-Yu Tsai
2024-10-25 15:23 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241023075917.186835-1-ryan@testtoast.com \
--to=ryan@testtoast.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=macroalpha82@gmail.com \
--cc=perex@perex.cz \
--cc=samuel@sholland.org \
--cc=simons.philippe@gmail.com \
--cc=tiwai@suse.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox