* [PATCH] ASoC: cs42l84: remove incorrect of_match_ptr()
@ 2024-10-29 9:23 Arnd Bergmann
2024-10-29 18:56 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2024-10-29 9:23 UTC (permalink / raw)
To: David Rhodes, Richard Fitzgerald, Martin Povišer,
Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Neal Gompa, James Calligeros, Hector Martin
Cc: Arnd Bergmann, linux-sound, patches, asahi, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The use of of_match_ptr() is incorrect here and just causes
a warning:
sound/soc/codecs/cs42l84.c:1084:34: error: unused variable 'cs42l84_of_match' [-Werror,-Wunused-const-variable]
Fixes: 250304a0fb34 ("ASoC: cs42l84: Add new codec driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
sound/soc/codecs/cs42l84.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/cs42l84.c b/sound/soc/codecs/cs42l84.c
index 47731cdc0e67..d176add8c4a6 100644
--- a/sound/soc/codecs/cs42l84.c
+++ b/sound/soc/codecs/cs42l84.c
@@ -1096,7 +1096,7 @@ MODULE_DEVICE_TABLE(i2c, cs42l84_id);
static struct i2c_driver cs42l84_i2c_driver = {
.driver = {
.name = "cs42l84",
- .of_match_table = of_match_ptr(cs42l84_of_match),
+ .of_match_table = cs42l84_of_match,
},
.id_table = cs42l84_id,
.probe = cs42l84_i2c_probe,
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: cs42l84: remove incorrect of_match_ptr()
2024-10-29 9:23 [PATCH] ASoC: cs42l84: remove incorrect of_match_ptr() Arnd Bergmann
@ 2024-10-29 18:56 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2024-10-29 18:56 UTC (permalink / raw)
To: David Rhodes, Richard Fitzgerald, Martin Povišer,
Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Neal Gompa,
James Calligeros, Hector Martin, Arnd Bergmann
Cc: Arnd Bergmann, linux-sound, patches, asahi, linux-kernel
On Tue, 29 Oct 2024 09:23:55 +0000, Arnd Bergmann wrote:
> The use of of_match_ptr() is incorrect here and just causes
> a warning:
>
> sound/soc/codecs/cs42l84.c:1084:34: error: unused variable 'cs42l84_of_match' [-Werror,-Wunused-const-variable]
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: cs42l84: remove incorrect of_match_ptr()
commit: 0d4f74febc9d92d88099aff01f121b7f5f942c8f
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-29 18:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-29 9:23 [PATCH] ASoC: cs42l84: remove incorrect of_match_ptr() Arnd Bergmann
2024-10-29 18:56 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox