[RESEND PATCH] ASoC: tegra: Fix ADX S24_LE audio format

[RESEND PATCH] ASoC: tegra: Fix ADX S24_LE audio format

[Thorsten Blum]

Commit 4204eccc7b2a ("ASoC: tegra: Add support for S24_LE audio format")
added support for the S24_LE audio format, but duplicated S16_LE in
OUT_DAI() for ADX instead.

Fix this by adding support for the S24_LE audio format.

Compile-tested only.

Cc: stable@vger.kernel.org
Fixes: 4204eccc7b2a ("ASoC: tegra: Add support for S24_LE audio format")
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 sound/soc/tegra/tegra210_adx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/tegra/tegra210_adx.c b/sound/soc/tegra/tegra210_adx.c
index 3e6e8f51f380..0aa93b948378 100644
--- a/sound/soc/tegra/tegra210_adx.c
+++ b/sound/soc/tegra/tegra210_adx.c
@@ -264,7 +264,7 @@ static const struct snd_soc_dai_ops tegra210_adx_out_dai_ops = {
 			.rates = SNDRV_PCM_RATE_8000_192000,	\
 			.formats = SNDRV_PCM_FMTBIT_S8 |	\
 				   SNDRV_PCM_FMTBIT_S16_LE |	\
-				   SNDRV_PCM_FMTBIT_S16_LE |	\
+				   SNDRV_PCM_FMTBIT_S24_LE |	\
 				   SNDRV_PCM_FMTBIT_S32_LE,	\
 		},						\
 		.capture = {					\
@@ -274,7 +274,7 @@ static const struct snd_soc_dai_ops tegra210_adx_out_dai_ops = {
 			.rates = SNDRV_PCM_RATE_8000_192000,	\
 			.formats = SNDRV_PCM_FMTBIT_S8 |	\
 				   SNDRV_PCM_FMTBIT_S16_LE |	\
-				   SNDRV_PCM_FMTBIT_S16_LE |	\
+				   SNDRV_PCM_FMTBIT_S24_LE |	\
 				   SNDRV_PCM_FMTBIT_S32_LE,	\
 		},						\
 		.ops = &tegra210_adx_out_dai_ops,		\
-- 
2.48.1

Re: [RESEND PATCH] ASoC: tegra: Fix ADX S24_LE audio format

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]

On Sun, Mar 02, 2025 at 11:59:25PM +0100, Thorsten Blum wrote:
> Commit 4204eccc7b2a ("ASoC: tegra: Add support for S24_LE audio format")
> added support for the S24_LE audio format, but duplicated S16_LE in
> OUT_DAI() for ADX instead.

Please allow a reasonable time for review.  People get busy, go on
holiday, attend conferences and so on so unless there is some reason for
urgency (like critical bug fixes) please allow at least a couple of
weeks for review.  If there have been review comments then people may be
waiting for those to be addressed.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [RESEND PATCH] ASoC: tegra: Fix ADX S24_LE audio format

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 667 bytes --]

On Sun, Mar 02, 2025 at 11:59:25PM +0100, Thorsten Blum wrote:
> Commit 4204eccc7b2a ("ASoC: tegra: Add support for S24_LE audio format")
> added support for the S24_LE audio format, but duplicated S16_LE in
> OUT_DAI() for ADX instead.
> 
> Fix this by adding support for the S24_LE audio format.
> 
> Compile-tested only.
> 
> Cc: stable@vger.kernel.org
> Fixes: 4204eccc7b2a ("ASoC: tegra: Add support for S24_LE audio format")
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  sound/soc/tegra/tegra210_adx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Good catch!

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]