Linux Sound subsystem development
 help / color / mirror / Atom feed
* [PATCH 0/1] ALSA: hda/realtek: Add quirk for Lenovo Yoga Pro 7 14ASP10
@ 2025-05-16 19:08 Ed Burcher
  2025-05-16 19:08 ` [PATCH 1/1] " Ed Burcher
  0 siblings, 1 reply; 4+ messages in thread
From: Ed Burcher @ 2025-05-16 19:08 UTC (permalink / raw)
  To: perex, tiwai; +Cc: git, linux-sound

Hi, I found that the Lenovo Yoga Pro 7 Gen 10 (AMD) model 14ASP10 (board 83LX) 
needs the existing ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN quirk to be used for 
the bass speakers to work correctly.

I'm submitting a patch for your consideration.

Thanks

Ed Burcher (1):
  ALSA: hda/realtek: Add quirk for Lenovo Yoga Pro 7 14ASP10

 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.48.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/1] ALSA: hda/realtek: Add quirk for Lenovo Yoga Pro 7 14ASP10
  2025-05-16 19:08 [PATCH 0/1] ALSA: hda/realtek: Add quirk for Lenovo Yoga Pro 7 14ASP10 Ed Burcher
@ 2025-05-16 19:08 ` Ed Burcher
  2025-05-19 21:22   ` Takashi Iwai
  0 siblings, 1 reply; 4+ messages in thread
From: Ed Burcher @ 2025-05-16 19:08 UTC (permalink / raw)
  To: perex, tiwai; +Cc: git, linux-sound

Lenovo Yoga Pro 7 (gen 10) with Realtek ALC3306 and combined CS35L56
amplifiers need quirk ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN to
enable bass
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 8a2b09e4a7d5..4d719dddf02f 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -11300,6 +11300,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x38fa, "Thinkbook 16P Gen5", ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD),
 	SND_PCI_QUIRK(0x17aa, 0x38fd, "ThinkBook plus Gen5 Hybrid", ALC287_FIXUP_TAS2781_I2C),
 	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
+	SND_PCI_QUIRK(0x17aa, 0x390d, "Lenovo Yoga Pro 7 14ASP10", ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
 	SND_PCI_QUIRK(0x17aa, 0x3913, "Lenovo 145", ALC236_FIXUP_LENOVO_INV_DMIC),
 	SND_PCI_QUIRK(0x17aa, 0x391f, "Yoga S990-16 pro Quad YC Quad", ALC287_FIXUP_TAS2781_I2C),
 	SND_PCI_QUIRK(0x17aa, 0x3920, "Yoga S990-16 pro Quad VECO Quad", ALC287_FIXUP_TAS2781_I2C),
-- 
2.48.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] ALSA: hda/realtek: Add quirk for Lenovo Yoga Pro 7 14ASP10
  2025-05-16 19:08 ` [PATCH 1/1] " Ed Burcher
@ 2025-05-19 21:22   ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2025-05-19 21:22 UTC (permalink / raw)
  To: Ed Burcher; +Cc: perex, tiwai, linux-sound

On Fri, 16 May 2025 21:08:32 +0200,
Ed Burcher wrote:
> 
> Lenovo Yoga Pro 7 (gen 10) with Realtek ALC3306 and combined CS35L56
> amplifiers need quirk ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN to
> enable bass

The code change looks OK, but could you resubmit with your
Signed-off-by tag?  This is a legal requirement.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 0/1] ALSA: hda/realtek: Add quirk for Lenovo Yoga Pro 7 14ASP10
@ 2025-05-19 22:49 Ed Burcher
  0 siblings, 0 replies; 4+ messages in thread
From: Ed Burcher @ 2025-05-19 22:49 UTC (permalink / raw)
  To: perex, tiwai; +Cc: git, linux-sound

Hi, I found that the Lenovo Yoga Pro 7 Gen 10 (AMD) model 14ASP10 (board 83LX) 
needs the existing ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN quirk to be used for 
the bass speakers to work correctly.

I'm resubmitting the patch for your consideration. (I added the Signed-off-by tag)

Thanks

Ed Burcher (1):
  ALSA: hda/realtek: Add quirk for Lenovo Yoga Pro 7 14ASP10

 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.48.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-05-19 22:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-16 19:08 [PATCH 0/1] ALSA: hda/realtek: Add quirk for Lenovo Yoga Pro 7 14ASP10 Ed Burcher
2025-05-16 19:08 ` [PATCH 1/1] " Ed Burcher
2025-05-19 21:22   ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2025-05-19 22:49 [PATCH 0/1] " Ed Burcher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox