From: "Šerif Rami" <ramiserifpersia@gmail.com>
To: ramiserifpersia@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
perex@perex.cz, tiwai@suse.com
Subject: Re: [PATCH v5 0/7] ALSA: usb-audio: Add driver for TASCAM US-144MKII
Date: Thu, 14 Aug 2025 17:38:07 +0200 [thread overview]
Message-ID: <20250814153807.12834-1-ramiserifpersia@gmail.com> (raw)
In-Reply-To: <20250814102534.34439-8-ramiserifpersia@gmail.com>
Hi,
While reviewing my v5 series, I noticed that the default values for the
digital in/out kcontrols were lost during patch splitting. They should
default to 1 (currently 0), which is incorrect for these controls.
us144mkii.c:
@@ -489,6 +489,8 @@ static int tascam_probe(struct usb_interface *intf,
tascam->dev = usb_get_dev(dev);
tascam->card = card;
tascam->iface0 = intf;
+ tascam->digital_out_source = 1;
+ tascam->capture_34_source = 1;
I will restore these defaults in the appropriate patch in the next revision.
Thanks,
Šerif
next prev parent reply other threads:[~2025-08-14 15:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 10:25 [PATCH v5 0/7] ALSA: usb-audio: Add driver for TASCAM US-144MKII Šerif Rami
2025-08-14 10:25 ` [PATCH v5 1/7] ALSA: usb-audio: Add initial " Šerif Rami
2025-08-14 10:25 ` [PATCH v5 2/7] ALSA: usb-audio: us144mkii: Add PCM core infrastructure Šerif Rami
2025-08-14 10:25 ` [PATCH v5 3/7] ALSA: usb-audio: us144mkii: Implement audio playback and feedback Šerif Rami
2025-08-14 10:25 ` [PATCH v5 4/7] ALSA: usb-audio: us144mkii: Implement audio capture and decoding Šerif Rami
2025-08-14 10:25 ` [PATCH v5 5/7] ALSA: usb-audio: us144mkii: Add MIDI support and mixer controls Šerif Rami
2025-08-14 10:25 ` [PATCH v5 6/7] ALSA: usb-audio: us144mkii: Add deep sleep command Šerif Rami
2025-08-14 10:25 ` [PATCH v5 7/7] ALSA: usb-audio: Add infrastructure for TASCAM US-144MKII Šerif Rami
2025-08-14 15:38 ` Šerif Rami [this message]
2025-08-14 15:52 ` [PATCH v5 0/7] ALSA: usb-audio: Add driver " Takashi Iwai
2025-08-14 16:05 ` Šerif Rami
2025-08-14 16:13 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250814153807.12834-1-ramiserifpersia@gmail.com \
--to=ramiserifpersia@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox