Re: [PATCH v5 0/7] ALSA: usb-audio: Add driver for TASCAM US-144MKII

[Takashi Iwai <tiwai@suse.de>]

On Thu, 14 Aug 2025 12:25:27 +0200,
Šerif Rami wrote:
> 
> This is v5 of the patch series to add a new driver
> for the TASCAM US-144MKII USB audio interface.
> 
> Changes in v5:
>   - Addressed u64 remainder in Patch 2/7.
>   - Refactored guard() calls for spinlocks to scoped_guard() for ones
>     that got missed(hopefully all).
> 
> Changes in v4:
>   - Removing leading spaces from #defines as requested.
>   - Renaming fpoInitPattern to fpo_init_pattern.
>   - Removing unnecessary kfree() calls.
>   - Replacing manual lock/unlock patterns with scoped_guard().
> 
> Changes in v3
>   - Corrected v2 invalid patches order
>   The v2 submission included mix of patches for v2 that were unusable.
>   These new patches are valid now.
> 
> Changes in v2:
>   - Patch 1: Dropped blank line, initialized `__free(kfree)` variable to
>      NULL, and fixed `struct tascam_card` indentation.
>   - Patch 2: Corrected indentation in `us144mkii.h`.
>   - Patch 3: Changed `fpoInitPattern` to `fpo_init_pattern` (snake_case),
>      initialized `__free(kfree)` variable, and replaced
>      `guard(spinlock_irqsave)` with `scoped_guard()`.
>   - Patch 5: Updated control names to standard "Playback Source" and
>      "Capture Source" formats, and initialized `__free(kfree)` variable to NULL.
>   - Patch 6: Re-organized code style alignments into previous patches.
>   - Patch 7: Fixed trailing whitespace warning.
> 
> Šerif Rami (7):
>   ALSA: usb-audio: Add initial driver for TASCAM US-144MKII
>   ALSA: usb-audio: us144mkii: Add PCM core infrastructure
>   ALSA: usb-audio: us144mkii: Implement audio playback and feedback
>   ALSA: usb-audio: us144mkii: Implement audio capture and decoding
>   ALSA: usb-audio: us144mkii: Add MIDI support and mixer controls
>   ALSA: usb-audio: us144mkii: Add deep sleep command
>   ALSA: usb-audio: Add infrastructure for TASCAM US-144MKII

Just cosmetic: the open brace of scoped_guard() should be in the same
line of scoped_guard() itself, i.e.

	scoped_guard(...) {
		...
	}

You seem to have put it in the next line, but better to align with the
standard.


thanks,

Takashi