From: Conor Dooley <conor@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: joakim.zhang@cixtech.com, lgirdwood@gmail.com,
broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, perex@perex.cz, tiwai@suse.com,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
cix-kernel-upstream@cixtech.com
Subject: Re: [PATCH V1 1/3] dt-bindings: sound: add binding for CIX IPBLOQ HDA controller
Date: Fri, 31 Oct 2025 14:57:32 +0000 [thread overview]
Message-ID: <20251031-grouped-retold-9714ab609675@spud> (raw)
In-Reply-To: <20251031-pearl-pheasant-from-atlantis-bf4e7a@kuoka>
[-- Attachment #1: Type: text/plain, Size: 724 bytes --]
On Fri, Oct 31, 2025 at 09:58:48AM +0100, Krzysztof Kozlowski wrote:
> On Thu, Oct 30, 2025 at 07:09:26PM +0800, joakim.zhang@cixtech.com wrote:
>
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 2
>
> You should list the items instead with description.
>
> > +
> > + clock-names:
> > + maxItems: 2
>
> No, you need to list the items. There is no syntax like that.
>
> > +
> > + resets:
> > + maxItems: 1
> > +
> > + reset-names:
> > + maxItems: 1
>
> No, you need to list the items.
Since it wasn't mentioned why the items need to be listed, if you don't
list the items for a -names property, then they can be anything and you
cannot actually use them in drivers.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-10-31 14:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 11:09 [PATCH V1 0/3] ALSA: hda: add CIX IPBLOQ HDA controller support joakim.zhang
2025-10-30 11:09 ` [PATCH V1 1/3] dt-bindings: sound: add binding for CIX IPBLOQ HDA controller joakim.zhang
2025-10-31 8:58 ` Krzysztof Kozlowski
2025-10-31 9:28 ` Krzysztof Kozlowski
2025-10-31 14:57 ` Conor Dooley [this message]
2025-11-03 10:36 ` Joakim Zhang
2025-10-30 11:09 ` [PATCH V1 2/3] ALSA: hda: add bus callback for address translation joakim.zhang
2025-10-31 11:28 ` Takashi Iwai
2025-11-03 11:30 ` Joakim Zhang
2025-11-27 9:44 ` Joakim Zhang
2025-11-28 17:22 ` Takashi Iwai
2025-12-01 8:14 ` Joakim Zhang
2025-12-01 8:41 ` Takashi Iwai
2025-12-01 10:58 ` Joakim Zhang
2025-10-30 11:09 ` [PATCH V1 3/3] ALSA: hda: add CIX IPBLOQ HDA controller support joakim.zhang
2025-10-31 9:05 ` Krzysztof Kozlowski
2025-10-31 9:57 ` Takashi Iwai
2025-11-03 10:43 ` Joakim Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251031-grouped-retold-9714ab609675@spud \
--to=conor@kernel.org \
--cc=broonie@kernel.org \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joakim.zhang@cixtech.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox